From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: olteanv@gmail.com, robh@kernel.org,
linux-phy@lists.infradead.org, vkoul@kernel.org,
devicetree@vger.kernel.org, neil.armstrong@linaro.org,
conor+dt@kernel.org
Subject: Re: [PATCH 6/8] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue
Date: Wed, 12 Aug 2026 01:11:24 +0000 [thread overview]
Message-ID: <20260812011124.A000E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812010157.1772849-7-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#include <linux/bitfield.h>` for the `FIELD_PREP` macro.
--
--- Patch [6]: [PATCH 6/8] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue ---
commit b7b018e07e03e9eca049254747c91235246ffef8
Author: Marek Vasut <marex@nabladev.com>
usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue
This commit adds support for the ST STM32MP2 DWC3 USB controller glue logic
to the generic DWC3 platform driver.
> diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c
> index ca69ac0eb07ce..0946ed61647b6 100644
> --- a/drivers/usb/dwc3/dwc3-generic-plat.c
> +++ b/drivers/usb/dwc3/dwc3-generic-plat.c
[ ... ]
> @@ -85,6 +91,38 @@ static int dwc3_spacemit_k1_init(struct dwc3_generic *dwc3g)
> return 0;
> }
>
> +static int dwc3_stm32mp25_init(struct dwc3_generic *dwc3g)
> +{
[ ... ]
> + return regmap_update_bits(regmap, drcr,
> + STM32MP2_USB3DRCR_HOST_PORT_POWER_CONTROL_PRESENT |
> + STM32MP2_USB3DRCR_OVRCUR_POLARITY |
> + STM32MP2_USB3DRCR_VBUSEN_POLARITY |
> + STM32MP2_USB3DRCR_USB2ONLYD |
> + STM32MP2_USB3DRCR_USB2ONLYH,
> + FIELD_PREP(STM32MP2_USB3DRCR_HOST_PORT_POWER_CONTROL_PRESENT,
> + prt_pwr_ctrl) |
[Severity: Low]
Does this file need to include linux/bitfield.h?
The FIELD_PREP macro is used here to prepare the bitfields, but the header
defining it does not appear to be included. If the header isn't pulled in
transitively, will this result in a build failure?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812010157.1772849-1-marex@nabladev.com?part=6
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-08-12 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 0:55 [PATCH 0/8] arm64: dts: phy: st: usb: Add STM32MP2 USB support Marek Vasut
2026-08-12 0:55 ` [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY Marek Vasut
2026-08-12 1:05 ` sashiko-bot
2026-08-12 2:45 ` Rob Herring (Arm)
2026-08-12 0:55 ` [PATCH 2/8] phy: stm32: Add support for " Marek Vasut
2026-08-12 1:12 ` sashiko-bot
2026-08-12 0:55 ` [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-controllers property Marek Vasut
2026-08-12 1:10 ` sashiko-bot
2026-08-12 0:55 ` [PATCH 4/8] dt-bindings: usb: generic-ohci: " Marek Vasut
2026-08-12 0:55 ` [PATCH 5/8] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller Marek Vasut
2026-08-12 1:08 ` sashiko-bot
2026-08-12 0:55 ` [PATCH 6/8] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue Marek Vasut
2026-08-12 1:11 ` sashiko-bot [this message]
2026-08-12 0:55 ` [PATCH 7/8] arm64: dts: st: Add USB nodes on stm32mp231 Marek Vasut
2026-08-12 0:55 ` [PATCH 8/8] arm64: dts: st: Add USB nodes on stm32mp251 Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812011124.A000E1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=marex@nabladev.com \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox