From: sashiko-bot@kernel.org
To: "George Moussalem" <george.moussalem@outlook.com>
Cc: robh@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
olteanv@gmail.com, linux-phy@lists.infradead.org
Subject: Re: [PATCH v2 05/14] arm64: dts: qcom: ipq5018: Flatten usb controller node
Date: Wed, 12 Aug 2026 09:56:01 +0000 [thread overview]
Message-ID: <20260812095602.007CF1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260812-ipq5018-usb3-v2-5-8f355d7ff0ef@outlook.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The flattened `qcom,snps-dwc3` node provides a `reg` memory region size (`0xe000`) that is too small to cover the qscratch wrapper registers, leading to a `-EBUSY` probe failure.
--
--- Patch [5]: [PATCH v2 05/14] arm64: dts: qcom: ipq5018: Flatten usb controller node ---
commit e097cafa032cb2e224c3052691cef507b25b9831
Author: George Moussalem <george.moussalem@outlook.com>
arm64: dts: qcom: ipq5018: Flatten usb controller node
This commit flattens the USB controller node and updates it to use the
latest bindings and flattened driver approach.
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index abd12b31a5147..7b8c9465f4442 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
[ ... ]
> - usb: usb@8af8800 {
> - compatible = "qcom,ipq5018-dwc3", "qcom,dwc3";
> - reg = <0x08af8800 0x400>;
> -
> - interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pwr_event",
> - "dp_hs_phy_irq",
> - "dm_hs_phy_irq";
> + usb: usb@8a00000 {
> + compatible = "qcom,ipq5018-dwc3", "qcom,snps-dwc3";
> + reg = <0x08a00000 0xe000>;
[Severity: High]
Does this reg size correctly cover the qscratch wrapper registers?
The Qualcomm wrapper driver (dwc3-qcom.c) artificially expands the memory
resource size up to the 0xf8800 offset. Since the new flattened node here
only allocates a length of 0xe000 bytes, won't devm_ioremap_resource()
fail with -EBUSY during probe when the core driver requests a region that
extends beyond this parent device boundary?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com?part=5
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-08-12 9:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 9:34 [PATCH v2 00/14] Enable USB3 for Qualcomm IPQ5018 and IPQ5332 George Moussalem via B4 Relay
2026-08-12 9:34 ` [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY George Moussalem via B4 Relay
2026-08-12 9:41 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 02/14] phy: qcom: Introduce Qualcomm IPQ5332 Super-Speed USB UNIPHY driver George Moussalem via B4 Relay
2026-08-12 9:48 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 03/14] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node George Moussalem via B4 Relay
2026-08-12 9:51 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 04/14] arm64: dts: qcom: ipq5332: Flatten usb controller node George Moussalem via B4 Relay
2026-08-12 10:25 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 05/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:56 ` sashiko-bot [this message]
2026-08-12 9:34 ` [PATCH v2 06/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5332 George Moussalem via B4 Relay
2026-08-12 9:46 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 07/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 George Moussalem via B4 Relay
2026-08-12 9:51 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 08/14] arm64: dts: qcom: ipq5332: Add clocks required for USB3 support George Moussalem via B4 Relay
2026-08-12 9:34 ` [PATCH v2 09/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:48 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 10/14] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node George Moussalem via B4 Relay
2026-08-12 9:55 ` sashiko-bot
2026-08-12 10:56 ` Sergey Shtylyov
2026-08-12 9:34 ` [PATCH v2 11/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:57 ` sashiko-bot
2026-08-12 10:57 ` Sergey Shtylyov
2026-08-12 9:34 ` [PATCH v2 12/14] arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY George Moussalem via B4 Relay
2026-08-12 9:54 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 13/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:57 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 14/14] arm64: defconfig: Enable qcom USB UNIPHY driver George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812095602.007CF1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox