From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org,
linux-phy@lists.infradead.org, olteanv@gmail.com
Subject: Re: [PATCHv2] phy: mediatek: tphy: simplify main allocation
Date: Wed, 12 Aug 2026 18:25:04 +0000 [thread overview]
Message-ID: <20260812182504.D06C51F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260812181857.64544-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch regarding the removal of a NULL check.
--
--- Patch [1]: [PATCHv2] phy: mediatek: tphy: simplify main allocation ---
commit 293b5d4728ba8a57dc62ffcf5575f966eef04ba8
Author: Rosen Penev <rosenp@gmail.com>
phy: mediatek: tphy: simplify main allocation
This commit simplifies the main allocation by replacing a separate kzalloc
and kcalloc with a single kzalloc using a flexible array member. It also
shuffles code to satisfy __counted_by requirements.
> Removed NULL check from of_get_match_data as it's never NULL per the
> device table.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> ---
> v2: add back NULL check
[Severity: Medium]
This isn't a bug, but the commit message body states the NULL check was
removed, while the v2 notes and the patch itself show it was retained. Should
the commit message be updated to remove this line so it accurately reflects
the applied changes?
> diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
> index acf5065295072..e9b9e667b3195 100644
> --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
[ ... ]
> @@ -1572,22 +1572,19 @@ static int mtk_tphy_probe(struct platform_device *pdev)
[ ... ]
> + tphy->nphys = nphys;
> + tphy->dev = dev;
> tphy->pdata = of_device_get_match_data(dev);
> if (!tphy->pdata)
> return -EINVAL;
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812181857.64544-1-rosenp@gmail.com?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-08-12 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 18:18 [PATCHv2] phy: mediatek: tphy: simplify main allocation Rosen Penev
2026-08-12 18:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812182504.D06C51F00A3E@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox