From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9EB9C5CFDB for ; Wed, 12 Aug 2026 22:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=da81RIOqynyL4ZPOazGOnRqPRC71lahE9YkF4+C+KfM=; b=zytQEfU+zOmUpc ihBgBGdvIKuMaXaFDWXM4Y6q6J0S3E4osWNvtn+mRrk0JqDiE2Pp6uea86hK1znPklph0jyaZ5YvT tVQE/xOspaehKqiYIdgxL1HTltfLKzFN9+bqL1GwogWUjK3rII9FR2d1KVoBh2gFBod3WdAhvFtLK h7u9YnfaG7DzknydZ7yzrcnW7TS+pZjumF1uSGB+/qx0v0oU7T405HoAlQAFDbsAFUc/oR3jfBxtE kXjUM7SdslCvJtgMCpfOm0ptzR62RnUGtinZ+zEcV3UiK2gnbrvfVhviCAtgXB7B1LiqQiPqifi6V 2Pt8HGowujJkKBs6GN6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuHmu-0000000H6be-0kA8; Wed, 12 Aug 2026 22:51:08 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuHms-0000000H6bC-28lN; Wed, 12 Aug 2026 22:51:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB76B42D67; Wed, 12 Aug 2026 22:51:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CA8B1F000E9; Wed, 12 Aug 2026 22:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786575065; bh=q94daslctU9u8EUSFugtHPk2cVBdSnc1E2aM20T8veU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GbmnXaWeCQaaqrT8Hp/zNHy8kss73W/neIJN1E9VGPX08O8vxf+frHXmvQsJO11Pj KEDci1oe6firfMN35BT3WQzabTnykjeteGsUCxySrWPYwgqKNjdYQwukD9pSBLnLhw eWM7OMMdS/widY/WecnKrnZ8Ermx8XAFjf6F2TXOy5e0T+cJSvb9WXeZl+lxyTVZtr FWqZWVM6xnchqFpC0bZpcGPKSGAKM9kzKPWLAt8D1+jfiwdepwXXLReZ0pwGOYuP1p DxV9WyH04g/bVqIj4TQE49i+1L1XYiihUebgNV0Ge7ocKfF2qzyWEdYE0KjQOh6n29 pFU+uCfjZ4uAw== Date: Wed, 12 Aug 2026 17:51:05 -0500 From: Rob Herring To: Marek Vasut Cc: Krzysztof Kozlowski , linux-usb@vger.kernel.org, Pankaj Dev , Fabrice Gasnier , Rahul Kumar , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY Message-ID: <20260812225105.GB693080-robh@kernel.org> References: <20260812010157.1772849-1-marex@nabladev.com> <20260812010157.1772849-2-marex@nabladev.com> <20260812-silky-omniscient-dalmatian-b268cb@quoll> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2026 at 08:30:33PM +0200, Marek Vasut wrote: > On 8/12/26 1:22 PM, Krzysztof Kozlowski wrote: > > On 12/08/2026 12:56, Marek Vasut wrote: > > > On 8/12/26 12:15 PM, Krzysztof Kozlowski wrote: > > > > On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote: > > > > > From: Pankaj Dev > > > > > > > > > > Document USB2 PHY for STM32MP25 USB2 controllers, which includes the > > > > > USB2.0 host-only controller and USB 2.0 part of the DWC3 controller. > > > > > Two such PHYs in total are present in STM32MP25 SoC, they both are > > > > > slightly different, therefore they use different compatible string > > > > > > > > What is slightly different? This should be either here, or better, in > > > > "description" part. > > > > > > They are both Synopsys FEMTO-PHY , but they are each attached to a > > > different controller (one to USB 2.0 host , the other to DWC3 DRD) , and > > > their control bits in the system controller register are different for > > > each variant. > > > > > > I extended the description in V2. > > > > Depending on the actual difference, this rather belongs to the phandle > > to syscon, instead of separate compatible. > > Modeling that in the phandle to syscon won't scale, the PHY driver is simple > thus far and does not control all the bits in that syscon, if we were to > somehow extend the phandle to syscon to describe the various bit mappings > and differences in it, it would look awful quickly. Hence the separate > compatible strings, so the driver can match on them, derive match data from > them and use the match data to figure out differences of each instance. There's no 'reg' so the syscon is the only control interface, right? So this should be child node of the syscon (with a reg property). Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy