Re: [PATCH V2] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add QMP UFS PHY compatible for Maili

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete Binding Schema: The newly added compatible string `qcom,maili-qmp-ufs-phy` and its fallback `qcom,hawi-qmp-ufs-phy` are omitted from the `allOf` conditional blocks, and the fallback string is not defined as a standalone compatible.
--

--- Patch [1]: [PATCH V2] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add QMP UFS PHY compatible for Maili ---
commit 85736fd391afb5ebf38138e2d5c3a36609d6c2c8
Author: Nitin Rawat <nitin.rawat@oss.qualcomm.com>

dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add QMP UFS PHY compatible for Maili

This commit documents the QMP UFS PHY compatible string for Qualcomm Maili,
using qcom,hawi-qmp-ufs-phy as a fallback.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index b2c5c9a375a35..f74434f51653c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -16,6 +16,10 @@ description:
>  properties:
>    compatible:
>      oneOf:
> +      - items:
> +          - enum:
> +              - qcom,maili-qmp-ufs-phy
> +          - const: qcom,hawi-qmp-ufs-phy

[Severity: Medium]
Does the addition of this compatible string require updates to the allOf
conditional blocks further down in this file?

It appears the new qcom,maili-qmp-ufs-phy and fallback qcom,hawi-qmp-ufs-phy
strings are missing from the allOf conditional blocks that enforce hardware
constraints like clocks:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,milos-qmp-ufs-phy
              - qcom,msm8998-qmp-ufs-phy

Without these updates, device trees with invalid configurations might silently
pass validation.

Also, could this cause a schema validation regression if qcom,hawi-qmp-ufs-phy
is missing as a standalone compatible definition under
properties.compatible.oneOf?

      - enum:
          - qcom,milos-qmp-ufs-phy
          - qcom,msm8996-qmp-ufs-phy

If a device tree uses only the Hawi compatible string, it seems it will fail
validation entirely because it is undefined as a standalone item.

>        - items:
>            - enum:
>                - qcom,qcs8300-qmp-ufs-phy

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814070112.1676300-1-nitin.rawat@oss.qualcomm.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy