From: Rob Herring <robh@kernel.org>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, krzk+dt@kernel.org,
conor+dt@kernel.org, johan@kernel.org, rogerq@ti.com,
Julian.FRIEDRICH@frequentis.com, upstream+omap@sigma-star.at
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: ti,phy-usb3: Add aspcie reference clock setting
Date: Mon, 17 Aug 2026 09:05:17 -0500 [thread overview]
Message-ID: <20260817140517.GB18207-robh@kernel.org> (raw)
In-Reply-To: <3c11637c-8e81-44b2-8692-a5c7940ab7c2@sigma-star.at>
On Mon, Aug 17, 2026 at 07:19:51AM +0200, David Oberhollenzer wrote:
> Hi,
>
> On 8/12/26 4:20 AM, Rob Herring wrote:
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + const: ti,phy-pipe3-pcie
> > > + then:
> > > + properties:
> > > + ti,syscon-acspcie-tx-rx: true
> >
> > This has no effect. Invert the if and move the else here.
> >
>
> Before I send another version of this patch set, are you really
> sure about this?
Yes. The only purpose it serves is you have to have a 'then' to have an
'else' clause. (BTW, json-schema actually allows omitting 'then' and
having just if/else, but the dtschema meta-schema does not.)
>
> Not only did I copy that entire block from the one directly above,
It's wrong too.
> (the one that is supposed to only allow syscon-pllreset compatible
> is set to ti,phy-pipe3-sata), I actually tested this by running
> make dt_binding_check.
>
> If I intentionally break the example by setting a wrong compatible
> string, I get a "False schema does not allow" type message, same
> as when I use the syscon-pllreset property with the wrong compat
> string.
>
> Is the existing check broken too? Is there something different
> supposed to happen?
I did not say it was broken. It is functional. It is just not minimized.
Rob
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-08-17 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 9:11 [PATCH v2 0/2] phy: ti: ti-pipe3: allow configuring ACSPCIe TX/RX mode David Oberhollenzer
2026-08-06 9:11 ` [PATCH v2 1/2] dt-bindings: phy: ti,phy-usb3: Add aspcie reference clock setting David Oberhollenzer
2026-08-12 2:20 ` Rob Herring
2026-08-17 5:19 ` David Oberhollenzer
2026-08-17 14:05 ` Rob Herring [this message]
2026-08-06 9:11 ` [PATCH v2 2/2] phy: ti: ti-pipe3: allow configuring ACSPCIe TX/RX mode David Oberhollenzer
2026-08-06 9:24 ` sashiko-bot
2026-08-10 7:48 ` David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817140517.GB18207-robh@kernel.org \
--to=robh@kernel.org \
--cc=Julian.FRIEDRICH@frequentis.com \
--cc=conor+dt@kernel.org \
--cc=david.oberhollenzer@sigma-star.at \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=rogerq@ti.com \
--cc=upstream+omap@sigma-star.at \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox