Re: [PATCH v2 6/7] dt-bindings: usb: ti,am33xx-usb: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML example contains unresolved phandle references (`&ctrl_mod` and `&usb0_phy`), which will cause `dt_binding_check` compilation to fail.
--

--- Patch [6]: [PATCH v2 6/7] dt-bindings: usb: ti,am33xx-usb: Convert to DT schema ---
commit e44cab46abc4f9978c722895c49e454a5ad807d6
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,am33xx-usb: Convert to DT schema

This commit converts the TI AM33xx USB Wrapper text binding to DT schema.
It drops the USB control module from child nodes, allows standard phy node
names alongside legacy ones, and deprecates the ti,hwmods property.

> diff --git a/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml
> new file mode 100644
> index 0000000000000..0b36b9ddfb4a9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml
[ ... ]
> +examples:
> +  - |
> +    usb@47400000 {
> +        compatible = "ti,am33xx-usb";
> +        reg = <0x47400000 0x1000>;
> +        ranges;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ti,hwmods = "usb_otg_hs";
> +
> +        usb-phy@47401300 {
> +            compatible = "ti,am335x-usb-phy";
> +            reg = <0x47401300 0x100>;
> +            reg-names = "phy";
> +            ti,ctrl_mod = <&ctrl_mod>;

[Severity: Low]
Will this cause a compilation failure during make dt_binding_check?

The example references the &ctrl_mod phandle here, but since the control
module node was removed from the child nodes during the conversion, this
reference appears to be undefined.

> +            #phy-cells = <0>;
> +        };
> +
> +        usb@47401000 {
> +            compatible = "ti,musb-am33xx";
> +            reg = <0x47401400 0x400>,
> +                  <0x47401000 0x200>;
> +            reg-names = "mc", "control";
> +            interrupts = <18>;
> +            interrupt-names = "mc";
> +            dr_mode = "otg";
> +            mentor,multipoint = <1>;
> +            mentor,num-eps = <16>;
> +            mentor,ram-bits = <12>;
> +            mentor,power = <500>;
> +            phys = <&usb0_phy>;

[Severity: Low]
Does this also leave an undefined reference in the example?

The phys property references &usb0_phy, but the usb0_phy label was dropped
from the usb-phy@47401300 node in this example schema.

> +        };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-ti-am33-usb-v2-0-66fd44d66824@gmail.com?part=6

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy