Re: [PATCH v2 2/2] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing `select MFD_SYSCON` or `depends on MFD_SYSCON` for PHY_SPACEMIT_K1_PCIE
- [Medium] Incomplete fix: PHY_SPACEMIT_K3_COMBO_PHY is missing `default ARCH_SPACEMIT`
- [Medium] PHY_SPACEMIT_K3_COMBO_PHY is missing `depends on HAS_IOMEM`
--

--- Patch [2]: [PATCH v2 2/2] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT ---
commit 24c737090e69ed7db66ac129f68b1a45eb92ca1e
Author: Bruno Banelli <bbanelli@gmail.com>

phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT

This commit adds a default ARCH_SPACEMIT to the PHY_SPACEMIT_K1_USB2 Kconfig
entry. This resolves an issue where the USB 2.0 PHY driver was disabled by
default on SpacemiT K1 boards, preventing USB from working.

> diff --git a/drivers/phy/spacemit/Kconfig b/drivers/phy/spacemit/Kconfig
> index cd7ae48d8ea2f..b5f36621b2075 100644
> --- a/drivers/phy/spacemit/Kconfig
> +++ b/drivers/phy/spacemit/Kconfig
> @@ -22,6 +22,7 @@ config PHY_SPACEMIT_K1_USB2
>  	depends on USB_COMMON
>  	select GENERIC_PHY
>  	select REGMAP_MMIO
> +	default ARCH_SPACEMIT

[Severity: High]
This is a pre-existing issue, but I noticed PHY_SPACEMIT_K1_PCIE is missing
a dependency on MFD_SYSCON:

drivers/phy/spacemit/Kconfig:PHY_SPACEMIT_K1_PCIE {
    config PHY_SPACEMIT_K1_PCIE
        tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC"
        depends on ARCH_SPACEMIT || COMPILE_TEST
        ...
}

If MFD_SYSCON is not enabled, the kernel will still build successfully,
but at runtime the driver probe will silently fail returning -ENOTSUPP:

drivers/phy/spacemit/phy-k1-pcie.c:k1_pcie_combo_phy_probe() {
    ...
    regmap = syscon_regmap_lookup_by_phandle(dev_of_node(dev), SYSCON_APMU);
    ...
}

Does this config need to select or depend on MFD_SYSCON to prevent this?


[Severity: Medium]
This is a pre-existing issue, but PHY_SPACEMIT_K3_COMBO_PHY seems to be
missing the same default configuration being added here:

drivers/phy/spacemit/Kconfig:PHY_SPACEMIT_K3_COMBO_PHY {
    config PHY_SPACEMIT_K3_COMBO_PHY
        tristate "SpacemiT K3 USB3/PCIe PHY support"
        depends on (ARCH_SPACEMIT || COMPILE_TEST) && OF
        ...
}

Since the K3 combo PHY driver manages USB3/PCIe on SpacemiT SoCs, could
this missing default lead to similar broken USB behavior on K3 boards?
Would it make sense to add default ARCH_SPACEMIT there as well?


[Severity: Medium]
This is a pre-existing issue, but PHY_SPACEMIT_K3_COMBO_PHY also appears
to be missing a dependency on HAS_IOMEM:

drivers/phy/spacemit/Kconfig:PHY_SPACEMIT_K3_COMBO_PHY {
    config PHY_SPACEMIT_K3_COMBO_PHY
        tristate "SpacemiT K3 USB3/PCIe PHY support"
        depends on (ARCH_SPACEMIT || COMPILE_TEST) && OF
        depends on COMMON_CLK
        select PHY_SPACEMIT_K3_COMMON_OPS
}

The PHY_SPACEMIT_K3_COMBO_PHY driver uses devm_platform_ioremap_resource(),
which operates on MMIO memory. Could omitting the HAS_IOMEM dependency
lead to build or probe failures under COMPILE_TEST?

>  	help
>  	  Enable this to support K1 USB 2.0 PHY driver. This driver takes care of
>  	  enabling and clock setup and will be used by K1 udc/ehci/otg/xhci driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825065007.69353-1-bbanelli@gmail.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy