Re: [PATCH v3 1/3] dt-bindings: phy: airoha: Document support for AN7583 USB PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Malformed character range in patternProperties regex allows invalid unit addresses.
- [Low] Typo in the binding title and grammatical errors in the description.
--

commit 4a5fe874f5d1686d215561949399a35ae4b5a15b
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: phy: airoha: Document support for AN7583 USB PHY
    
Adds documentation for the Airoha AN7583 USB PHY for the USB controller.
The binding details support for up to two USB 2.0 ports, optional USB 3.0
modes via Serdes configuration, and monitor clock calibration.

> diff --git a/Documentation/devicetree/bindings/phy/airoha,an7583-usb-phy.yaml b/Documentation/devicetree/bindings/phy/airoha,an7583-usb-phy.yaml
> new file mode 100644
> index 0000000000000..7ec655253a8ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/airoha,an7583-usb-phy.yaml
> @@ -0,0 +1,133 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/airoha,an7583-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha AN7581 SoC USB PHY

[Severity: Low]
This isn't a bug, but is the title targeting the correct SoC variant? The
compatible string and filename target AN7583, but the title mistakenly
says AN7581.

> +
> +maintainers:
> +  - Christian Marangi <ansuelsmth@gmail.com>
> +
> +description: >
> +  The Airoha AN7583 SoC USB PHY describes the USB PHY for the USB controller..

[Severity: Low]
This isn't a bug, but there is a typo here with the double period at the
end of the sentence.

[ ... ]
> +patternProperties:
> +  '^usb2-phy@[0-9-a-f]+$':

[Severity: Medium]
Does this regex correctly restrict unit addresses?

The regex [0-9-a-f] contains a hyphen after a completed range (0-9), causing
the hyphen to be treated as a literal character rather than part of a valid
hex range. This incorrectly validates malformed device tree node names
containing hyphens in the unit address (e.g., usb2-phy@0-a).

Should this pattern be updated to [0-9a-f]+ to enforce proper hex unit
addresses?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827131551.26725-1-ansuelsmth@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy