From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AA39C61DD6 for ; Wed, 2 Sep 2026 15:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FegL7eRkjL2IWkocJXeU+y5PPhHFmg6qYh0VT7o/ofI=; b=nVJCcP7H9Cieja KuFDk6gxqjYYtScmzC3rWa5a8ABlfl2w2BhWmMf+zjTdsh+BLJSgrsBZ6QRtd+5cjAwedpM4cbg1o UWd8zq/SUQNq0jsec3wgin9HeOpBO84BzjMjdmjhKVwExvRUioZztWXGd+HyMjIlAVkzPNb3Tt4YD DAU4y6oL1WwR8RMY1mvwkHZDyypeHHQfnn1Q0nD8uBSD62Ov/OGBnNnisbgZN1Bm+e5UkN4YaMuLI kbuXH1PBzqu1gTdY6Ij6jDB68XXFgeVqMTmFEAVuZLrY+g6l6EtWsiD0yNFwrc7Jq3sMkH/THTrtI VEPZMGBXF1G/imSxR95A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1mW5-0000000F2kJ-0nbU; Wed, 02 Sep 2026 15:04:45 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1mW2-0000000F2jO-3vgZ for linux-phy@lists.infradead.org; Wed, 02 Sep 2026 15:04:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 3B45D600D0; Wed, 2 Sep 2026 15:04:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71FE21F00A3E; Wed, 2 Sep 2026 15:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788361481; bh=EjHGe2+c+iiJIyioUKvKNEOLJIJmWsEN6lX8BJvp+4I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=J13Dph+HXa5wrUilH/3Qy/UufluuyIOU9F2srH+U8YJtllTgGQTLugCKWzt1qWrB1 cQw9r1/o7FOCtQKiXlbQU6vn//oKuO/0BJnHdLdNT+6s7xAUpo/Lnn0Mc3tIZxmmi0 mR/tI/x7RqBEqNqh8skoGYXTYn3dS+SjtY+H6Un5EZfQegWhDvWkt0/aBF+a0wDxX7 RzkYfVpJWJl9+1OZkX+F8pCSiKInf1T3WbsfjatRpiAPZoT9qsfeM8vcLkzkhM9Dpv MleFvYc51uxGSLckgnH1EDc42uAWeEvKdvrdVy1PHgdAvZLtBEoVRZU5Gf6mmsuXhj 0NAN1qbSpoNPg== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v3 08/10] net: stmmac: dwmac-rk: add SGMII support for RK3568 To: "Coia Prant" Cc: vkoul@kernel.org, wsa+renesas@sang-engineering.com, robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, conor+dt@kernel.org, linux-phy@lists.infradead.org In-Reply-To: <20260901150111.141037-9-coiaprant@gmail.com> References: <20260901150111.141037-1-coiaprant@gmail.com> <20260901150111.141037-9-coiaprant@gmail.com> Date: Wed, 02 Sep 2026 15:04:41 +0000 Message-Id: <20260902150441.71FE21F00A3E@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtIaWdoXSBI YXJkd2FyZSBpbml0aWFsaXphdGlvbiBmYWlsdXJlOiBUaGUgaW50ZXJmYWNlIHNlbGVjdGlvbiBi aXRzIDQ6NiBhcmUgbm90IGNsZWFyZWQgZm9yIFNHTUlJIG1vZGUsIGNvbnRyYWRpY3RpbmcgdGhl IGNvbW1pdCBtZXNzYWdlIGFuZCBsZWF2aW5nIHRoZSBNQUMgaW4gYW4gaW52YWxpZCBzdGF0ZS4K ClByZS1leGlzdGluZyBpc3N1ZXM6Ci0gW0hpZ2hdIFVuaGFuZGxlZCBFcnJvcjogcG1fcnVudGlt ZV9nZXRfc3luYygpIHJldHVybiB2YWx1ZSBpcyBpZ25vcmVkLCBwb3RlbnRpYWxseSBjYXVzaW5n IGhhcmR3YXJlIGFjY2VzcyB3aXRob3V0IHByb3BlciByZXN1bWUuCi0tCgpjb21taXQgNWE3YzNi MzhiYTk1N2U3NGIyNjYyM2M4ZTNlOTRlNGM3N2I1OTRkZQpBdXRob3I6IENvaWEgUHJhbnQgPGNv aWFwcmFudEBnbWFpbC5jb20+CgpuZXQ6IHN0bW1hYzogZHdtYWMtcms6IGFkZCBTR01JSSBzdXBw b3J0IGZvciBSSzM1NjgKClRoaXMgY29tbWl0IGFkZHMgc3VwcG9ydCBmb3IgU0dNSUkgbW9kZSBv biB0aGUgUkszNTY4IFNvQyBieSBwcm92aWRpbmcgdGhlCm5lY2Vzc2FyeSBnbHVlIGxvZ2ljIGFu ZCBYUENTIGNvbmZpZ3VyYXRpb24uIEl0IGludHJvZHVjZXMgY2FsbGJhY2tzIHRvIHNldAp1cCB0 aGUgR01BQyBHUkYgcmVnaXN0ZXIgYW5kIGhhbmRsZSBQQ1MgaW5pdGlhbGl6YXRpb24sIHdoaWxl IGFsc28gZml4aW5nCmNsb2NrIGVuYWJsZSBvcmRlcmluZyBpbiB0aGUgcG93ZXJ1cCBzZXF1ZW5j ZS4KCkxpbms6IGh0dHBzOi8vZGwucmFkeGEuY29tL3JvY2szL2RvY3MvaHcvZGF0YXNoZWV0L1Jv Y2tjaGlwJTIwUkszNTY4JTIwVFJNJTIwUGFydDElMjBWMS4xLTIwMjEwMzAxLnBkZiAoUGFnZSAz ODYpCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9k d21hYy1yay5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvZHdtYWMtcmsu Ywo+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLXJrLmMK PiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9kd21hYy1yay5jClsg Li4uIF0KPiBAQCAtODUxLDE4ICs4NTcsMzIgQEAgc3RhdGljIHZvaWQgcmszNTY4X3NldF90b19y Z21paShzdHJ1Y3QgcmtfcHJpdl9kYXRhICpic3BfcHJpdiwKPiAgCQkgICAgIFJLMzU2OF9HTUFD X0NMS19UWF9ETF9DRkcodHhfZGVsYXkpKTsKPiAgCj4gIAlyZWdtYXBfd3JpdGUoYnNwX3ByaXYt PmdyZiwgY29uMSwKPiArCQkgICAgIFJLMzU2OF9HTUFDX01PREVfUk1JSV9SR01JSSB8Cj4gIAkJ ICAgICBSSzM1NjhfR01BQ19SWENMS19ETFlfRU5BQkxFIHwKPiAgCQkgICAgIFJLMzU2OF9HTUFD X1RYQ0xLX0RMWV9FTkFCTEUpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCByazM1Njhfc2V0X3Rv X3NnbWlpKHN0cnVjdCBya19wcml2X2RhdGEgKmJzcF9wcml2KQo+ICt7Cj4gKwl1MzIgY29uMTsK PiArCj4gKwljb24xID0gKGJzcF9wcml2LT5pZCA9PSAxKSA/IFJLMzU2OF9HUkZfR01BQzFfQ09O MSA6Cj4gKwkJCQkgICAgIFJLMzU2OF9HUkZfR01BQzBfQ09OMTsKPiArCj4gKwlyZWdtYXBfd3Jp dGUoYnNwX3ByaXYtPmdyZiwgY29uMSwgUkszNTY4X0dNQUNfTU9ERV9TR01JSV9RU0dNSUkpOwo+ ICt9CgpbU2V2ZXJpdHk6IEhpZ2hdClRoZSBjb21taXQgbWVzc2FnZSBtZW50aW9ucyAiYml0IDcg c2V0LCBpbnRlcmZhY2Ugc2VsZWN0aW9uIGJpdHMgNDo2IGNsZWFyZWQiLApidXQgdGhpcyB3cml0 ZSBvbmx5IHRhcmdldHMgYml0IDcgdXNpbmcgUkszNTY4X0dNQUNfTU9ERV9TR01JSV9RU0dNSUkg KHdoaWNoCmlzIEdSRl9CSVQoNykpLiBEb2VzIHRoaXMgbGVhdmUgdGhlIGludGVyZmFjZSBzZWxl Y3Rpb24gYml0cyA0OjYgaW4gdGhlaXIKcHJldmlvdXMgc3RhdGUgaW5zdGVhZCBvZiBjbGVhcmlu ZyB0aGVtPyBDb3VsZCB0aGlzIGNhdXNlIHRoZSBTR01JSSBpbnRlcmZhY2UKdG8gZmFpbCB0byBp bml0aWFsaXplIHByb3Blcmx5PwoKWyAuLi4gXQo+IEBAIC0xMzc5LDE2ICsxNDQxLDE5IEBAIHN0 YXRpYyBpbnQgcmtfZ21hY19wb3dlcnVwKHN0cnVjdCBya19wcml2X2RhdGEgKmJzcF9wcml2KQo+ ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiArCXJldCA9IGdtYWNfY2xrX2VuYWJs ZShic3BfcHJpdiwgdHJ1ZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJ aWYgKGJzcF9wcml2LT5waHlfaWZhY2UgPT0gUEhZX0lOVEVSRkFDRV9NT0RFX1NHTUlJKQo+ICsJ CWdvdG8gc2V0X21vZGU7CgpbU2V2ZXJpdHk6IEhpZ2hdCkJlY2F1c2UgUEhZX0lOVEVSRkFDRV9N T0RFX1NHTUlJIHRha2VzIHRoaXMgZ290byBzZXRfbW9kZSwgaXQgc2tpcHMgdGhlCmdlbmVyaWMg R1JGIGludGVyZmFjZSBzZWxlY3Rpb24gbWFzayBjb25maWd1cmF0aW9uIHJpZ2h0IGJlbG93IGl0 LiBTaW5jZQpyazM1Njhfc2V0X3RvX3NnbWlpKCkgYWxzbyBkb2Vzbid0IGNsZWFyIGJpdHMgNDo2 LCBpcyB0aGVyZSBhbnl3aGVyZSB0aGF0IHRoZQpjbGVhcmluZyBtYXNrIGlzIGFjdHVhbGx5IGFw cGxpZWQgZm9yIFNHTUlJPwoKPiArCj4gIAlyZXQgPSBya19nZXRfcGh5X2ludGZfc2VsKGJzcF9w cml2LT5waHlfaWZhY2UpOwo+ICAJaWYgKHJldCA8IDApCj4gLQkJcmV0dXJuIHJldDsKPiArCQln b3RvIGNsa19kaXNhYmxlOwo+ICAKPiAgCWludGYgPSByZXQ7Cj4gIApbIC4uLiBdCj4gQEAgLTE0 NDcsMTUgKzE1MDksMjAgQEAgc3RhdGljIGludCBya19nbWFjX3Bvd2VydXAoc3RydWN0IHJrX3By aXZfZGF0YSAqYnNwX3ByaXYpCj4gIAkJaWYgKGJzcF9wcml2LT5vcHMtPnNldF90b19ybWlpKQo+ ICAJCQlic3BfcHJpdi0+b3BzLT5zZXRfdG9fcm1paShic3BfcHJpdik7Cj4gIAkJYnJlYWs7Cj4g KwljYXNlIFBIWV9JTlRFUkZBQ0VfTU9ERV9TR01JSToKPiArCQlkZXZfaW5mbyhkZXYsICJpbml0 IGZvciBTR01JSVxuIik7Cj4gKwkJaWYgKGJzcF9wcml2LT5vcHMtPnNldF90b19zZ21paSkKPiAr CQkJYnNwX3ByaXYtPm9wcy0+c2V0X3RvX3NnbWlpKGJzcF9wcml2KTsKPiArCQlicmVhazsKPiAg CWRlZmF1bHQ6Cj4gIAkJZGV2X2VycihkZXYsICJOTyBpbnRlcmZhY2UgZGVmaW5lZCFcbiIpOwo+ ICsJCXJldCA9IC1FSU5WQUw7Cj4gKwkJZ290byBjbGtfZGlzYWJsZTsKPiAgCX0KPiAgCj4gIAly ZXQgPSBya19waHlfcG93ZXJ1cChic3BfcHJpdik7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJZ21hY19j bGtfZW5hYmxlKGJzcF9wcml2LCBmYWxzZSk7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiArCWlm IChyZXQpCj4gKwkJZ290byBjbGtfZGlzYWJsZTsKPiAgCj4gIAlwbV9ydW50aW1lX2dldF9zeW5j KGRldik7Cj4gIAo+IEBAIC0xNDYzLDYgKzE1MzAsMTAgQEAgc3RhdGljIGludCBya19nbWFjX3Bv d2VydXAoc3RydWN0IHJrX3ByaXZfZGF0YSAqYnNwX3ByaXYpCj4gIAkJYnNwX3ByaXYtPm9wcy0+ aW50ZWdyYXRlZF9waHlfcG93ZXJ1cChic3BfcHJpdik7Cj4gIAo+ICAJcmV0dXJuIDA7CgpbU2V2 ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCB0aGUgcmV0dXJu IHZhbHVlIG9mIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKQppcyBpZ25vcmVkIGhlcmUuIElmIHRoZSBk ZXZpY2UgcG93ZXIgZG9tYWluIGZhaWxzIHRvIHJlc3VtZSwgd291bGQgdGhlCnN1YnNlcXVlbnQg aW50ZWdyYXRlZF9waHlfcG93ZXJ1cCgpIGhhcmR3YXJlIGFjY2VzcyB0cmlnZ2VyIGEgc3luY2hy b25vdXMKZXh0ZXJuYWwgYWJvcnQgb3IgY2F1c2Ugc2lsZW50IGRhdGEgY29ycnVwdGlvbj8KCj4g Kwo+ICtjbGtfZGlzYWJsZToKPiArCWdtYWNfY2xrX2VuYWJsZShic3BfcHJpdiwgZmFsc2UpOwo+ ICsJcmV0dXJuIHJldDsKPiAgfQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2Fz aGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDkwMTE1MDExMS4xNDEwMzctMS1jb2lhcHJhbnRAZ21h aWwuY29tP3BhcnQ9OAoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcGh5Cg==