From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BFF8C79F82 for ; Tue, 8 Sep 2026 13:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vYe0hX4jd8i4uV5tEMdfFtm5XkpXyFJhD/AFok+OFQY=; b=XCjguMKQaFnA2G gogxBMWe32zJ2xgkBEC2pqEfs2IEOXpHFvXPZxbzn0bvqIBEHskx28S/nN59FXbvpNE1hnBu80KuQ DdaLQksbXcPBox1xzp0reBcwzxKNNADGWLqDeVuUOI0ZkWZbfg+cL80KE8b0f5kRHWvFJOe1ak9d+ GnWWbD+ZxXv9Dw1N/9U+bILggP4JZWaomQug0CAvEAO1TcWmsTKYlc25o2x3X+QmWLKBTbcUcJ799 uRILQQwX6z0S3y27YTV6hM7i3B9JdBzUkUp6gWj77AqGxaf/fqPb9XIL1plqKnZ76c906L0ltYPGg 77QRvAmG3SemHk7/4Xrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3vvq-000000099rW-2h7Q; Tue, 08 Sep 2026 13:32:14 +0000 Received: from mail-ej2-x10.google.com ([2a00:1450:4864:34::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3vvn-000000099pg-31S0 for linux-phy@lists.infradead.org; Tue, 08 Sep 2026 13:32:13 +0000 Received: by mail-ej2-x10.google.com with SMTP id a640c23a62f3a-c25331b31e8so61061466b.2 for ; Tue, 08 Sep 2026 06:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788874329; x=1789479129; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c09duG40XUDjljTKKEnm8AMSUZjhNe4OtYQ1ssenbDY=; b=sCLh6dbyJ6gFWlVJA3+RSlw3EGSJtsCr1dkokaYWFZJOR5xbPS2g1/Vft/1MgrcAL5 7hNk0U9Q6kHGR4a2xqf1zMyy2Pii41mE8DCqANtIUG+aG7A3xDomd7YQL+3nulKCCqp2 4uSVGDpK4cBSOdkX8ZOAzzUQv4Si2TRhEquydT7N7pzL74gD8iyObzuwi9782MYOzFHW elfQKLBFcPkCmxA34uMWsUcOoZOF5D6lgqeN6dqN6LtO7pufjDEhSvG2l2GsQSfeRdpz FSrq8S6h5YTVzYpMB3/iQPG84MF/ylANmTGNHkkS1QWrF1iUSv/mRGOKskhtHVY+NAW3 sDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788874329; x=1789479129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=c09duG40XUDjljTKKEnm8AMSUZjhNe4OtYQ1ssenbDY=; b=mgxOQ7BfEpIAWLYsNXxpA1poTtV8Fo9wOPcHc41k74iiPQ24YnZszIV2R6Z1g2vbiR yqPLInlt1pZd+/OrtZIhsnI/Wjmnd+IuextAXJKVUkXLzqxk2NfFFGN8BB5rpdPN1E7P vKLSPTkPIXs1duEEjxrJfiDQK882fCuyGNe/DcJFpeC3BM7tIqeN/fFegtO6XGWUhpb2 xB7nex5q2ktVCmcNgepm/lVD0DL/5UsHZW9z7j8IHSib/W2E4wZUKK2p8Q6QPx6R+XH4 0kL6+3qvS3YnFC69icHPmdFDnMvelPGKC/8ZiGxfEQW17hziCSwcSsuZKf7w+yaPvxrc gALQ== X-Forwarded-Encrypted: i=1; AKwUvBwn3FGf98Vf3wnOEcmE2gTBsGzEnMLlFNrBnmb3lhvpr3VIS/K45Fok6ie0FGVBS+wnnJkOs+cpe4E=@lists.infradead.org X-Gm-Message-State: AFuF++nSqT6bgJVZ6Vi+Ui6N4weqfMWLfcX4+Hxyp2URLh575PVnp/rt kVZ6M4eUVcXTqNn5kQgqXVVIZczy36wYrAqdvnNGkGdw+k9ZbrZltX7/ X-Gm-Gg: AYBFou2iBO0d/dAjXqtOdnq2qdeQOmT0EUBX9vBN25elIpgf/TcdUTbOR3Jg70phhOL 515zqMqIo53c3Lkt3rrRsFpNngsZppkoBHPYiQoFHLoek504uKs9OPDvi4O6xh551kdKaxY8FYO l8KC4IegJHB+SES8vHYD9/bSUql9H4KaWgCEMkZmI4rJcsvCs+nt2XiAIrDF6DlPnsi0ONjXjmo y4H+B9aE/WPoHv9FlnAax2X792yFCPRoTBIm/gQtNWDm2WDQvJfLitvG0jTfWSbaoWdZKhwPIWS sxS4JawzWn7GntmVCkfJNjuIcLRvrAQaCKCaDq6KWdB5djzcZZAWhPHcmO/2RbkFMj9NfuzPH5m aPLPGdJ91NHgJOdzPVlzk7uyZPgHBFWYj/8Fvs4xbCo6pjsa9ISLrpfDy1DhO7IO8DxTpdYlEzd kBgkfQiPyKa+y9KkypKt6e7GMuHiqEHGVJlWrNzu18IH3bfyCDEdM7Oz9LhR6WEdFCOEKv7X/bt a6sMI+mM+d6o0qp87k/djJTgRZHq4L+Foy390IBmGUDyqbuI2lwWRku/XeXGuGt6hiJt09T7GAe qhhZ X-Received: by 2002:a17:907:3f8d:b0:c25:ca8a:8e25 with SMTP id a640c23a62f3a-c2624eef698mr794013366b.1.1788874329043; Tue, 08 Sep 2026 06:32:09 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B825D0079B84A36A788F67A.dsl.pool.telekom.hu. [2001:4c4e:1b82:5d00:79b8:4a36:a788:f67a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485881353e8sm36163217f8f.1.2026.09.08.06.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 06:32:08 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel Cc: Igor Paunovic , Alan Stern , Greg Kroah-Hartman , Vinod Koul , Heiko Stuebner , Neil Armstrong , Manivannan Sadhasivam , linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: s2idle resume hangs in ohci/ehci on RK3588: HC registers touched before the USB2 PHY is powered back on Date: Tue, 8 Sep 2026 15:31:46 +0200 Message-ID: <20260908133147.8291-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: <20260907190000.s2idle-usb2-resume-royalnet026@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_063211_773649_E37E9BF4 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hello Sebastian, Thank you, that is a much better place to fix it than either of the two options I asked about, and it matches what the board shows: the OHCI that hung was the one whose 480 MHz clock had it as the only user, so the clock was gated on suspend and the PHY was left in suspend when the controller came back and touched its registers. I read 53014abc in the rockchip-devel branch. One data point in case it is useful for the version you send: on RK3588 the early return does not get in the way. /* Limit to single port; it's unclear how multi-port should be handled */ if (rphy->phy_cfg->num_ports > 1) return 0; All four entries in rk3588_phy_cfgs[] have num_ports = 1 (0x0000 and 0x4000 as OTG, 0x8000 and 0xc000 as HOST), so the new code does run on RK3588, including u2phy2 at 0x8000, which is the port whose controller (fc840000, host0) hung for me. The num_ports = 2 configs are the older SoCs, so as far as RK3588 is concerned that guard costs nothing. I will build the patch for my test kernel and report back. My setup should be a reasonable test case for it: with all four USB 2.0 hosts bound, s2idle resume hung every time and needed a cold reset, and with the four hosts unbound the same cycle completed 4 out of 4, so there is a clear before/after to measure rather than an intermittent one. The driver is a module in my configs, so this is a single module rebuild. If it holds up I will send a Tested-by. One observation on your second point. On this board s2idle is entered: the machine goes down, the hym8563 RTC alarm wakes it ("PM: Triggering wakeup from IRQ 52"), and only then does the resume stall in the USB2 hosts. So PCIe did not block suspend here, even though the board has NVMe, two r8169 NICs and an rtw89 card on PCIe. I do not know why my case differs from yours; if that is interesting for your PCIe suspend series I can dump whatever state you want from before the suspend. The RTC pin fix I mentioned is now v2 on the list [1], with megi's Reviewed-by. Without it there is no wake source on this board at all, so it is a prerequisite for anyone else trying to reproduce this. If you would rather I wait for the version you post this week instead of testing the branch commit, just say so and I will wait. [1] https://lore.kernel.org/all/20260908111908.19371-1-royalnet026@gmail.com/ Igor -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy