Re: [PATCH net-next v4 05/10] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing 'phy-names' and 'phys' properties in the XPCS node causes dtbs_check failures.
- [Low] The fixed-clock nodes use a deprecated naming convention.
--

commit 44bcecc3ab36daaafbcaa0b05c41e194b9da4c06
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

This commit adds the XPCS device node and its pcs-mii sub-nodes to the RK3568
SoC device tree, along with two fixed-clock nodes for the GMAC reference
clocks. The XPCS node is disabled by default and meant to be enabled at the
board level.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 3bc653f027f1f..989e164c0eb39 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -110,6 +110,51 @@ sata0: sata@fc000000 {
>  		status = "disabled";
>  	};
>  
> +	xpcs: pcs@fda00000 {
> +		compatible = "rockchip,rk3568-xpcs";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x0 0xfda00000 0x0 0x200000>;
> +		clocks = <&cru PCLK_XPCS>, <&cru CLK_XPCS_EEE>;
> +		clock-names = "csr", "eee";
> +		power-domains = <&power RK3568_PD_PIPE>;
> +		status = "disabled";

[Severity: Low]
Will this cause make dtbs_check failures during kernel builds? The dt-schema
tool unconditionally validates all nodes against rockchip-dwxpcs.yaml,
including those with status = "disabled".

Because phys and phy-names are strictly required by the binding, omitting
them here in rk3568.dtsi breaks DT validation for all RK3568 boards that
include this file without explicitly providing these properties.

[ ... ]

> +	xpcs_gmac0_clk: xpcs-gmac0-clock {
> +		compatible = "fixed-clock";

[Severity: Low]
Could this node name trigger deprecation warnings during make dtbs_check?

The fixed-clock.yaml schema restricts valid node names to the pattern
^clock-([0-9]+|[a-z0-9-]+)$. Names outside this pattern, like
xpcs-gmac0-clock, fall under a legacy definition tagged as deprecated.

> +		clock-frequency = <125000000>;
> +		clock-output-names = "clk_gmac0_xpcs_mii";
> +		#clock-cells = <0>;
> +	};
> +
> +	xpcs_gmac1_clk: xpcs-gmac1-clock {
> +		compatible = "fixed-clock";

[Severity: Low]
Does this node name also trigger a deprecation warning for the same reason?

> +		clock-frequency = <125000000>;
> +		clock-output-names = "clk_gmac1_xpcs_mii";
> +		#clock-cells = <0>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907153713.2572547-2-coiaprant@gmail.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy