From: Vinod Koul <vkoul@kernel.org>
To: linux-phy@lists.infradead.org
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Oltean <olteanv@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Vinod Koul <vkoul@kernel.org>
Subject: [PATCH] phy: phy-mtk-dp: drop unused variables
Date: Sun, 13 Sep 2026 16:24:45 +0530 [thread overview]
Message-ID: <20260913105445.211613-1-vkoul@kernel.org> (raw)
Recent changes in driver added unused variables causing build warnings:
drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_set_digital_drv_params’:
drivers/phy/mediatek/phy-mtk-dp.c:332:16: error: unused variable ‘ret’ [-Werror=unused-variable]
332 | int i, ret;
| ^~~
drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_init’:
drivers/phy/mediatek/phy-mtk-dp.c:348:24: error: unused variable ‘dev’ [-Werror=unused-variable]
348 | struct device *dev = &phy->dev;
| ^~~
drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_disable_all_lanes’:
drivers/phy/mediatek/phy-mtk-dp.c:457:13: error: unused variable ‘ret’ [-Werror=unused-variable]
457 | int ret;
| ^~~
Drop these to fix these
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/mediatek/phy-mtk-dp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy-mtk-dp.c
index 6d06e1c39e3b..7108b16d33a2 100644
--- a/drivers/phy/mediatek/phy-mtk-dp.c
+++ b/drivers/phy/mediatek/phy-mtk-dp.c
@@ -329,7 +329,7 @@ static void mtk_dp_phy_set_digital_drv_params(struct mtk_dp_phy *dp_phy)
{
const struct mtk_dp_phy_pdata *pdata = dp_phy->pdata;
const u32 reg = pdata->regs_dig_lane[DP_PHYD_LAN_DRIVING_PARAM_0];
- int i, ret;
+ int i;
/*
* Assume that all lanes need the same driving parameters: this
@@ -345,7 +345,6 @@ static void mtk_dp_phy_set_digital_drv_params(struct mtk_dp_phy *dp_phy)
static int mtk_dp_phy_init(struct phy *phy)
{
struct mtk_dp_phy *dp_phy = phy_get_drvdata(phy);
- struct device *dev = &phy->dev;
mtk_dp_phy_set_digital_drv_params(dp_phy);
mtk_dp_phy_set_analog_calibration_params(dp_phy);
@@ -454,7 +453,6 @@ static int mtk_dp_phy_disable_all_lanes(struct mtk_dp_phy *dp_phy)
{
const struct mtk_dp_phy_pdata *pdata = dp_phy->pdata;
const u8 *regs = pdata->regs_dig_glb;
- int ret;
u32 val;
/* Get mask of currently enabled lane */
--
2.53.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
reply other threads:[~2026-09-13 10:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913105445.211613-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).