From: sashiko-bot@kernel.org
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: conor+dt@kernel.org, linux-clk@vger.kernel.org,
media-ci@linuxtv.org, vkoul@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
linux-phy@lists.infradead.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH v19 4/5] media: qcom: camss: Add support for PHY API devices
Date: Thu, 17 Sep 2026 15:37:55 +0000 [thread overview]
Message-ID: <20260917153756.258D21F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v19-4-21ad8a76e941@linaro.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] kconfig: selection of non-existent symbol PHY_QCOM_MIPI_CSI2
--
commit 585e1d52eb0f705ed19df22dc9f45b8bef14c8a9
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
media: qcom: camss: Add support for PHY API devices
This commit adds the ability to use a PHY pointer which interacts with the
standard PHY API. In the first instance the code will try to use the new
PHY interface, falling back to a legacy method if no PHYs are present in
the device tree.
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index 4eda48cb1adf0..1edc5e5a1829e 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -7,3 +7,4 @@ config VIDEO_QCOM_CAMSS
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> + select PHY_QCOM_MIPI_CSI2
[Severity: Medium]
Does this statement select a Kconfig symbol that does not exist in the kernel
tree?
When a user configures the kernel with VIDEO_QCOM_CAMSS, this select
statement targets PHY_QCOM_MIPI_CSI2, which appears to be missing. This
leaves the required PHY driver disabled by default, causing the camera
subsystem to fail at runtime because the PHY device will not be present.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v19-0-21ad8a76e941@linaro.org?part=4
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-09-17 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 15:25 [PATCH v19 0/5] Add phy_get_by_of_node and devm helper Bryan O'Donoghue
2026-09-17 15:25 ` [PATCH v19 1/5] phy: core: Fix race-condition between _of_phy_get() and try_module_get() Bryan O'Donoghue
2026-09-17 15:25 ` [PATCH v19 2/5] phy: core: Add phy_get_by_of_node() Bryan O'Donoghue
2026-09-17 15:36 ` sashiko-bot
2026-09-17 15:25 ` [PATCH v19 3/5] phy: core: Add devm_phy_get_by_of_node() Bryan O'Donoghue
2026-09-17 15:25 ` [PATCH v19 4/5] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-09-17 15:37 ` sashiko-bot [this message]
2026-09-17 15:25 ` [PATCH v19 5/5] media: qcom: camss: Use data-lanes starting at 1 for new CSIPHY mode Bryan O'Donoghue
2026-09-17 18:12 ` [PATCH v19 0/5] Add phy_get_by_of_node and devm helper Oleg Keri
2026-09-18 1:36 ` Manivannan Sadhasivam
2026-09-18 8:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917153756.258D21F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=media-ci@linuxtv.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox