From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B0A0C88E75 for ; Fri, 18 Sep 2026 06:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8gxKLv53xEiM7HdtCc69Vf7UeXsqPVw5kdBrrda4Tt8=; b=4YDYvq0dH9yX8T FBHtVCAobYcBRwn6XT/rb2qbkjoxBS0XcIIYnPilzBpsIIs26ihtJxuRfBY613IgOEMfIQXWHCGKb 9HI5SOVa6dr7h5mBRD1GUEcibKK7jbp3iRfhfyDilcJXdZ4A7NZg0CrpHZs10LMRlcF1PZ9GRbqHX dWwIViRoRm7elhpiLseBSPwk1dPA22AAw/QRO1pg1IePl5l//2K3Q7Fa9TPSdFdrJBRfhsloOOa38 vEg+q7L4ewO6TXM26nNNIoAcUsrt9jY73BtMrT8GYf1AjXE16qCRwJ6OCg9brCFExijmPCbkoyYz4 2YCoYVDpgTUf7wOwN05w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7RuC-0000000DY6s-0NnB; Fri, 18 Sep 2026 06:17:04 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7RuA-0000000DY6E-39uG; Fri, 18 Sep 2026 06:17:02 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 497FC40743; Fri, 18 Sep 2026 06:17:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3305D1F000FF; Fri, 18 Sep 2026 06:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789712222; bh=B/13cZeUrOLEzs/U0VXbyufzLI/X+a7vJxST3/Q9H/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hC+VO2FtDKbfS2UHZn7KsHJfhAMbfycfRebcPAyoit5um1I4sEqs1B3s/d7QsmYOx /uPdeYvBgduMlrxD/q5Qx/yZmnVjrncmd9Y9Pju17LeWasqH1HIMdlKoWQt5U+07Hz itUI4J2CpMvUEEBQ/TG3dnLcJuv6Ss41jE5ltAkW2SHN1CaJfJtBo8gwaiEDocZ2u/ 4YSO3SLQuAartQeYdD1llGHXlMPFhoAhE1udDqkdlpPAbhR3AS4sCi+2T9sNWXk37m 4u2pFM2ozWD9atAEq6/Rf2uBnfPTpaGO4ftBf4KHUAopzadDfZD5zCYKSdh+cDicgJ SHLy28DKe56aw== Date: Fri, 18 Sep 2026 08:16:58 +0200 From: Krzysztof Kozlowski To: Joshua Peisach Cc: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Heiko Stuebner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy Message-ID: <20260918-futuristic-mindful-waxbill-21fa2d@quoll> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2026 at 08:34:18PM -0400, Joshua Peisach wrote: > On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: > > > Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. > > > > > > This device is a child of the starfive,jh7110-hdmi-subsystem node. It > > > functions as both a PHY provider for the controller and as a clock > > > provider for the variable pixel clock (hdmi_pclk), which it generates > > > from its refoclk. > > > > > > Reviewed-by: Joshua Peisach > > > > While I appreciate other people looking at this, I don't think review > > here applies. It was a blanket tag, given to the entire series, with > > exception that it is from newbie, thus I want to ask: was this binding > > REALLY reviewed by Joshua? > > > > Are the rest of the patches actually reviewed or just "looks good to > > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > > of doing review. > > > > > I commented on v3 saying that I would test if I could. I don't just Testing has nothing to do with reviewing. > throw "Reviewed-by" on everything I look at. > > If anything, I've been trying to be more honest in reviews, and only > review ones that I actually care about[1]. You gave blanket tag for entire series, so I do not get this argument. > > If reviewing patches isn't a good way for newbies to start getting > familiar with the kernel code (especially a NEW driver), then I don't > know what is. Writing code and receiving review is something for newbies to start with. If you do not know kernel code or bindings, why do you think your review is applicable? If I try to review design of a post-tension concrete bridge, I would probably learn something. Would my review apply? No. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy