From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8B5CC982FE for ; Tue, 22 Sep 2026 06:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lop8hXlcfeym/iakNHB39DbKK0hUcN2N9a0AaEQQQIU=; b=CQwKDY14Sf0yyf YvQv9ffgjvBNXyjX1iX3BnsZ1Ra7c8PGezVZY9s7SKl1B8z3rmhXRxao/IUzzwzFfOw9qAtArpHq+ tZoW9REATenV7k5DtLzB5IEF6JGtFU3v7faH8LJAZiJ/km1b9Bjtmx32iSs0dvGX2OMUMFwZXiAhN s+L1MLj77fS/U5lndmkAwnoq0/6SCGna/7nC07pFisYjabxsNETXcN/LNux88mn3fxh+cYoPodwD0 EhZRYk3Ih+KLsR6+uTW0rJOd3P3tYd1X63qFEO+ZPbREVBtRPy06AK4eQUY/SA6YNzdyeRWmKKH7A Dy5lp+47/nnmRcQ16S1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8tnh-00000004Jpe-1GMq; Tue, 22 Sep 2026 06:16:21 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8tng-00000004JpX-2hoI for linux-phy@lists.infradead.org; Tue, 22 Sep 2026 06:16:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E702D43942; Tue, 22 Sep 2026 06:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37CC01F000FF; Tue, 22 Sep 2026 06:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790057779; bh=/vXLc3KmiHI0BdjyOF1vVkIbnWkhf1p3DV15kYagOYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VqrIcQhRzoFpQ4mdwFaOO4d2ucIiLTQfGR+B0kTVhDNUqpSJ27VbNBj2ECshiJrti /WZtLKuX1Mr2jtnAeLuwPrFkWIgy5zGnGcUXFxgsuxYek8xiN5A5S0Luntdw1VvKga UjcTyJz9HRL2pp93ewAu7I/ul0GE68KgWqKt1CA0= Date: Tue, 22 Sep 2026 08:16:16 +0200 From: Greg Kroah-Hartman To: Inochi Amaoto Cc: Hans de Goede , Damien Le Moal , Niklas Cassel , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Minas Harutyunyan , Thinh Nguyen , Vinod Koul , Manivannan Sadhasivam , Damon Ding , Dmitry Baryshkov , Heiko Stuebner , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [RFC PATCH 1/5] phy: core: Use EOPNOTSUPP for disabled blob return value Message-ID: <2026092236-breeze-educator-0f6b@gregkh> References: <20260922024724.191412-1-inochiama@gmail.com> <20260922024724.191412-2-inochiama@gmail.com> <2026092256-shading-gratify-835a@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, Sep 22, 2026 at 02:10:01PM +0800, Inochi Amaoto wrote: > On Tue, Sep 22, 2026 at 07:35:19AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 22, 2026 at 10:47:16AM +0800, Inochi Amaoto wrote: > > > Currently, the phy subsystem uses ENOSYS for dummy blob functions, > > > it does not reflect the function state correctly. As kernel already > > > has EOPNOTSUPP for disabled blob function, replace ENOSYS with > > > EOPNOTSUPP for a clear return value. > > > > > > Signed-off-by: Inochi Amaoto > > > --- > > > include/linux/phy/phy.h | 52 ++++++++++++++++++++--------------------- > > > 1 file changed, 26 insertions(+), 26 deletions(-) > > > > Based on the other patches in this series, this patch now breaks the > > users, right? Shouldn't this all happen at once? > > > > thanks, > > > > greg k-h > > It will break, and the change should happen at one. But I think > the affect should be limited as it only affect a special edge > case: build kernel with CONFIG_GENERIC_PHY disabled. So the > break should be limited. > > IIRC I was told to seperate the patch into small part so each > maintainer can take its own. Is it fine to squash these patches > into one in this a case? You can't break bisection of the tree, so if it all has to happen in one commit, that's required. But really, why is this needed at all? Who will benefit from this change? thanks, greg k-h -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy