Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pengpeng Hou <hppiscas@163.com>
To: mani@kernel.org
Cc: sashiko-reviews@lists.linux.dev, linux-phy@lists.infradead.org,
	olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org,
	hppiscas@163.com
Subject: Re: [PATCH] phy: ti: twl4030-usb: unwind late probe failures
Date: Wed, 14 Oct 2026 10:50:23 +0800	[thread overview]
Message-ID: <20261014025023.80752-1-hppiscas@163.com> (raw)
In-Reply-To: <ibju7oaxrobqgk77inpnj6nymok7mhdixr2du5iqsfuqiuwubq@6zzojhupkcbh>

Hi Mani,

The pm_runtime_put_noidle() path is wrong here: it drops the usage count
without running the suspend callback that powers down the PHY and
disables the regulators.

A replacement also needs to quiesce the IRQ and delayed work before
teardown. The IRQ path can hold an additional runtime-PM reference while
a cable is present, and the PHY is already publicly registered by this
point. Replacing only put_noidle() would not close those lifetime paths.

I'll keep the current patch on hold while reworking the publication and
cleanup ordering rather than resend the one-call substitution.

Thanks,
Pengpeng


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

      reply	other threads:[~2026-10-14  2:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  7:02 [PATCH] phy: ti: twl4030-usb: unwind late probe failures Pengpeng Hou
2026-06-15  7:13 ` sashiko-bot
2026-09-08  8:29   ` Manivannan Sadhasivam
2026-10-14  2:50     ` Pengpeng Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014025023.80752-1-hppiscas@163.com \
    --to=hppiscas@163.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox