From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1785B606A334 for ; Wed, 21 Oct 2026 10:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=04MlArxt; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=cknow-tech.com header.i=@cknow-tech.com header.a=rsa-sha256 header.s=key1 header.b=bu88LMKg DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4r4yTzfXsSGBTnWCvNNG38nHt6hgx0o9nI+FKtXADb0=; b=04MlArxtfzPkov YQqmadGYdXplYC6UIr/E2gNbgh1aWa10ynPBVwCVDWTvBrLzm5LPdqNZE/o7TYyQWwXfcImHBj4Mu U9f5dLfhiBBRD0vYoa+O3wxE3qR6/dJfhiSBFAKJRiNQfhjSE2n5WxvSqSowx/q7EQbIDX4GVOWN5 /g9H64SrPs/TCEkKB5suwIv0Tco4RmJ7foQwxSkBARavM9DO+CcKq9H2jcJwickeJYWP814BHl8T1 29XhCsfGf/dc4REP6l/4UCu7W9lvOUOHOzAbT1gJyxLuQndzNb9s0G1wo4t6Bg4HSZu4DC8m8KP8w vOdoFGCsAAqlvkAHQ5Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJTSP-0000000Bb0W-3UJZ; Wed, 21 Oct 2026 10:22:05 +0000 Received: from out-123.mta0.migadu.com ([2001:41d0:1004:224b::7b] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJTSM-0000000Baz9-2ic9 for linux-phy@lists.infradead.org; Wed, 21 Oct 2026 10:22:04 +0000 X-Envelope-To: linux-phy@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=M7vQgWT3GoO7sduxULKgRFfbTcBneeSPs/0sueXAB60=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792578120; v=1; x=1793182920; b=bu88LMKgSTxv6LpzEV6zMT1oIN3YbHyyI+rZ2+bUVkAJ/4StqocrlrDPhTm5hKgGmg9jYwez wGddRvL7ngAQN2LsBuVpNloKuGP30jP0rM/YCAJnLTobxrxRtXnq30voD4jZ0Krxj+325L0Alyq gypcDQfhvLjKR2gdfO6wi8V0UyrB6m/BkKxmIEvMXI5KN/6SfU/ZkpoKylkAUzx4QLzrYcOHH9v cHM+Zow1zBBUGUWsy6LkvnmzF9v5cLW2mebefqkJ9pnzhRrUv6Cz609SY1uBvy3B1U1B8b25UQq QjfPHYZ2unoeFmabW+4O/0cZ7ExkIEvZ0pf15NVlBI5Pw== X-Envelope-To: linux-phy@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id adc20fdeee7e491e; Wed, 21 Oct 2026 10:22:00 +0000 X-Mizu-Trace-ID: adc20fdeee7e491e X-Migadu-Flow: FLOW_OUT From: Diederik de Haas To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH] phy: rockchip: inno-usb2: Remove redundant dev_err() Date: Wed, 21 Oct 2026 12:21:20 +0200 Message-ID: <20261021102155.609575-1-diederik@cknow-tech.com> X-Mailer: git-send-email 2.55.0 X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261021_032203_131708_56BC9FBA X-CRM114-Status: UNSURE ( 8.00 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The devm_request_threaded_irq() function already automatically logs detailed error messages on failure since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()") So remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Diederik de Haas --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 23 ++++--------------- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index e47b89015586..0a8a22e7aa9c 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1183,10 +1183,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy, rockchip_usb2phy_linestate_irq, IRQF_ONESHOT, "rockchip_usb2phy", rport); - if (ret) { - dev_err(rphy->dev, "failed to request linestate irq handle\n"); + if (ret) return ret; - } break; case USB2PHY_PORT_OTG: /* @@ -1202,11 +1200,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy, IRQF_ONESHOT, "rockchip_usb2phy_otg", rport); - if (ret) { - dev_err(rphy->dev, - "failed to request otg-mux irq handle\n"); + if (ret) return ret; - } } else { rport->bvalid_irq = of_irq_get_byname(child_np, "otg-bvalid"); if (rport->bvalid_irq < 0) { @@ -1221,11 +1216,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy, IRQF_ONESHOT, "rockchip_usb2phy_bvalid", rport); - if (ret) { - dev_err(rphy->dev, - "failed to request otg-bvalid irq handle\n"); + if (ret) return ret; - } rport->id_irq = of_irq_get_byname(child_np, "otg-id"); if (rport->id_irq < 0) { @@ -1240,11 +1232,8 @@ static int rockchip_usb2phy_port_irq_init(struct rockchip_usb2phy *rphy, IRQF_ONESHOT, "rockchip_usb2phy_id", rport); - if (ret) { - dev_err(rphy->dev, - "failed to request otg-id irq handle\n"); + if (ret) return ret; - } } break; default: @@ -1491,10 +1480,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) IRQF_ONESHOT, "rockchip_usb2phy", rphy); - if (ret) { - dev_err_probe(rphy->dev, ret, "failed to request usb2phy irq handle\n"); + if (ret) return ret; - } } return PTR_ERR_OR_ZERO(provider); -- 2.55.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy