From: "Heiko Stübner" <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>, Chukun Pan <amadeus@jmu.edu.cn>
Cc: Yao Zi <ziyao@disroot.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Chukun Pan <amadeus@jmu.edu.cn>
Subject: Re: [PATCH 1/1] phy: rockchip: naneng-combphy: use existing DT property check for rk3528
Date: Thu, 11 Sep 2025 10:55:17 +0200 [thread overview]
Message-ID: <2049032.8hb0ThOEGa@diego> (raw)
In-Reply-To: <20250910122000.951100-1-amadeus@jmu.edu.cn>
Am Mittwoch, 10. September 2025, 14:20:00 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> The naneng-combphy driver already has DT property checks for
> "rockchip,enable-ssc" and "rockchip,ext-refclk", use it for
> the rk3528_combphy_cfg. Also aligned the indentation of the
> rk3528_combphy_grfcfgs parameters (using tabs).
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> index a3ef19807b9e..ad6c8a11951b 100644
> --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> @@ -518,7 +518,7 @@ static int rk3528_combphy_cfg(struct rockchip_combphy_priv *priv)
> return -EINVAL;
> }
>
> - if (device_property_read_bool(priv->dev, "rockchip,ext-refclk")) {
> + if (priv->ext_refclk) {
> rockchip_combphy_param_write(priv->phy_grf, &cfg->pipe_clk_ext, true);
>
> if (priv->type == PHY_TYPE_PCIE && rate == REF_CLOCK_100MHz) {
> @@ -543,11 +543,9 @@ static int rk3528_combphy_cfg(struct rockchip_combphy_priv *priv)
> }
> }
>
> - if (priv->type == PHY_TYPE_PCIE) {
> - if (device_property_read_bool(priv->dev, "rockchip,enable-ssc"))
> - rockchip_combphy_updatel(priv, RK3528_PHYREG40_SSC_EN,
> - RK3528_PHYREG40_SSC_EN, RK3528_PHYREG40);
> - }
> + if (priv->type == PHY_TYPE_PCIE && priv->enable_ssc)
> + rockchip_combphy_updatel(priv, RK3528_PHYREG40_SSC_EN,
> + RK3528_PHYREG40_SSC_EN, RK3528_PHYREG40);
>
> return 0;
> }
> @@ -571,7 +569,7 @@ static const struct rockchip_combphy_grfcfg rk3528_combphy_grfcfgs = {
> .con2_for_pcie = { 0x0008, 15, 0, 0x00, 0x101 },
> .con3_for_pcie = { 0x000c, 15, 0, 0x00, 0x0200 },
> /* pipe-grf */
> - .u3otg0_port_en = { 0x0044, 15, 0, 0x0181, 0x1100 },
> + .u3otg0_port_en = { 0x0044, 15, 0, 0x0181, 0x1100 },
> };
>
> static const struct rockchip_combphy_cfg rk3528_combphy_cfgs = {
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-09-11 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 12:20 [PATCH 1/1] phy: rockchip: naneng-combphy: use existing DT property check for rk3528 Chukun Pan
2025-09-10 12:44 ` Yao Zi
2025-09-11 8:55 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2049032.8hb0ThOEGa@diego \
--to=heiko@sntech.de \
--cc=amadeus@jmu.edu.cn \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).