From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 168D2C982DA for ; Fri, 18 Sep 2026 14:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o48YpKFxufuC5/mzw0G/OZCZzelPpTgWb4aXLeRgunQ=; b=Wx0aeE2KJnySrbyl/Xw8xjdm2y nXVj3HPoBv7meOPVHfFFaAh/qUU3N9Ny/qO38fmce47rubXlUWGZxeCpe5vrHTDTb0UePZC/geO2m CYfIJ4/2MGVZWBEDfdU1IZwdM+NKNxiDz2v3+nmE7fXMYIrzUquDv1VG3sFNPj9U+STBxhwKM27Sg XIz5Wng7X+9TxPkAUT5heoKaQCH0eu3IobBVyTTSsekZmPoafj5tDcDUXG/0omT8R427TqfKU7Di4 4+FyNEQMgo/0JF2AsPzd17H+1gP8n5NyZxHZuCI5dE3P+cJ4ES1i7YbIA+cHVkg1WgMP7ARkfo2EA LHmnEqgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7ZI8-0000000EfUy-3MOy; Fri, 18 Sep 2026 14:10:16 +0000 Received: from mail-wm2-x11.google.com ([2a00:1450:4864:31::11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7ZI6-0000000EfTt-3d6d for linux-phy@lists.infradead.org; Fri, 18 Sep 2026 14:10:16 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49e7bcb94d3so5552435e9.2 for ; Fri, 18 Sep 2026 07:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789740612; x=1790345412; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/sFF3r4DRhx7a8tyTsw515wTIKdus61vqFEq2INSsxk=; b=EIFmxV1K3LdWT8vBp6Dv+I5IaG0GIeDRbLIDbYa3l1cFLpjajUH3WDT1U6WCn5GJqs m090tYlwO/3wliDNVobPOol73LiUKJBVlT43fVUQRZwcB6O+uhwwHeRXWaYQNbz26L+c mhn05aVQ1e+9UXv2gUYn56Cy0eF20KaeHxrPUfLRdS71P9aCEGmJE34yzZwp8FjkYbUx Pl241q07GqkKB1Z5o5IxItmxvvmRmta9Qm+udtl+BMZ9fdJn1L98xP/jnkDkBhpgh63I PG95YpHJlrZiSKorOE6KJhzDUGLpPYEClJkavuGhGerZHNwiqpiidF6SfyD//MmPp0KQ 8AiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789740612; x=1790345412; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=/sFF3r4DRhx7a8tyTsw515wTIKdus61vqFEq2INSsxk=; b=aBphBMxf5KLvbBvQDdJie4yiyLMibwQMeCYvigo7aDuklIm6+iqoZrYhGvSAsnvKCb +B+ISKZdaB/g8sV3kzmIMoo0+ugRqOgqD5sTLhfbbSGVzfQxfWRclWknCFLhB3b3zeYS kSQ0suuvqpL24KEDCuH0UhCSzTFptV9+zHDgWN9sTEdKNBk0HTFD/IPRAks4z5bsh+HR MUwdjoAKIfiIK6IZAs6ilicleSZLFmA7hu59OuGzz20JRxPc+WodxkTQfSqQpLxfN4EZ cks6DWkGlWL3LLe0oTYOqw99Ctjg26Of+j5no8ib6dZ86ZmEG2Uc25kfIlEVirJBZ1GE iNCw== X-Forwarded-Encrypted: i=1; AKwUvBxdtNs5gI0hL4spNO7lyAKpAu1gAeGEi3oaKRNXVOiLF5bB8uDW/zjK+v58pUB5rorYiQo26045tAI=@lists.infradead.org X-Gm-Message-State: AFuF++nCci56/fXvpLrOOGFHrh/iaqgI5VR1oeYeuzwxec47Yzr5ksJF M6KuTwxImlJw9P1tsDa2b/Ao9yq7ovWm3Z879QHlDfb0lviEjEQOUN5TvkUQGzfcM7Y= X-Gm-Gg: AYBFou2GlyKE1lv3TViNQnYK2OCv0O7T4zLPOfGn7jTPNPihw3bAmIXR4wiXnauwI0r Ym0rNcbClDxw71kgbCtH9f2Vlfs9MWDgydD8GviYSz4AhrXy1ciNJBK+/mNgxYJnJQFUZhZL40K KRFuSTxhSqm7VXnH/LJ86I5lkCSBooDVMGUSepmRwE6VB7YhHr2wclBs/mGjVTipppxee9aBUOy rv3QWdsBauUf1JedQ20K3X3ulIO7xQlYC96r1RLfdT5H14gT+h5iZG4IB6nGz6SUNAuMxG3qchJ pUXddSMmVKLho/hkqfV7mKXfKb9Bkw//qfztt3DGUJ1CB8B8jl6kqAFZChwvMKEv4poBdD1Hedu qgI9nUtf3OUa+QtwqG1ed2ed4mfvAF8g+JLu3zKugxGtCCk24FBBa9F8svKbfEQ8z/ROPGgFUIq 9tSbMSbyiuaR2Ra0soWhJYc2NWxB1tEscjsSMNsjgBDoiavtFIsrjDVOZYHec8I/l2ZVGGeaTzz guEQ80okBpltY5LWGUVcXlONzjkP/rOhLoARIxsshwoHbfCU4601Rw= X-Received: by 2002:a05:600c:354e:b0:49e:6bc7:4e1b with SMTP id 5b1f17b1804b1-49fc56ef4fcmr31999545e9.15.1789740612196; Fri, 18 Sep 2026 07:10:12 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:c55f:cb91:1ca5:54dc? ([2a01:e0a:106d:1080:c55f:cb91:1ca5:54dc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd216028sm158229625e9.7.2026.09.18.07.10.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 07:10:11 -0700 (PDT) Message-ID: <211caa95-dfbc-427d-8ce8-49cc76c24124@linaro.org> Date: Fri, 18 Sep 2026 16:10:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v20 2/6] phy: core: Add phy_get_by_of_node() To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue , Loic Poulain , Vinod Koul , Greg Kroah-Hartman , Kishon Vijay Abraham I , Felipe Balbi , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, Krzysztof Kozlowski References: <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-0-dc244e124e71@linaro.org> <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-2-dc244e124e71@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-2-dc244e124e71@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_071014_956524_4C5ABFAD X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 9/18/26 15:56, Bryan O'Donoghue wrote: > Add new function phy_get_by_of_node() allowing lookup of a phy by > device_node. Separates existing logic in _of_phy_get() into an internal > helper method _of_phy_get_with_args() to allow for reuse in new method. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/phy/phy-core.c | 83 ++++++++++++++++++++++++++++++++++++++----------- > include/linux/phy/phy.h | 6 ++++ > 2 files changed, 71 insertions(+), 18 deletions(-) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 89addd732bff3..42c27a2b45159 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -606,6 +606,38 @@ int phy_validate(struct phy *phy, enum phy_mode mode, int submode, > } > EXPORT_SYMBOL_GPL(phy_validate); > > +/** > + * _of_phy_get_with_args() - lookup and obtain a reference to a phy by of_phandle_args > + * @args: of_phandle_args to the phy > + * > + * Returns: the phy from the provider's of_xlate, -ENODEV if disabled, > + * -EPROBE_DEFER if the provider is not yet registered. > + */ > +static struct phy *_of_phy_get_with_args(struct of_phandle_args *args) > +{ > + struct phy *phy; > + struct phy_provider *phy_provider; > + > + lockdep_assert_held(&phy_provider_mutex); > + > + phy_provider = of_phy_provider_lookup(args->np); > + if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) > + return ERR_PTR(-EPROBE_DEFER); > + > + if (!of_device_is_available(args->np)) { > + dev_warn(phy_provider->dev, "Requested PHY is disabled\n"); > + phy = ERR_PTR(-ENODEV); > + goto out_put_module; > + } > + > + phy = phy_provider->of_xlate(phy_provider->dev, args); > + > +out_put_module: > + module_put(phy_provider->owner); > + > + return phy; > +} > + > /** > * _of_phy_get() - lookup and obtain a reference to a phy by phandle > * @np: device_node for which to get the phy > @@ -620,8 +652,7 @@ EXPORT_SYMBOL_GPL(phy_validate); > static struct phy *_of_phy_get(struct device_node *np, int index) > { > int ret; > - struct phy_provider *phy_provider; > - struct phy *phy = NULL; > + struct phy *phy; > struct of_phandle_args args; > > lockdep_assert_held(&phy_provider_mutex); > @@ -637,22 +668,7 @@ static struct phy *_of_phy_get(struct device_node *np, int index) > goto out_put_node; > } > > - phy_provider = of_phy_provider_lookup(args.np); > - if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) { > - phy = ERR_PTR(-EPROBE_DEFER); > - goto out_put_node; > - } > - > - if (!of_device_is_available(args.np)) { > - dev_warn(phy_provider->dev, "Requested PHY is disabled\n"); > - phy = ERR_PTR(-ENODEV); > - goto out_put_module; > - } > - > - phy = phy_provider->of_xlate(phy_provider->dev, &args); > - > -out_put_module: > - module_put(phy_provider->owner); > + phy = _of_phy_get_with_args(&args); > > out_put_node: > of_node_put(args.np); > @@ -1001,6 +1017,37 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np, > } > EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index); > > +/** > + * phy_get_by_of_node() - lookup and obtain a reference to a phy by device_node > + * @np: node containing the phy > + * > + * Returns: the phy associated with the device node or ERR_PTR. > + */ > +struct phy *phy_get_by_of_node(struct device_node *np) > +{ > + struct of_phandle_args args = { .np = np, .args_count = 0 }; > + struct phy *phy; > + > + mutex_lock(&phy_provider_mutex); I don't really understand the usage of lockdep_assert_held(), but why does _of_phy_get() uses lockdep_assert_held() and here you use mutex_lock() like before patch 1 ? Neil > + > + phy = _of_phy_get_with_args(&args); > + if (IS_ERR(phy)) > + goto out_unlock; > + > + if (!try_module_get(phy->ops->owner)) { > + phy = ERR_PTR(-EPROBE_DEFER); > + goto out_unlock; > + } > + > + get_device(&phy->dev); > + > +out_unlock: > + mutex_unlock(&phy_provider_mutex); > + > + return phy; > +} > +EXPORT_SYMBOL_GPL(phy_get_by_of_node); > + > /** > * phy_create() - create a new phy > * @dev: device that is creating the new phy > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index ea47975e288ae..71c2e16397130 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -284,6 +284,7 @@ struct phy *devm_of_phy_optional_get(struct device *dev, struct device_node *np, > const char *con_id); > struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np, > int index); > +struct phy *phy_get_by_of_node(struct device_node *np); > void of_phy_put(struct phy *phy); > void phy_put(struct device *dev, struct phy *phy); > void devm_phy_put(struct device *dev, struct phy *phy); > @@ -493,6 +494,11 @@ static inline struct phy *devm_of_phy_get_by_index(struct device *dev, > return ERR_PTR(-ENOSYS); > } > > +static inline struct phy *phy_get_by_of_node(struct device_node *np) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > static inline void of_phy_put(struct phy *phy) > { > } > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy