* Re: [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy
2024-12-31 9:27 [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
@ 2025-01-03 19:05 ` Rob Herring (Arm)
2025-01-04 22:26 ` Heiko Stuebner
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-01-03 19:05 UTC (permalink / raw)
To: Andy Yan
Cc: kishon, vkoul, heiko, linux-rockchip, krzk+dt, Andy Yan,
linux-arm-kernel, linux-phy, linux-kernel, cristian.ciocaltea,
devicetree
On Tue, 31 Dec 2024 17:27:11 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Add compatible for the HDPTX PHY on rk3576, which is compatible with
> rk3588, but without rst_phy/rst_ropll/rst_lcpll.
>
> In fact, these three reset lines are also optional on the rk3588,
> they just used for debug, then they were removed on the rk3576 IC
> design.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v3:
> - Split from:
> https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#m02151cd8591d7fe92cf30ab69701ed57c1944c06
>
> Changes in v2:
> - Wrap commit message according to Linux coding style
> - Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
> - Make declare phy/ropll/lcpll reset line are not exit on rk3576
>
> .../phy/rockchip,rk3588-hdptx-phy.yaml | 62 +++++++++++++------
> 1 file changed, 44 insertions(+), 18 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy
2024-12-31 9:27 [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
2025-01-03 19:05 ` Rob Herring (Arm)
@ 2025-01-04 22:26 ` Heiko Stuebner
2025-02-09 20:13 ` Heiko Stübner
2025-02-10 17:21 ` (subset) " Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2025-01-04 22:26 UTC (permalink / raw)
To: vkoul, Andy Yan
Cc: cristian.ciocaltea, kishon, krzk+dt, robh, devicetree,
linux-arm-kernel, linux-kernel, linux-phy, linux-rockchip,
Andy Yan
Am Dienstag, 31. Dezember 2024, 10:27:11 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Add compatible for the HDPTX PHY on rk3576, which is compatible with
> rk3588, but without rst_phy/rst_ropll/rst_lcpll.
>
> In fact, these three reset lines are also optional on the rk3588,
> they just used for debug, then they were removed on the rk3576 IC
> design.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy
2024-12-31 9:27 [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
2025-01-03 19:05 ` Rob Herring (Arm)
2025-01-04 22:26 ` Heiko Stuebner
@ 2025-02-09 20:13 ` Heiko Stübner
2025-02-10 17:21 ` (subset) " Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2025-02-09 20:13 UTC (permalink / raw)
To: vkoul, Andy Yan
Cc: cristian.ciocaltea, kishon, krzk+dt, robh, devicetree,
linux-arm-kernel, linux-kernel, linux-phy, linux-rockchip,
Andy Yan
Vinod,
Am Dienstag, 31. Dezember 2024, 10:27:11 MEZ schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Add compatible for the HDPTX PHY on rk3576, which is compatible with
> rk3588, but without rst_phy/rst_ropll/rst_lcpll.
>
> In fact, these three reset lines are also optional on the rk3588,
> they just used for debug, then they were removed on the rk3576 IC
> design.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
With the binding more in the driver-realm, I guess this should go through
the phy tree?
Thanks a lot
Heiko
> ---
>
> Changes in v3:
> - Split from:
> https://lore.kernel.org/linux-rockchip/3330586.aeNJFYEL58@diego/T/#m02151cd8591d7fe92cf30ab69701ed57c1944c06
>
> Changes in v2:
> - Wrap commit message according to Linux coding style
> - Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
> - Make declare phy/ropll/lcpll reset line are not exit on rk3576
>
> .../phy/rockchip,rk3588-hdptx-phy.yaml | 62 +++++++++++++------
> 1 file changed, 44 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
> index 84fe59dbcf48..7a307f45cdec 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
> @@ -11,8 +11,13 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - rockchip,rk3588-hdptx-phy
> + oneOf:
> + - enum:
> + - rockchip,rk3588-hdptx-phy
> + - items:
> + - enum:
> + - rockchip,rk3576-hdptx-phy
> + - const: rockchip,rk3588-hdptx-phy
>
> reg:
> maxItems: 1
> @@ -34,24 +39,12 @@ properties:
> const: 0
>
> resets:
> - items:
> - - description: PHY reset line
> - - description: APB reset line
> - - description: INIT reset line
> - - description: CMN reset line
> - - description: LANE reset line
> - - description: ROPLL reset line
> - - description: LCPLL reset line
> + minItems: 4
> + maxItems: 7
>
> reset-names:
> - items:
> - - const: phy
> - - const: apb
> - - const: init
> - - const: cmn
> - - const: lane
> - - const: ropll
> - - const: lcpll
> + minItems: 4
> + maxItems: 7
>
> rockchip,grf:
> $ref: /schemas/types.yaml#/definitions/phandle
> @@ -67,6 +60,39 @@ required:
> - reset-names
> - rockchip,grf
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3576-hdptx-phy
> + then:
> + properties:
> + resets:
> + minItems: 4
> + maxItems: 4
> + reset-names:
> + items:
> + - const: apb
> + - const: init
> + - const: cmn
> + - const: lane
> + else:
> + properties:
> + resets:
> + minItems: 7
> + maxItems: 7
> + reset-names:
> + items:
> + - const: phy
> + - const: apb
> + - const: init
> + - const: cmn
> + - const: lane
> + - const: ropll
> + - const: lcpll
> +
> additionalProperties: false
>
> examples:
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy
2024-12-31 9:27 [PATCH v3] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
` (2 preceding siblings ...)
2025-02-09 20:13 ` Heiko Stübner
@ 2025-02-10 17:21 ` Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2025-02-10 17:21 UTC (permalink / raw)
To: Andy Yan
Cc: cristian.ciocaltea, heiko, kishon, krzk+dt, robh, devicetree,
linux-arm-kernel, linux-kernel, linux-phy, linux-rockchip,
Andy Yan
On Tue, 31 Dec 2024 17:27:11 +0800, Andy Yan wrote:
> Add compatible for the HDPTX PHY on rk3576, which is compatible with
> rk3588, but without rst_phy/rst_ropll/rst_lcpll.
>
> In fact, these three reset lines are also optional on the rk3588,
> they just used for debug, then they were removed on the rk3576 IC
> design.
>
> [...]
Applied, thanks!
[1/1] dt-bindings: phy: Add rk3576 hdptx phy
commit: ad205ffc0dd0fc3f4841e6ae900037f029aa0fa8
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread