* [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562
@ 2024-12-24 9:42 Kever Yang
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kever Yang @ 2024-12-24 9:42 UTC (permalink / raw)
To: heiko
Cc: linux-rockchip, Kever Yang, devicetree, Conor Dooley, Rob Herring,
Vinod Koul, linux-kernel, Krzysztof Kozlowski, linux-phy,
Kishon Vijay Abraham I, linux-arm-kernel
Add compatible for the USB2 phy in the Rockchip RK3562 SoC.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
.../devicetree/bindings/phy/rockchip,inno-usb2phy.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
index 6a7ef556414c..367297f6f8b5 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
@@ -19,6 +19,7 @@ properties:
- rockchip,rk3328-usb2phy
- rockchip,rk3366-usb2phy
- rockchip,rk3399-usb2phy
+ - rockchip,rk3562-usb2phy
- rockchip,rk3568-usb2phy
- rockchip,rk3576-usb2phy
- rockchip,rk3588-usb2phy
@@ -150,7 +151,6 @@ allOf:
enum:
- rockchip,rk3568-usb2phy
- rockchip,rk3588-usb2phy
-
then:
properties:
host-port:
@@ -190,6 +190,7 @@ allOf:
- rockchip,rk3328-usb2phy
- rockchip,rk3366-usb2phy
- rockchip,rk3399-usb2phy
+ - rockchip,rk3562-usb2phy
- rockchip,rk3568-usb2phy
- rockchip,rk3588-usb2phy
- rockchip,rv1108-usb2phy
--
2.25.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562
2024-12-24 9:42 [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Kever Yang
@ 2024-12-24 9:42 ` Kever Yang
2024-12-24 12:29 ` Heiko Stübner
2025-03-11 10:00 ` Chukun Pan
2024-12-24 12:27 ` [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Heiko Stübner
2025-03-11 11:22 ` Vinod Koul
2 siblings, 2 replies; 6+ messages in thread
From: Kever Yang @ 2024-12-24 9:42 UTC (permalink / raw)
To: heiko
Cc: linux-rockchip, Frank Wang, William Wu, Kever Yang, Vinod Koul,
linux-kernel, linux-phy, Kishon Vijay Abraham I, linux-arm-kernel
From: Frank Wang <frank.wang@rock-chips.com>
RK3652 has one USB2.0 PHY with two ports, the OTG port support OTG
and BC1.2, the SoC provide USB GRF and APB to access the registers.
This adds vbus detection function control and make the below tuning
to enhance the usb2-phy SQ for RK3562 SoC.
- enable pre-emphasis during non-chirp phase
- set HS eye height to 425mv
- turn off differential receiver by default to save power
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Signed-off-by: William Wu <william.wu@rock-chips.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 49 +++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 96f3d868a526..946dd7ac409d 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1892,6 +1892,54 @@ static const struct rockchip_usb2phy_cfg rk3399_phy_cfgs[] = {
{ /* sentinel */ }
};
+static const struct rockchip_usb2phy_cfg rk3562_phy_cfgs[] = {
+ {
+ .reg = 0xff740000,
+ .num_ports = 2,
+ .clkout_ctl = { 0x0108, 4, 4, 1, 0 },
+ .port_cfgs = {
+ [USB2PHY_PORT_OTG] = {
+ .phy_sus = { 0x0100, 8, 0, 0, 0x1d1 },
+ .bvalid_det_en = { 0x0110, 2, 2, 0, 1 },
+ .bvalid_det_st = { 0x0114, 2, 2, 0, 1 },
+ .bvalid_det_clr = { 0x0118, 2, 2, 0, 1 },
+ .idfall_det_en = { 0x0110, 5, 5, 0, 1 },
+ .idfall_det_st = { 0x0114, 5, 5, 0, 1 },
+ .idfall_det_clr = { 0x0118, 5, 5, 0, 1 },
+ .idrise_det_en = { 0x0110, 4, 4, 0, 1 },
+ .idrise_det_st = { 0x0114, 4, 4, 0, 1 },
+ .idrise_det_clr = { 0x0118, 4, 4, 0, 1 },
+ .ls_det_en = { 0x0110, 0, 0, 0, 1 },
+ .ls_det_st = { 0x0114, 0, 0, 0, 1 },
+ .ls_det_clr = { 0x0118, 0, 0, 0, 1 },
+ .utmi_avalid = { 0x0120, 10, 10, 0, 1 },
+ .utmi_bvalid = { 0x0120, 9, 9, 0, 1 },
+ .utmi_ls = { 0x0120, 5, 4, 0, 1 },
+ },
+ [USB2PHY_PORT_HOST] = {
+ .phy_sus = { 0x0104, 8, 0, 0x1d2, 0x1d1 },
+ .ls_det_en = { 0x0110, 1, 1, 0, 1 },
+ .ls_det_st = { 0x0114, 1, 1, 0, 1 },
+ .ls_det_clr = { 0x0118, 1, 1, 0, 1 },
+ .utmi_ls = { 0x0120, 17, 16, 0, 1 },
+ .utmi_hstdet = { 0x0120, 19, 19, 0, 1 }
+ }
+ },
+ .chg_det = {
+ .cp_det = { 0x0120, 24, 24, 0, 1 },
+ .dcp_det = { 0x0120, 23, 23, 0, 1 },
+ .dp_det = { 0x0120, 25, 25, 0, 1 },
+ .idm_sink_en = { 0x0108, 8, 8, 0, 1 },
+ .idp_sink_en = { 0x0108, 7, 7, 0, 1 },
+ .idp_src_en = { 0x0108, 9, 9, 0, 1 },
+ .rdm_pdwn_en = { 0x0108, 10, 10, 0, 1 },
+ .vdm_src_en = { 0x0108, 12, 12, 0, 1 },
+ .vdp_src_en = { 0x0108, 11, 11, 0, 1 },
+ },
+ },
+ { /* sentinel */ }
+};
+
static const struct rockchip_usb2phy_cfg rk3568_phy_cfgs[] = {
{
.reg = 0xfe8a0000,
@@ -2210,6 +2258,7 @@ static const struct of_device_id rockchip_usb2phy_dt_match[] = {
{ .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs },
{ .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs },
{ .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs },
+ { .compatible = "rockchip,rk3562-usb2phy", .data = &rk3562_phy_cfgs },
{ .compatible = "rockchip,rk3568-usb2phy", .data = &rk3568_phy_cfgs },
{ .compatible = "rockchip,rk3576-usb2phy", .data = &rk3576_phy_cfgs },
{ .compatible = "rockchip,rk3588-usb2phy", .data = &rk3588_phy_cfgs },
--
2.25.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562
2024-12-24 9:42 [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Kever Yang
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
@ 2024-12-24 12:27 ` Heiko Stübner
2025-03-11 11:22 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2024-12-24 12:27 UTC (permalink / raw)
To: Kever Yang
Cc: linux-rockchip, Kever Yang, devicetree, Conor Dooley, Rob Herring,
Vinod Koul, linux-kernel, Krzysztof Kozlowski, linux-phy,
Kishon Vijay Abraham I, linux-arm-kernel
Am Dienstag, 24. Dezember 2024, 10:42:39 CET schrieb Kever Yang:
> Add compatible for the USB2 phy in the Rockchip RK3562 SoC.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
>
> .../devicetree/bindings/phy/rockchip,inno-usb2phy.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> index 6a7ef556414c..367297f6f8b5 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> @@ -19,6 +19,7 @@ properties:
> - rockchip,rk3328-usb2phy
> - rockchip,rk3366-usb2phy
> - rockchip,rk3399-usb2phy
> + - rockchip,rk3562-usb2phy
> - rockchip,rk3568-usb2phy
> - rockchip,rk3576-usb2phy
> - rockchip,rk3588-usb2phy
> @@ -150,7 +151,6 @@ allOf:
> enum:
> - rockchip,rk3568-usb2phy
> - rockchip,rk3588-usb2phy
> -
> then:
> properties:
> host-port:
> @@ -190,6 +190,7 @@ allOf:
> - rockchip,rk3328-usb2phy
> - rockchip,rk3366-usb2phy
> - rockchip,rk3399-usb2phy
> + - rockchip,rk3562-usb2phy
> - rockchip,rk3568-usb2phy
> - rockchip,rk3588-usb2phy
> - rockchip,rv1108-usb2phy
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
@ 2024-12-24 12:29 ` Heiko Stübner
2025-03-11 10:00 ` Chukun Pan
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2024-12-24 12:29 UTC (permalink / raw)
To: Kever Yang
Cc: linux-rockchip, Frank Wang, William Wu, Kever Yang, Vinod Koul,
linux-kernel, linux-phy, Kishon Vijay Abraham I, linux-arm-kernel
Am Dienstag, 24. Dezember 2024, 10:42:40 CET schrieb Kever Yang:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> RK3652 has one USB2.0 PHY with two ports, the OTG port support OTG
> and BC1.2, the SoC provide USB GRF and APB to access the registers.
>
> This adds vbus detection function control and make the below tuning
> to enhance the usb2-phy SQ for RK3562 SoC.
> - enable pre-emphasis during non-chirp phase
> - set HS eye height to 425mv
> - turn off differential receiver by default to save power
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
2024-12-24 12:29 ` Heiko Stübner
@ 2025-03-11 10:00 ` Chukun Pan
1 sibling, 0 replies; 6+ messages in thread
From: Chukun Pan @ 2025-03-11 10:00 UTC (permalink / raw)
To: kever.yang
Cc: frank.wang, heiko, kishon, linux-arm-kernel, linux-kernel,
linux-phy, linux-rockchip, vkoul, Chukun Pan
Hi,
> This adds vbus detection function control and make the below tuning
> to enhance the usb2-phy SQ for RK3562 SoC.
> - enable pre-emphasis during non-chirp phase
> - set HS eye height to 425mv
> - turn off differential receiver by default to save power
This is implemented by the rk3562_usb2phy_tuning function. Since
this is missing, I think the commit message needs to be changed.
Thanks,
Chukun
--
2.25.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562
2024-12-24 9:42 [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Kever Yang
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
2024-12-24 12:27 ` [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Heiko Stübner
@ 2025-03-11 11:22 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-03-11 11:22 UTC (permalink / raw)
To: Kever Yang
Cc: heiko, linux-rockchip, devicetree, Conor Dooley, Rob Herring,
linux-kernel, Krzysztof Kozlowski, linux-phy,
Kishon Vijay Abraham I, linux-arm-kernel
On 24-12-24, 17:42, Kever Yang wrote:
> Add compatible for the USB2 phy in the Rockchip RK3562 SoC.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> .../devicetree/bindings/phy/rockchip,inno-usb2phy.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> index 6a7ef556414c..367297f6f8b5 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml
> @@ -19,6 +19,7 @@ properties:
> - rockchip,rk3328-usb2phy
> - rockchip,rk3366-usb2phy
> - rockchip,rk3399-usb2phy
> + - rockchip,rk3562-usb2phy
> - rockchip,rk3568-usb2phy
> - rockchip,rk3576-usb2phy
> - rockchip,rk3588-usb2phy
> @@ -150,7 +151,6 @@ allOf:
> enum:
> - rockchip,rk3568-usb2phy
> - rockchip,rk3588-usb2phy
> -
Unrelated change?
> then:
> properties:
> host-port:
> @@ -190,6 +190,7 @@ allOf:
> - rockchip,rk3328-usb2phy
> - rockchip,rk3366-usb2phy
> - rockchip,rk3399-usb2phy
> + - rockchip,rk3562-usb2phy
> - rockchip,rk3568-usb2phy
> - rockchip,rk3588-usb2phy
> - rockchip,rv1108-usb2phy
> --
> 2.25.1
>
>
> --
> linux-phy mailing list
> linux-phy@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/linux-phy
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-11 11:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-24 9:42 [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Kever Yang
2024-12-24 9:42 ` [PATCH 2/2] phy: rockchip: inno-usb2: add usb2 phy support for rk3562 Kever Yang
2024-12-24 12:29 ` Heiko Stübner
2025-03-11 10:00 ` Chukun Pan
2024-12-24 12:27 ` [PATCH 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3562 Heiko Stübner
2025-03-11 11:22 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).