From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chenyuan Yang <chenyuan0y@gmail.com>,
vkoul@kernel.org, kishon@kernel.org, lumag@kernel.org,
quic_kriskura@quicinc.com, manivannan.sadhasivam@linaro.org,
konrad.dybcio@oss.qualcomm.com, quic_varada@quicinc.com,
quic_kbajaj@quicinc.com, johan+linaro@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug
Date: Mon, 14 Apr 2025 09:30:19 +0200 [thread overview]
Message-ID: <22ec4fc8-9368-4955-ac97-c49b3317d3b3@kernel.org> (raw)
In-Reply-To: <20250413212518.2625540-1-chenyuan0y@gmail.com>
On 13/04/2025 23:25, Chenyuan Yang wrote:
> In qmp_usb_iomap(), one branch returns the result of devm_ioremap(), which
> can be NULL. Since IS_ERR() does not catch a NULL pointer,
No, that's not true. NAK.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-04-14 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-13 21:25 [PATCH] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug Chenyuan Yang
2025-04-14 6:57 ` Johan Hovold
2025-04-14 7:30 ` Krzysztof Kozlowski [this message]
2025-04-14 7:40 ` Johan Hovold
2025-04-14 8:08 ` Krzysztof Kozlowski
2025-04-14 8:13 ` Johan Hovold
2025-04-14 12:52 ` Chenyuan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ec4fc8-9368-4955-ac97-c49b3317d3b3@kernel.org \
--to=krzk@kernel.org \
--cc=chenyuan0y@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox