From: "Yulin Lu" <luyulin@eswincomputing.com>
To: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
fenglin@eswincomputing.com
Subject: Re: [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY
Date: Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00) [thread overview]
Message-ID: <22fea2d6.370e.19c55a86a72.Coremail.luyulin@eswincomputing.com> (raw)
In-Reply-To: <20260205082009.1780-1-luyulin@eswincomputing.com>
> Updates:
> v9 -> v8:
> - eswin,eic7700-sata-phy.yaml
> - Modify the format of the "default" field in the
> "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning"
> properties.
> - phy-eic7700-sata.c
> - Correct the incorrectly formatted symbol "-" in the comments.
> - Link to v8: https://lore.kernel.org/lkml/20260123024823.1612-1-luyulin@eswincomputing.com/
>
> v8 -> v7:
> - eswin,eic7700-sata-phy.yaml
> - Add "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning"
> properties, because these parameters may vary across different
> circuit boards.
> - Delete reviewed-by tag of Krzysztof Kozlowski, because the tuning
> properties are introduced.
> - phy-eic7700-sata.c
> - Try to get SATA PHY transmitter amplitude and pre-emphasis signal
> eye diagram tuning parameters from dts instead of hardcoded values
> in the code. Because, these parameters may vary across different
> circuit boards. Define default tuning parameters and use it when
> these properties are not declared in dts.
> - Add a comment to explain the reason for mapping I/O resources with
> platform_get_resource and devm_ioremap instead of using the
> devm_platform_ioremap_resource API.
> - Link to v7: https://lore.kernel.org/lkml/20260106062944.1529-1-luyulin@eswincomputing.com/
Hi Vinod, all,
In v7, I got driver review comments from Vinod. After fixing and submitting v8,
I received yaml comments from Krzysztof. v9 now has Reviewed-by from Krzysztof.
So I want to confirm whether there are any further comments on the driver code
in v9 and if it meets the requirements for merging.
Best regards,
Yulin Lu
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-02-13 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 8:20 [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY Yulin Lu
2026-02-05 8:21 ` [PATCH v9 1/2] dt-bindings: phy: eswin: Document the " Yulin Lu
2026-02-05 13:41 ` Krzysztof Kozlowski
2026-03-03 11:46 ` Bo Gan
2026-03-05 3:14 ` Min Lin
2026-02-05 8:22 ` [PATCH v9 2/2] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver Yulin Lu
2026-02-13 6:20 ` Yulin Lu [this message]
2026-02-27 15:29 ` [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22fea2d6.370e.19c55a86a72.Coremail.luyulin@eswincomputing.com \
--to=luyulin@eswincomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fenglin@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox