Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@nabladev.com>, linux-usb@vger.kernel.org
Cc: fabrice.gasnier@foss.st.com, "Pankaj Dev" <pankaj.dev@st.com>,
	"Rahul Kumar" <rahul.kumar05@st.com>,
	"Clément Le Goffic" <clement.legoffic@foss.st.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Christian Bruel" <christian.bruel@foss.st.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Rob Herring" <robh@kernel.org>, "Rosen Penev" <rosenp@gmail.com>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	devicetree@vger.kernel.org, kernel@dh-electronics.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY
Date: Thu, 27 Aug 2026 23:33:31 +0200	[thread overview]
Message-ID: <25e10cfe-40dc-45f4-8a92-cd81263420ea@kernel.org> (raw)
In-Reply-To: <34c48ff1-524f-4d24-b53f-99e7171d08db@nabladev.com>

On 27/08/2026 16:53, Marek Vasut wrote:
> On 8/27/26 2:54 PM, Krzysztof Kozlowski wrote:
>> On 22/08/2026 09:46, Marek Vasut wrote:
>>> +description:
>>> +  USB2 PHY block in STM32 is attached to USB 2.0 Host controller and
>>> +  USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS
>>> +  connectivity. Both PHYs are the FEMTO-PHY, but their configuration
>>> +  bits in the system control register are different for each variant.
>>> +
>>> +maintainers:
>>> +  - Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>>> +  - Marek Vasut <marex@nabladev.com>
>>> +  - Pankaj Dev <pankaj.dev@st.com>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - st,stm32mp25-usb2phy1
>>> +      - st,stm32mp25-usb2phy2
>>> +
>>> +  "#clock-cells":
>>> +    const: 1
>>> +
>>
>> As pointed out by different patchset built on top of it, this is wrong.
> 
> What is wrong in this (V3) of the patchset ? I think the ST patches were 
> fixing up V2 and what they were fixing up is already fixed here in V3.

Probably I got confused... but I had impression the ST patches were
adding here "reg" property, no?

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy