* [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 2/8] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
` (7 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Add hdptxphy grf syscon compatibles for rk3576.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
(no changes since v1)
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 7eca9e1ad6a3..61f38b68a4a3 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -23,6 +23,7 @@ properties:
- rockchip,rk3576-bigcore-grf
- rockchip,rk3576-cci-grf
- rockchip,rk3576-gpu-grf
+ - rockchip,rk3576-hdptxphy-grf
- rockchip,rk3576-litcore-grf
- rockchip,rk3576-npu-grf
- rockchip,rk3576-php-grf
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 2/8] dt-bindings: phy: Add rk3576 hdptx phy
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
2024-12-28 12:21 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 3/8] dt-bindings: display: rockchip: Add rk3576 hdmi controller Andy Yan
` (6 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Add compatible for the HDPTX PHY on rk3576, which is compatible with
rk3588, but without rst_phy/rst_ropll/rst_lcpll.
In fact, these three reset lines are also optional on the rk3588,
they just used for debug, then they were removed on the rk3576 IC
design.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v2:
- Wrap commit message according to Linux coding style
- Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
- Make declare phy/ropll/lcpll reset line are not exit on rk3576
.../phy/rockchip,rk3588-hdptx-phy.yaml | 62 +++++++++++++------
1 file changed, 44 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
index 84fe59dbcf48..7a307f45cdec 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
@@ -11,8 +11,13 @@ maintainers:
properties:
compatible:
- enum:
- - rockchip,rk3588-hdptx-phy
+ oneOf:
+ - enum:
+ - rockchip,rk3588-hdptx-phy
+ - items:
+ - enum:
+ - rockchip,rk3576-hdptx-phy
+ - const: rockchip,rk3588-hdptx-phy
reg:
maxItems: 1
@@ -34,24 +39,12 @@ properties:
const: 0
resets:
- items:
- - description: PHY reset line
- - description: APB reset line
- - description: INIT reset line
- - description: CMN reset line
- - description: LANE reset line
- - description: ROPLL reset line
- - description: LCPLL reset line
+ minItems: 4
+ maxItems: 7
reset-names:
- items:
- - const: phy
- - const: apb
- - const: init
- - const: cmn
- - const: lane
- - const: ropll
- - const: lcpll
+ minItems: 4
+ maxItems: 7
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
@@ -67,6 +60,39 @@ required:
- reset-names
- rockchip,grf
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-hdptx-phy
+ then:
+ properties:
+ resets:
+ minItems: 4
+ maxItems: 4
+ reset-names:
+ items:
+ - const: apb
+ - const: init
+ - const: cmn
+ - const: lane
+ else:
+ properties:
+ resets:
+ minItems: 7
+ maxItems: 7
+ reset-names:
+ items:
+ - const: phy
+ - const: apb
+ - const: init
+ - const: cmn
+ - const: lane
+ - const: ropll
+ - const: lcpll
+
additionalProperties: false
examples:
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 3/8] dt-bindings: display: rockchip: Add rk3576 hdmi controller
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
2024-12-28 12:21 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon Andy Yan
2024-12-28 12:21 ` [PATCH v2 2/8] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 4/8] dt-bindings: iommu: rockchip: Add Rockchip RK3576 Andy Yan
` (5 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
RK3576 HDMI TX Controller is very similar to that of RK3588, but
with some control bits for IO and interrupts status scattered across
different GRF.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
(no changes since v1)
.../bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml
index d8e761865f27..b838b5ec2dca 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml
@@ -29,6 +29,7 @@ allOf:
properties:
compatible:
enum:
+ - rockchip,rk3576-dw-hdmi-qp
- rockchip,rk3588-dw-hdmi-qp
reg:
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 4/8] dt-bindings: iommu: rockchip: Add Rockchip RK3576
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (2 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 3/8] dt-bindings: display: rockchip: Add rk3576 hdmi controller Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support Andy Yan
` (4 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Just like RK3588, RK3576 iommu is compatible to the existing rk3568.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
(no changes since v1)
Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
index 621dde0e45d8..6ce41d11ff5e 100644
--- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
@@ -25,6 +25,7 @@ properties:
- rockchip,rk3568-iommu
- items:
- enum:
+ - rockchip,rk3576-iommu
- rockchip,rk3588-iommu
- const: rockchip,rk3568-iommu
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (3 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 4/8] dt-bindings: iommu: rockchip: Add Rockchip RK3576 Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 14:09 ` Rob Herring (Arm)
2024-12-29 10:13 ` Krzysztof Kozlowski
2024-12-28 12:21 ` [PATCH v2 6/8] arm64: dts: rockchip: Add vop for rk3576 Andy Yan
` (3 subsequent siblings)
8 siblings, 2 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Add vop found on rk3576, the main difference between rk3576 and the
previous vop is that each VP has its own interrupt line.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v2:
- describe constraint SOC by SOC, as interrupts of rk3576 is very
different from others
- Drop Krzysztof's Reviewed-by, as this version changed a lot.
Changes in v1:
- ordered by soc name
- Add description for newly added interrupt
.../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
1 file changed, 56 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
index 2531726af306..f28cea4a6d82 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
@@ -20,6 +20,7 @@ properties:
enum:
- rockchip,rk3566-vop
- rockchip,rk3568-vop
+ - rockchip,rk3576-vop
- rockchip,rk3588-vop
reg:
@@ -37,10 +38,22 @@ properties:
- const: gamma-lut
interrupts:
- maxItems: 1
- description:
- The VOP interrupt is shared by several interrupt sources, such as
- frame start (VSYNC), line flag and other status interrupts.
+ minItems: 1
+ maxItems: 4
+ items:
+ - description:
+ vop system interrupt, such as bus error, and vsync for vop version under
+ rk3576.
+ - description:
+ independent interrupts for each video port, such as vsync and other video
+ port related error interrupts.
+
+ interrupt-names:
+ items:
+ - const: vop-sys
+ - const: vop-vp0
+ - const: vop-vp1
+ - const: vop-vp2
# See compatible-specific constraints below.
clocks:
@@ -127,31 +140,60 @@ allOf:
minItems: 7
clock-names:
minItems: 7
-
ports:
required:
- port@0
- port@1
- port@2
- port@3
-
required:
- rockchip,grf
- rockchip,vo1-grf
- rockchip,vop-grf
- rockchip,pmu
- else:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3576-vop
+ then:
properties:
- rockchip,vo1-grf: false
- rockchip,vop-grf: false
- rockchip,pmu: false
-
clocks:
- maxItems: 5
+ minItems: 5
clock-names:
- maxItems: 5
-
+ minItems: 5
+ ports:
+ required:
+ - port@0
+ - port@1
+ - port@2
+ interrupts:
+ minItems: 4
+ maxItems: 4
+ interrupt-names:
+ items:
+ - const: vop-sys
+ - const: vop-vp0
+ - const: vop-vp1
+ - const: vop-vp2
+ required:
+ - rockchip,grf
+ - rockchip,pmu
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3568-vop
+ - rockchip,rk3566-vop
+ then:
+ properties:
+ clocks:
+ minItems: 5
+ clock-names:
+ minItems: 5
ports:
required:
- port@0
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-28 12:21 ` [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support Andy Yan
@ 2024-12-28 14:09 ` Rob Herring (Arm)
2024-12-29 10:13 ` Krzysztof Kozlowski
1 sibling, 0 replies; 17+ messages in thread
From: Rob Herring (Arm) @ 2024-12-28 14:09 UTC (permalink / raw)
To: Andy Yan
Cc: vkoul, linux-phy, cristian.ciocaltea, Andy Yan, joro, iommu,
linux-kernel, linux-rockchip, heiko, dri-devel, cl,
linux-arm-kernel, devicetree, detlev.casanova, hjc, krzk+dt
On Sat, 28 Dec 2024 20:21:48 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Add vop found on rk3576, the main difference between rk3576 and the
> previous vop is that each VP has its own interrupt line.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v2:
> - describe constraint SOC by SOC, as interrupts of rk3576 is very
> different from others
> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
>
> Changes in v1:
> - ordered by soc name
> - Add description for newly added interrupt
>
> .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
> 1 file changed, 56 insertions(+), 14 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml: properties:interrupts: {'minItems': 1, 'maxItems': 4, 'items': [{'description': 'vop system interrupt, such as bus error, and vsync for vop version under rk3576.'}, {'description': 'independent interrupts for each video port, such as vsync and other video port related error interrupts.'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241228122155.646957-6-andyshrk@163.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-28 12:21 ` [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support Andy Yan
2024-12-28 14:09 ` Rob Herring (Arm)
@ 2024-12-29 10:13 ` Krzysztof Kozlowski
2024-12-29 10:49 ` Andy Yan
1 sibling, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-29 10:13 UTC (permalink / raw)
To: Andy Yan
Cc: heiko, krzk+dt, joro, cl, robh, hjc, vkoul, devicetree,
detlev.casanova, cristian.ciocaltea, dri-devel, iommu,
linux-arm-kernel, linux-kernel, linux-phy, linux-rockchip,
Andy Yan
On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Add vop found on rk3576, the main difference between rk3576 and the
> previous vop is that each VP has its own interrupt line.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v2:
> - describe constraint SOC by SOC, as interrupts of rk3576 is very
> different from others
> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
>
> Changes in v1:
> - ordered by soc name
> - Add description for newly added interrupt
>
> .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
> 1 file changed, 56 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> index 2531726af306..f28cea4a6d82 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> @@ -20,6 +20,7 @@ properties:
> enum:
> - rockchip,rk3566-vop
> - rockchip,rk3568-vop
> + - rockchip,rk3576-vop
> - rockchip,rk3588-vop
>
> reg:
> @@ -37,10 +38,22 @@ properties:
> - const: gamma-lut
>
> interrupts:
> - maxItems: 1
> - description:
> - The VOP interrupt is shared by several interrupt sources, such as
> - frame start (VSYNC), line flag and other status interrupts.
> + minItems: 1
> + maxItems: 4
> + items:
> + - description:
That's contradictory. min/max say 1-4, but here you list two interrupts.
> + vop system interrupt, such as bus error, and vsync for vop version under
> + rk3576.
> + - description:
> + independent interrupts for each video port, such as vsync and other video
> + port related error interrupts.
> +
> + interrupt-names:
> + items:
> + - const: vop-sys
> + - const: vop-vp0
> + - const: vop-vp1
> + - const: vop-vp2
And this says exactly 4.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re:Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-29 10:13 ` Krzysztof Kozlowski
@ 2024-12-29 10:49 ` Andy Yan
2024-12-31 8:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 17+ messages in thread
From: Andy Yan @ 2024-12-29 10:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: robh, iommu, heiko, devicetree, joro, hjc, dri-devel,
linux-kernel, linux-phy, vkoul, detlev.casanova, linux-arm-kernel,
Andy Yan, linux-rockchip, krzk+dt, cl
Hi Krzysztof,
At 2024-12-29 18:13:39, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> Add vop found on rk3576, the main difference between rk3576 and the
>> previous vop is that each VP has its own interrupt line.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - describe constraint SOC by SOC, as interrupts of rk3576 is very
>> different from others
>> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
>>
>> Changes in v1:
>> - ordered by soc name
>> - Add description for newly added interrupt
>>
>> .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
>> 1 file changed, 56 insertions(+), 14 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> index 2531726af306..f28cea4a6d82 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> @@ -20,6 +20,7 @@ properties:
>> enum:
>> - rockchip,rk3566-vop
>> - rockchip,rk3568-vop
>> + - rockchip,rk3576-vop
>> - rockchip,rk3588-vop
>>
>> reg:
>> @@ -37,10 +38,22 @@ properties:
>> - const: gamma-lut
>>
>> interrupts:
>> - maxItems: 1
>> - description:
>> - The VOP interrupt is shared by several interrupt sources, such as
>> - frame start (VSYNC), line flag and other status interrupts.
>> + minItems: 1
>> + maxItems: 4
>> + items:
>> + - description:
>
>That's contradictory. min/max say 1-4, but here you list two interrupts.
There are 4 interrupts on rk3576, and the other SOC only have one.
I am sorry that I am not familiar with this schema language; I have read many
other YAML bindings these days and try to write it correctly.
Maybe I should not list the interrupts-names here(then list the interrupt-name by soc at allOf: part),
like the clocks handles in samsung,usb3-drd-phy.yaml ?
>
>> + vop system interrupt, such as bus error, and vsync for vop version under
>> + rk3576.
>> + - description:
>> + independent interrupts for each video port, such as vsync and other video
>> + port related error interrupts.
>> +
>> + interrupt-names:
>> + items:
>> + - const: vop-sys
>> + - const: vop-vp0
>> + - const: vop-vp1
>> + - const: vop-vp2
>
>And this says exactly 4.
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-29 10:49 ` Andy Yan
@ 2024-12-31 8:23 ` Krzysztof Kozlowski
2024-12-31 8:43 ` Andy Yan
0 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-31 8:23 UTC (permalink / raw)
To: Andy Yan
Cc: robh, iommu, heiko, devicetree, joro, hjc, dri-devel,
linux-kernel, linux-phy, vkoul, detlev.casanova, linux-arm-kernel,
Andy Yan, linux-rockchip, krzk+dt, cl
On Sun, Dec 29, 2024 at 06:49:38PM +0800, Andy Yan wrote:
>
>
> Hi Krzysztof,
>
> At 2024-12-29 18:13:39, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
> >On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
> >> From: Andy Yan <andy.yan@rock-chips.com>
> >>
> >> Add vop found on rk3576, the main difference between rk3576 and the
> >> previous vop is that each VP has its own interrupt line.
> >>
> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> >>
> >> ---
> >>
> >> Changes in v2:
> >> - describe constraint SOC by SOC, as interrupts of rk3576 is very
> >> different from others
> >> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
> >>
> >> Changes in v1:
> >> - ordered by soc name
> >> - Add description for newly added interrupt
> >>
> >> .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
> >> 1 file changed, 56 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> >> index 2531726af306..f28cea4a6d82 100644
> >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> >> @@ -20,6 +20,7 @@ properties:
> >> enum:
> >> - rockchip,rk3566-vop
> >> - rockchip,rk3568-vop
> >> + - rockchip,rk3576-vop
> >> - rockchip,rk3588-vop
> >>
> >> reg:
> >> @@ -37,10 +38,22 @@ properties:
> >> - const: gamma-lut
> >>
> >> interrupts:
> >> - maxItems: 1
> >> - description:
> >> - The VOP interrupt is shared by several interrupt sources, such as
> >> - frame start (VSYNC), line flag and other status interrupts.
> >> + minItems: 1
> >> + maxItems: 4
> >> + items:
> >> + - description:
> >
> >That's contradictory. min/max say 1-4, but here you list two interrupts.
>
> There are 4 interrupts on rk3576, and the other SOC only have one.
But you listed two interrupts, so where does the "two" come from?
> I am sorry that I am not familiar with this schema language; I have read many
> other YAML bindings these days and try to write it correctly.
>
> Maybe I should not list the interrupts-names here(then list the interrupt-name by soc at allOf: part),
> like the clocks handles in samsung,usb3-drd-phy.yaml ?
xxx-names are supposed to be fully synced with xxx, so something needs
to be fixed here. You can of course remove interrupt-names *completely*
(but not partially, because all properties must be defined in top-level).
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re:Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
2024-12-31 8:23 ` Krzysztof Kozlowski
@ 2024-12-31 8:43 ` Andy Yan
0 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-31 8:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: robh, iommu, heiko, devicetree, joro, hjc, dri-devel,
linux-kernel, linux-phy, vkoul, detlev.casanova, linux-arm-kernel,
Andy Yan, linux-rockchip, krzk+dt, cl
Hi Krzysztof,
At 2024-12-31 16:23:39, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Sun, Dec 29, 2024 at 06:49:38PM +0800, Andy Yan wrote:
>>
>>
>> Hi Krzysztof,
>>
>> At 2024-12-29 18:13:39, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>> >On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
>> >> From: Andy Yan <andy.yan@rock-chips.com>
>> >>
>> >> Add vop found on rk3576, the main difference between rk3576 and the
>> >> previous vop is that each VP has its own interrupt line.
>> >>
>> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> >>
>> >> ---
>> >>
>> >> Changes in v2:
>> >> - describe constraint SOC by SOC, as interrupts of rk3576 is very
>> >> different from others
>> >> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
>> >>
>> >> Changes in v1:
>> >> - ordered by soc name
>> >> - Add description for newly added interrupt
>> >>
>> >> .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++----
>> >> 1 file changed, 56 insertions(+), 14 deletions(-)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> index 2531726af306..f28cea4a6d82 100644
>> >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> @@ -20,6 +20,7 @@ properties:
>> >> enum:
>> >> - rockchip,rk3566-vop
>> >> - rockchip,rk3568-vop
>> >> + - rockchip,rk3576-vop
>> >> - rockchip,rk3588-vop
>> >>
>> >> reg:
>> >> @@ -37,10 +38,22 @@ properties:
>> >> - const: gamma-lut
>> >>
>> >> interrupts:
>> >> - maxItems: 1
>> >> - description:
>> >> - The VOP interrupt is shared by several interrupt sources, such as
>> >> - frame start (VSYNC), line flag and other status interrupts.
>> >> + minItems: 1
>> >> + maxItems: 4
>> >> + items:
>> >> + - description:
>> >
>> >That's contradictory. min/max say 1-4, but here you list two interrupts.
>>
>> There are 4 interrupts on rk3576, and the other SOC only have one.
>
>But you listed two interrupts, so where does the "two" come from?
>
>> I am sorry that I am not familiar with this schema language; I have read many
>> other YAML bindings these days and try to write it correctly.
>>
>> Maybe I should not list the interrupts-names here(then list the interrupt-name by soc at allOf: part),
>> like the clocks handles in samsung,usb3-drd-phy.yaml ?
>
>xxx-names are supposed to be fully synced with xxx, so something needs
>to be fixed here. You can of course remove interrupt-names *completely*
>(but not partially, because all properties must be defined in top-level).
Thanks for your explanation, I will send a new version later.
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 6/8] arm64: dts: rockchip: Add vop for rk3576
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (4 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 7/8] arm64: dts: rockchip: Add hdmi " Andy Yan
` (2 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Add VOP and VOP_MMU found on rk3576.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 68 ++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
index 436232ffe4d1..130d11a2cc89 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
@@ -393,6 +393,11 @@ opp-950000000 {
};
};
+ display_subsystem: display-subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vop_out>;
+ };
+
firmware {
scmi: scmi {
compatible = "arm,scmi-smc";
@@ -826,6 +831,69 @@ gpu: gpu@27800000 {
status = "disabled";
};
+ vop: vop@27d00000 {
+ compatible = "rockchip,rk3576-vop";
+ reg = <0x0 0x27d00000 0x0 0x3000>, <0x0 0x27d05000 0x0 0x1000>;
+ reg-names = "vop", "gamma-lut";
+ interrupts = <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 380 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "vop-sys",
+ "vop-vp0",
+ "vop-vp1",
+ "vop-vp2";
+ clocks = <&cru ACLK_VOP>,
+ <&cru HCLK_VOP>,
+ <&cru DCLK_VP0>,
+ <&cru DCLK_VP1>,
+ <&cru DCLK_VP2>;
+ clock-names = "aclk",
+ "hclk",
+ "dclk_vp0",
+ "dclk_vp1",
+ "dclk_vp2";
+ iommus = <&vop_mmu>;
+ power-domains = <&power RK3576_PD_VOP>;
+ rockchip,grf = <&sys_grf>;
+ rockchip,pmu = <&pmu>;
+ status = "disabled";
+
+ vop_out: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vp0: port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ vp1: port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ vp2: port@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+ };
+ };
+
+ vop_mmu: iommu@27d07e00 {
+ compatible = "rockchip,rk3576-iommu", "rockchip,rk3568-iommu";
+ reg = <0x0 0x27d07e00 0x0 0x100>, <0x0 0x27d07f00 0x0 0x100>;
+ interrupts = <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_VOP>, <&cru HCLK_VOP>;
+ clock-names = "aclk", "iface";
+ #iommu-cells = <0>;
+ power-domains = <&power RK3576_PD_VOP>;
+ status = "disabled";
+ };
+
qos_hdcp1: qos@27f02000 {
compatible = "rockchip,rk3576-qos", "syscon";
reg = <0x0 0x27f02000 0x0 0x20>;
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 7/8] arm64: dts: rockchip: Add hdmi for rk3576
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (5 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 6/8] arm64: dts: rockchip: Add vop for rk3576 Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 8/8] arm64: dts: rockchip: Enable hdmi display on sige5 Andy Yan
2024-12-28 18:36 ` [PATCH v2 0/8] Add display subsystem dt node on rk3576 Heiko Stübner
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Add hdmi and it's phy dt node for rk3576.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 58 ++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
index 130d11a2cc89..b83f421dc11d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
@@ -450,6 +450,11 @@ soc {
#size-cells = <2>;
ranges;
+ hdptxphy_grf: syscon@26032000 {
+ compatible = "rockchip,rk3576-hdptxphy-grf", "syscon";
+ reg = <0x0 0x26032000 0x0 0x100>;
+ };
+
sys_grf: syscon@2600a000 {
compatible = "rockchip,rk3576-sys-grf", "syscon";
reg = <0x0 0x2600a000 0x0 0x2000>;
@@ -894,6 +899,46 @@ vop_mmu: iommu@27d07e00 {
status = "disabled";
};
+ hdmi: hdmi@27da0000 {
+ compatible = "rockchip,rk3576-dw-hdmi-qp";
+ reg = <0x0 0x27da0000 0x0 0x20000>;
+ clocks = <&cru PCLK_HDMITX0>,
+ <&cru CLK_HDMITX0_EARC>,
+ <&cru CLK_HDMITX0_REF>,
+ <&cru MCLK_SAI6_8CH>,
+ <&cru CLK_HDMITXHDP>,
+ <&cru HCLK_VO0_ROOT>;
+ clock-names = "pclk", "earc", "ref", "aud", "hdp", "hclk_vo1";
+ interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 367 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "avp", "cec", "earc", "main", "hpd";
+ phys = <&hdptxphy>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hdmi_txm0_pins &hdmi_tx_scl &hdmi_tx_sda>;
+ power-domains = <&power RK3576_PD_VO0>;
+ resets = <&cru SRST_HDMITX0_REF>, <&cru SRST_HDMITXHDP>;
+ reset-names = "ref", "hdp";
+ rockchip,grf = <&ioc_grf>;
+ rockchip,vo-grf = <&vo0_grf>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hdmi_in: port@0 {
+ reg = <0>;
+ };
+
+ hdmi_out: port@1 {
+ reg = <1>;
+ };
+ };
+ };
+
qos_hdcp1: qos@27f02000 {
compatible = "rockchip,rk3576-qos", "syscon";
reg = <0x0 0x27f02000 0x0 0x20>;
@@ -1655,6 +1700,19 @@ uart11: serial@2afd0000 {
status = "disabled";
};
+ hdptxphy: hdmiphy@2b000000 {
+ compatible = "rockchip,rk3576-hdptx-phy", "rockchip,rk3588-hdptx-phy";
+ reg = <0x0 0x2b000000 0x0 0x2000>;
+ clocks = <&cru CLK_PHY_REF_SRC>, <&cru PCLK_HDPTX_APB>;
+ clock-names = "ref", "apb";
+ resets = <&cru SRST_P_HDPTX_APB>, <&cru SRST_HDPTX_INIT>,
+ <&cru SRST_HDPTX_CMN>, <&cru SRST_HDPTX_LANE>;
+ reset-names = "apb", "init", "cmn", "lane";
+ rockchip,grf = <&hdptxphy_grf>;
+ #phy-cells = <0>;
+ status = "disabled";
+ };
+
sram: sram@3ff88000 {
compatible = "mmio-sram";
reg = <0x0 0x3ff88000 0x0 0x78000>;
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 8/8] arm64: dts: rockchip: Enable hdmi display on sige5
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (6 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 7/8] arm64: dts: rockchip: Add hdmi " Andy Yan
@ 2024-12-28 12:21 ` Andy Yan
2024-12-28 18:36 ` [PATCH v2 0/8] Add display subsystem dt node on rk3576 Heiko Stübner
8 siblings, 0 replies; 17+ messages in thread
From: Andy Yan @ 2024-12-28 12:21 UTC (permalink / raw)
To: heiko, krzk+dt, joro
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
Enable hdmi display on sige5.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
(no changes since v1)
.../boot/dts/rockchip/rk3576-armsom-sige5.dts | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 7c7331936a7f..78798b0722a3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -10,6 +10,7 @@
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/rockchip.h>
#include <dt-bindings/pwm/pwm.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include <dt-bindings/usb/pd.h>
#include "rk3576.dtsi"
@@ -26,6 +27,17 @@ chosen {
stdout-path = "serial0:1500000n8";
};
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
leds: leds {
compatible = "gpio-leds";
@@ -214,6 +226,26 @@ &gpu {
status = "okay";
};
+&hdmi {
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdptxphy {
+ status = "okay";
+};
+
&i2c1 {
status = "okay";
@@ -656,3 +688,18 @@ &uart0 {
pinctrl-0 = <&uart0m0_xfer>;
status = "okay";
};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v2 0/8] Add display subsystem dt node on rk3576
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
` (7 preceding siblings ...)
2024-12-28 12:21 ` [PATCH v2 8/8] arm64: dts: rockchip: Enable hdmi display on sige5 Andy Yan
@ 2024-12-28 18:36 ` Heiko Stübner
2024-12-29 6:48 ` Andy Yan
8 siblings, 1 reply; 17+ messages in thread
From: Heiko Stübner @ 2024-12-28 18:36 UTC (permalink / raw)
To: krzk+dt, joro, Andy Yan
Cc: cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
Hi Andy,
Am Samstag, 28. Dezember 2024, 13:21:43 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
>
> As the VOP[0] and HDMI[1] driver have already been submitted for review.
> This series send all display related device tree part together.
> [0] https://lore.kernel.org/linux-rockchip/20241219073931.3997788-1-andyshrk@163.com/T/#t
> [1] https://lore.kernel.org/linux-rockchip/20241225103741.364597-1-andyshrk@163.com/T/#t
not to confuse you too much, I mainly meant that we were missing the
"arm64: dts: rockchip:" patches from this series.
The dt-binding patches are (already) part of the driver changes and
should stay part of those series, to prevent confusion of what part goes
where :-) .
Heiko
> Changes in v2:
> - Wrap commit message according to Linux coding style
> - Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
> - Make declare phy/ropll/lcpll reset line are not exit on rk3576
> - describe constraint SOC by SOC for vop2 binding, as interrupts of rk3576
> is very different from others
> - Drop Krzysztof's Reviewed-by for vopp2 bindings, as this version changed a lot.
>
> Changes in v1:
> - ordered by soc name
> - Add description for newly added interrupt
>
> Andy Yan (8):
> dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon
> dt-bindings: phy: Add rk3576 hdptx phy
> dt-bindings: display: rockchip: Add rk3576 hdmi controller
> dt-bindings: iommu: rockchip: Add Rockchip RK3576
> dt-bindings: display: vop2: Add rk3576 support
> arm64: dts: rockchip: Add vop for rk3576
> arm64: dts: rockchip: Add hdmi for rk3576
> arm64: dts: rockchip: Enable hdmi display on sige5
>
> .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 1 +
> .../display/rockchip/rockchip-vop2.yaml | 70 ++++++++--
> .../bindings/iommu/rockchip,iommu.yaml | 1 +
> .../phy/rockchip,rk3588-hdptx-phy.yaml | 62 ++++++---
> .../devicetree/bindings/soc/rockchip/grf.yaml | 1 +
> .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 47 +++++++
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 126 ++++++++++++++++++
> 7 files changed, 276 insertions(+), 32 deletions(-)
>
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread* Re:Re: [PATCH v2 0/8] Add display subsystem dt node on rk3576
2024-12-28 18:36 ` [PATCH v2 0/8] Add display subsystem dt node on rk3576 Heiko Stübner
@ 2024-12-29 6:48 ` Andy Yan
2024-12-29 14:35 ` Heiko Stübner
0 siblings, 1 reply; 17+ messages in thread
From: Andy Yan @ 2024-12-29 6:48 UTC (permalink / raw)
To: Heiko Stübner
Cc: krzk+dt, joro, cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
Hi Heiko,
At 2024-12-29 02:36:36, "Heiko Stübner" <heiko@sntech.de> wrote:
>Hi Andy,
>
>Am Samstag, 28. Dezember 2024, 13:21:43 CET schrieb Andy Yan:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>>
>> As the VOP[0] and HDMI[1] driver have already been submitted for review.
>> This series send all display related device tree part together.
>> [0] https://lore.kernel.org/linux-rockchip/20241219073931.3997788-1-andyshrk@163.com/T/#t
>> [1] https://lore.kernel.org/linux-rockchip/20241225103741.364597-1-andyshrk@163.com/T/#t
>
>not to confuse you too much, I mainly meant that we were missing the
>"arm64: dts: rockchip:" patches from this series.
Sorry, I misunderstood it in V2 . Before go to the next step, I would like to confirm it again:
Does that mean I should:
1. the dts patches(6/8, 7/8 8/8) should be sent as a separate series.
2. PATCH 5/8 should still go with the rk3576 vop driver[0]
3. PATCH 3/8 should still go with the rk3576 hdmi dirver[1]
4. PATCH 1/8, 2/8 4/8 should still be sent separate ?
>
>The dt-binding patches are (already) part of the driver changes and
>should stay part of those series, to prevent confusion of what part goes
>where :-) .
>
>
>Heiko
>
>
>> Changes in v2:
>> - Wrap commit message according to Linux coding style
>> - Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
>> - Make declare phy/ropll/lcpll reset line are not exit on rk3576
>> - describe constraint SOC by SOC for vop2 binding, as interrupts of rk3576
>> is very different from others
>> - Drop Krzysztof's Reviewed-by for vopp2 bindings, as this version changed a lot.
>>
>> Changes in v1:
>> - ordered by soc name
>> - Add description for newly added interrupt
>>
>> Andy Yan (8):
>> dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon
>> dt-bindings: phy: Add rk3576 hdptx phy
>> dt-bindings: display: rockchip: Add rk3576 hdmi controller
>> dt-bindings: iommu: rockchip: Add Rockchip RK3576
>> dt-bindings: display: vop2: Add rk3576 support
>> arm64: dts: rockchip: Add vop for rk3576
>> arm64: dts: rockchip: Add hdmi for rk3576
>> arm64: dts: rockchip: Enable hdmi display on sige5
>>
>> .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 1 +
>> .../display/rockchip/rockchip-vop2.yaml | 70 ++++++++--
>> .../bindings/iommu/rockchip,iommu.yaml | 1 +
>> .../phy/rockchip,rk3588-hdptx-phy.yaml | 62 ++++++---
>> .../devicetree/bindings/soc/rockchip/grf.yaml | 1 +
>> .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 47 +++++++
>> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 126 ++++++++++++++++++
>> 7 files changed, 276 insertions(+), 32 deletions(-)
>>
>>
>
>
>
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/8] Add display subsystem dt node on rk3576
2024-12-29 6:48 ` Andy Yan
@ 2024-12-29 14:35 ` Heiko Stübner
0 siblings, 0 replies; 17+ messages in thread
From: Heiko Stübner @ 2024-12-29 14:35 UTC (permalink / raw)
To: Andy Yan
Cc: krzk+dt, joro, cl, robh, hjc, vkoul, devicetree, detlev.casanova,
cristian.ciocaltea, dri-devel, iommu, linux-arm-kernel,
linux-kernel, linux-phy, linux-rockchip, Andy Yan
Hi Andy,
Am Sonntag, 29. Dezember 2024, 07:48:36 CET schrieb Andy Yan:
>
> Hi Heiko,
>
> At 2024-12-29 02:36:36, "Heiko Stübner" <heiko@sntech.de> wrote:
> >Hi Andy,
> >
> >Am Samstag, 28. Dezember 2024, 13:21:43 CET schrieb Andy Yan:
> >> From: Andy Yan <andy.yan@rock-chips.com>
> >>
> >>
> >> As the VOP[0] and HDMI[1] driver have already been submitted for review.
> >> This series send all display related device tree part together.
> >> [0] https://lore.kernel.org/linux-rockchip/20241219073931.3997788-1-andyshrk@163.com/T/#t
> >> [1] https://lore.kernel.org/linux-rockchip/20241225103741.364597-1-andyshrk@163.com/T/#t
> >
> >not to confuse you too much, I mainly meant that we were missing the
> >"arm64: dts: rockchip:" patches from this series.
>
> Sorry, I misunderstood it in V2 . Before go to the next step, I would like to confirm it again:
> Does that mean I should:
> 1. the dts patches(6/8, 7/8 8/8) should be sent as a separate series.
> 2. PATCH 5/8 should still go with the rk3576 vop driver[0]
> 3. PATCH 3/8 should still go with the rk3576 hdmi dirver[1]
> 4. PATCH 1/8, 2/8 4/8 should still be sent separate ?
exactly. The reason behind this is to prevent confusion about who is
expected to apply a patch.
The dt-binding goes together with driver-changes into that subsystem-tree.
This normally also includes single bindings. So the "normal" expectation is
that the iommu-binding patch goes through the iommu tree, the phy-binding
patch goes through the phy tree and so on.
And of course the hdmi-binding patch goes together with the hdmi-driver
change.
Heiko
> >The dt-binding patches are (already) part of the driver changes and
> >should stay part of those series, to prevent confusion of what part goes
> >where :-) .
> >
> >
> >Heiko
> >
> >
> >> Changes in v2:
> >> - Wrap commit message according to Linux coding style
> >> - Make "rockchip,rk3588-hdptx-phy" const for "rockchip,rk3576-hdptx-phy"
> >> - Make declare phy/ropll/lcpll reset line are not exit on rk3576
> >> - describe constraint SOC by SOC for vop2 binding, as interrupts of rk3576
> >> is very different from others
> >> - Drop Krzysztof's Reviewed-by for vopp2 bindings, as this version changed a lot.
> >>
> >> Changes in v1:
> >> - ordered by soc name
> >> - Add description for newly added interrupt
> >>
> >> Andy Yan (8):
> >> dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon
> >> dt-bindings: phy: Add rk3576 hdptx phy
> >> dt-bindings: display: rockchip: Add rk3576 hdmi controller
> >> dt-bindings: iommu: rockchip: Add Rockchip RK3576
> >> dt-bindings: display: vop2: Add rk3576 support
> >> arm64: dts: rockchip: Add vop for rk3576
> >> arm64: dts: rockchip: Add hdmi for rk3576
> >> arm64: dts: rockchip: Enable hdmi display on sige5
> >>
> >> .../rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 1 +
> >> .../display/rockchip/rockchip-vop2.yaml | 70 ++++++++--
> >> .../bindings/iommu/rockchip,iommu.yaml | 1 +
> >> .../phy/rockchip,rk3588-hdptx-phy.yaml | 62 ++++++---
> >> .../devicetree/bindings/soc/rockchip/grf.yaml | 1 +
> >> .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 47 +++++++
> >> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 126 ++++++++++++++++++
> >> 7 files changed, 276 insertions(+), 32 deletions(-)
> >>
> >>
> >
> >
> >
> >
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 17+ messages in thread