From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4579BC2BB3F for ; Mon, 20 Nov 2023 14:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNkCqRpGkY9fQUkz66Vcmdqc6DvW+O/S2o9CqTWpfzU=; b=3lrjA/Qr13W+v0 HELSCjWA91x2yXrGgjgylliXYcTI2e4PvDbmLo/vTlrljMaXmWiisG+vR1D9n+cUG12QBw9y4aHv5 It59fPYbrYqdZX2tBA3lcdfp6BNAuQvGjiBz93OdQVzw1Q/IrU2D6cTIBfCvRG5GStgsNzs/oY6PE FjC7dIMkrukVT1RJ/6CAT6WP3vVFklDSwuQB38UefUIji0zCY9wNHvi+KtHIl6zhjR/y21zD5Jz9e c3p6K9wcVzUTykCEhMX48xBdQkRVK83zItu09dNCpnPMQm8hhhqeBM8W27KFI9iLha5FptC596Y42 9iykZUcYrsKm+LhZaXuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r55YB-00CMjk-2m; Mon, 20 Nov 2023 14:46:59 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r55Xz-00CMbP-05; Mon, 20 Nov 2023 14:46:54 +0000 Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r55Xp-00089h-Fo; Mon, 20 Nov 2023 15:46:37 +0100 From: Heiko Stuebner To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alex Bee Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Alex Bee Subject: Re: [PATCH v3 1/5] phy: rockchip-inno-usb2: Split ID interrupt phy registers Date: Mon, 20 Nov 2023 15:46:36 +0100 Message-ID: <3530941.iIbC2pHGDl@phil> In-Reply-To: <20231119121340.109025-2-knaerzche@gmail.com> References: <20231119121340.109025-1-knaerzche@gmail.com> <20231119121340.109025-2-knaerzche@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_064647_071828_3D1023F1 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Am Sonntag, 19. November 2023, 13:13:36 CET schrieb Alex Bee: > Commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ") added ID > detection interrupt registers. However the current implementation assumes > that falling and rising edge interrupt are always enabled in registers > spanning over subsequent bits. > That is not the case for RK3128's version of the phy and this > implementation can't be used as-is, since there are bits with different > purpose in between. > > This splits up the register definitions for id_det_en, id_det_en and > id_det_clr registers in rising and falling edge variants. > It's required as preparation to support RK3128's Innosilicon usb2 phy as > well in this driver and matches pretty much to what the vendor does, so I'm > not expecting issues for other SoCs with that change. > > Signed-off-by: Alex Bee Reviewed-by: Heiko Stuebner -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy