From: "Heiko Stübner" <heiko@sntech.de>
To: "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 22/31] phy: rockchip: phy-rockchip-typec: Convert to platform remove callback returning void
Date: Tue, 07 Mar 2023 13:02:51 +0100 [thread overview]
Message-ID: <3668300.MHq7AAxBmi@diego> (raw)
In-Reply-To: <20230307115900.2293120-23-u.kleine-koenig@pengutronix.de>
Am Dienstag, 7. März 2023, 12:58:51 CET schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-07 12:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:58 [PATCH 00/31] phy: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 01/31] phy: allwinner: phy-sun4i-usb: " Uwe Kleine-König
2023-03-14 20:11 ` Jernej Škrabec
2023-03-07 11:58 ` [PATCH 02/31] phy: broadcom: phy-brcm-usb: " Uwe Kleine-König
2023-03-07 16:56 ` Florian Fainelli
2023-03-07 17:06 ` Justin Chen
2023-03-07 11:58 ` [PATCH 03/31] phy: cadence: cdns-dphy: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 04/31] phy: cadence: phy-cadence-sierra: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 05/31] phy: cadence: phy-cadence-torrent: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 06/31] phy: freescale: phy-fsl-imx8qm-lvds-phy: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 07/31] phy: intel: phy-intel-lgm-combo: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 08/31] phy: mediatek: phy-mtk-mipi-dsi: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 09/31] phy: motorola: phy-cpcap-usb: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 10/31] phy: motorola: phy-mapphone-mdm6600: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 11/31] phy: phy-lgm-usb: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 12/31] phy: qualcomm: phy-qcom-apq8064-sata: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 13/31] phy: qualcomm: phy-qcom-eusb2-repeater: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 14/31] phy: qualcomm: phy-qcom-ipq806x-sata: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 15/31] phy: renesas: phy-rcar-gen3-pcie: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 16/31] phy: renesas: phy-rcar-gen3-usb2: " Uwe Kleine-König
2023-03-07 13:35 ` Geert Uytterhoeven
2023-03-07 11:58 ` [PATCH 17/31] phy: renesas: phy-rcar-gen3-usb3: " Uwe Kleine-König
2023-03-07 13:36 ` Geert Uytterhoeven
2023-03-07 11:58 ` [PATCH 18/31] phy: renesas: r8a779f0-ether-serdes: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 19/31] phy: rockchip: phy-rockchip-inno-csidphy: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 20/31] phy: rockchip: phy-rockchip-inno-dsidphy: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 21/31] phy: rockchip: phy-rockchip-inno-hdmi: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 22/31] phy: rockchip: phy-rockchip-typec: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner [this message]
2023-03-07 11:58 ` [PATCH 23/31] phy: st: phy-stm32-usbphyc: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 24/31] phy: tegra: xusb: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 25/31] phy: ti: phy-am654-serdes: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 26/31] phy: ti: phy-da8xx-usb: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 27/31] phy: ti: phy-dm816x-usb: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 28/31] phy: ti: phy-j721e-wiz: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 29/31] phy: ti: phy-omap-usb2: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 30/31] phy: ti: phy-ti-pipe3: " Uwe Kleine-König
2023-03-07 11:59 ` [PATCH 31/31] phy: ti: phy-twl4030-usb: " Uwe Kleine-König
2023-03-20 11:38 ` [PATCH 00/31] phy: " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3668300.MHq7AAxBmi@diego \
--to=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).