From: Haotien Hsu <haotienh@nvidia.com>
To: "thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "kishon@kernel.org" <kishon@kernel.org>,
"vkoul@kernel.org" <vkoul@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>, EJ Hsu <ejh@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Wayne Chang <waynec@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Jui Chang Kuo <jckuo@nvidia.com>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>
Subject: Re: [PATCH v2] phy: tegra: xusb: Fix use-after-free issue
Date: Wed, 7 Jun 2023 02:34:15 +0000 [thread overview]
Message-ID: <377c2bd5aa9d2363c2a9a0e63849207c12f47289.camel@nvidia.com> (raw)
In-Reply-To: <ZH8oKiteNGxYmw9l@orome>
On Tue, 2023-06-06 at 14:35 +0200, Thierry Reding wrote:
> On Mon, May 08, 2023 at 06:03:20PM +0800, Haotien Hsu wrote:
> > From: EJ Hsu <ejh@nvidia.com>
> >
> > For the dual-role port, it will assign the phy dev to usb-phy dev
> > and
> > use the port dev driver as the dev driver of usb-phy.
> >
> > When we try to destroy the port dev, it will destroy its dev driver
> > as well. But we did not remove the reference from usb-phy dev. This
> > might cause the use-after-free issue in KASAN.
> >
> > Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
> > Cc: stable@vger.kernel.org
> >
> > Signed-off-by: EJ Hsu <ejh@nvidia.com>
> > Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> > ---
> > V1 -> V2: Remove extra movements to clarify the change
> > ---
> > drivers/phy/tegra/xusb.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Haotien,
>
> I had already given an Acked-by on v1. Typically you should add such
> tags when you post new versions so that people don't have to repeat
> them. Anyway, here it is again:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Hi Thierry,
I see.
My mistake.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2023-06-07 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 10:03 [PATCH v2] phy: tegra: xusb: Fix use-after-free issue Haotien Hsu
2023-06-06 9:39 ` Jon Hunter
2023-06-08 11:48 ` Vinod Koul
2023-06-06 12:35 ` Thierry Reding
2023-06-07 2:34 ` Haotien Hsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=377c2bd5aa9d2363c2a9a0e63849207c12f47289.camel@nvidia.com \
--to=haotienh@nvidia.com \
--cc=ejh@nvidia.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox