[PATCH] phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280

[PATCH] phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280

[Vishnu Saini]

Aux timeout is observed on few monitors like Benq BL2420-T due to
missing swing_pre_emph_cfg.

Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
 drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 7372de05a0b8..dd5cfc0eb09d 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -571,6 +571,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = {
 static const struct qcom_edp_phy_cfg sc7280_dp_phy_cfg = {
 	.aux_cfg = edp_phy_aux_cfg_v4,
 	.vco_div_cfg = edp_phy_vco_div_cfg_v4,
+	.swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
 	.ver_ops = &qcom_edp_phy_ops_v4,
 };
 

---
base-commit: 54f966f63b379d0c62bb044b7903319776443a4a
change-id: 20260403-phy_for_next-ce3aa0eb556f

Best regards,
-- 
Vishnu Saini <vishnu.saini@oss.qualcomm.com>


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280

[Dmitry Baryshkov]

On Fri, Apr 03, 2026 at 05:54:56PM +0530, Vishnu Saini wrote:
> Aux timeout is observed on few monitors like Benq BL2420-T due to
> missing swing_pre_emph_cfg.
> 
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
>  1 file changed, 1 insertion(+)

Missing Fixes tag.

-- 
With best wishes
Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280

[Vishnu Saini]

On Fri, Apr 03, 2026 at 10:49:16PM +0300, Dmitry Baryshkov wrote:
> On Fri, Apr 03, 2026 at 05:54:56PM +0530, Vishnu Saini wrote:
> > Aux timeout is observed on few monitors like Benq BL2420-T due to
> > missing swing_pre_emph_cfg.
> > 
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
> >  drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Missing Fixes tag.

phy cfg is not initialized for sc7280 when it was added first time with:
https://lore.kernel.org/all/20220207161612.REPOST.v1.2.Iff75c0ea8499f0baf2aa5800f2c45c4128e2415a@changeid/ 
Shall i add this tag? 
Fixes: cc62512c1be3 ("phy: qcom: Add support for eDP PHY on sc7280")

Later phy cfgs added first time with below patches:
https://lore.kernel.org/r/20220810040745.3582985-5-bjorn.andersson@linaro.org
https://lore.kernel.org/r/20220810040745.3582985-6-bjorn.andersson@linaro.org

> -- 
> With best wishes
> Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280

[Konrad Dybcio]

On 4/3/26 2:24 PM, Vishnu Saini wrote:
> Aux timeout is observed on few monitors like Benq BL2420-T due to
> missing swing_pre_emph_cfg.
> 
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---

We could take it as-is to get rid of the timeouts, but 

https://lore.kernel.org/linux-arm-msm/20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com/

suggests that these values are not super correct.. I'm long overdue
for re-reviewing that, I'll hopefully do so tomorrow or next week

Konrad

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy