From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD9BCC9EC8B for ; Mon, 12 Jan 2026 13:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKcbV42qkTlOfFgOmd/KbOPf6kNMpCQM1V9/wGLNy2I=; b=3vs3PCCFYNCqhF 2Oh8aEtIP712CYCu+dChchXK77UGamx95fPxoqQFqN9g5rNLdHB9/SW6QaC8gcm2XICmKr5Vg/64T 8RushU3zhxPi1kZyPPP0NwpuN5GrPVDMDcyPiocwgWRcxCRwpdicmf5+k20bTw2o1ufN16DHDVY3V 4+hGydtc6BYpPBy0uoLSZz8B4jPsl2F4JTV8EIjDLhRyPiWqvokj6AZBAaBfxAewxGyZsAe5PPr3P alhTesSX/IJOCyPKfdU3vgg0JmdoGb0/1KrfLDLrv5jrzMzzQeEXIzIJ1k+211csahSNgiH/v6MhJ +AS/3dosvhPVnXoA7YEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfHbs-00000005NG6-1XYH; Mon, 12 Jan 2026 13:05:28 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfHbp-00000005NFN-2pvA; Mon, 12 Jan 2026 13:05:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IaMUeZ61KcIsfoWqo/Ut8gaTEoMImMfZQvRUuQXMr0A=; b=FNb9xu+tpIA986WGcfc5GGMrjd n3ULGTmqRy2V3mm8zr2D6gvBUA2NkIUJ5RPDBO5YDNYtVN/nexDz17BCrQr++Rw1YextI9pzoPX5k P8ldWbbwbEiYZhxv1cmOtiIiMuBQki4Ye/NY65H1s5cPa9L0S0FmKm0Q+vvaX+9Tw16Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vfHba-002TRY-Cd; Mon, 12 Jan 2026 14:05:10 +0100 Date: Mon, 12 Jan 2026 14:05:10 +0100 From: Andrew Lunn To: Siddharth Vadapalli Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sjakhade@cadence.com, rogerq@kernel.org, thomas.richard@bootlin.com, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH v3 2/2] phy: cadence-torrent: Add PCIe + XAUI multilink configuration for 100MHz refclk Message-ID: <38da25fd-a402-4b34-8131-0655bccc1953@lunn.ch> References: <20260112054636.108027-1-s-vadapalli@ti.com> <20260112054636.108027-3-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260112054636.108027-3-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260112_050525_711139_01F7AEA6 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Jan 12, 2026 at 11:16:31AM +0530, Siddharth Vadapalli wrote: > From: Swapnil Jakhade > > Add register sequences for PCIe + XAUI multilink configuration for > 100MHz reference clock. > > The register sequences are fetched from a table by indexing entries based > on unique 'keys' generated by the Bitwise OR defined below: > REFCLK0_RATE | REFCLK1_RATE | LINK0_TYPE | LINK1_TYPE | SSC_TYPE > > As of now, LINK_TYPE is a 3-bit value corresponding to the PHY type. > With the introduction of TYPE_XAUI, we need a 4-bit value to represent > the LINK_TYPE as TYPE_XAUI has the numerical value 8. Hence, extend the > LINKx_MASK macros to 4-bit masks. While at it, extend REFCLKx_MASK macros > as well to 4-bit masks to support reference clock frequencies that will be > added in the future. > > Adjust the 'LINKx_SHIFT' and the 'REFCLKx_SHIFT' macros to account for > the aforementioned changes made to the masks. > > Signed-off-by: Swapnil Jakhade > [s-vadapalli: elaborated on changes made to macros in the commit message] > Signed-off-by: Siddharth Vadapalli Reviewed-by: Andrew Lunn Andrew -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy