From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DCB3C5478C for ; Fri, 23 Feb 2024 14:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yI3UXka5uCfyvtpsUiY0HnmHhJxsDTLtx2nIpTYdepQ=; b=O4yWaHXKFrkCUnmM+5pw/zeAs8 QxEfyaEhMMoR+oEPArLQ1IwgAYueu70aFJIXjSWhd3u2ghYQ0as+IIP6516vVexKKdswgOgjoFTW/ 3AtmH1ASFu89hkZSgc9wMoVqY+ilSNI9wWUx6Dvgxw5je85xKamEkc2jnImgyh6qOVoamnjt2w2Nw gQnztjokj+ClUnEnDYA5BcquCvcwPxCB2aekI+rNUHTMipedeaJnW+nWTX73DEra/7f+6ECEOQ3VE J8u8VFjW1Ba8w+6NYfzd5o/fQVCt3vuSGxHWqasjl8agiIO+tYPRlsK/Yl1wOb5S8N/eNTiFdzwq/ PRuU+wLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdWxB-00000009sS1-3UGp; Fri, 23 Feb 2024 14:55:09 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdWwk-00000009sEK-2kFb for linux-phy@lists.infradead.org; Fri, 23 Feb 2024 14:54:49 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-33d90dfe73cso639293f8f.0 for ; Fri, 23 Feb 2024 06:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708700047; x=1709304847; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=cNUbkWdNlhpKbmxfuu6qZOk5j1wm/SN92RpylpPx2rA=; b=Fn8Ae1p3sfyKWogSza3wnG0MOOBPK5z/5wrEyM4UZhs4p/5kLqGmc2N598VK4LeAg8 Xa5AM7/sXg+RugWx2KdVL2CDOKPXB5K+HIRErYZwcvA9gS2BMN63bs33mcAOwb56jfaN boHJ+2PXF9+YCcT6lGSokuMOiE7rKSQ0Q3KnKAby2uRvdDPhnesV5xPsADhc9XcJiytw eeLlRb4Dm1FCCyoQku8mth4qP0blhGZnCHiE2546ijqDToeJRqQRdpztOfTKquM4ZpSD p/JQHJc3lGcZiSnF62j+0y1pA4F1LFHpFfVSgZsDRDhLGiaYMEAmZxIcwxY4cRV0mHAw FSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708700047; x=1709304847; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cNUbkWdNlhpKbmxfuu6qZOk5j1wm/SN92RpylpPx2rA=; b=Yf4+79wg0j06b4eo38pL9PMJ7spLhYPzQd9p6Z7AmNDKuUOZB6DvAH1ZqSulw8GpYR qjXfM25X54ECxmzJuvontvkXdeleMJ9a8TrAbjCeq3rYur2a4XJhecBeAIynrGD5JdD/ FHKH0ocwHt+i+WWnJnZSHsLyLQId6qEp6jJtaYYfzkhjrdwq3t+FE8FN1T9PyteeCuhC 74ZhEBC5GdKzwFWKZ52CtveiaOoB0uB1gl2uiMvANwjUROsC9ZltwgP7zfhZ+7DORhYA D32yxvpKgSl6LTO/Ej8MSEEjw+6f5nsF1MD0nqyBMs42j+st76xHbvrSHrOEawB9VCH3 il0A== X-Forwarded-Encrypted: i=1; AJvYcCVWlUDfRrH+MAc2OQCadxXA1MSA1fThaJ8GI6vUr43XldOl/mN5SurJoPV1HBQBpHpts7FXJM0uLpnqisiCWSTTkifQjzq+Yky6X4kzFQ== X-Gm-Message-State: AOJu0Yx5mcdGkOrFyFC/u4hcYpmBz6oyLty67iwd7KiB+V3S8/SsvWSK 5kJSQCqjoOobmYl9/lKC1dP6zM0pqvoTOt/lkIuEJKBw+Qhz9YLOLEvYxJApE2ndSdY5Kksfzb0 eCxlIfA== X-Google-Smtp-Source: AGHT+IHHEFVM/kLFgskVImQRztBShP4RflP5MJmVzKMK1rt1otBVKUaSq91oY7qDe/w6ZbH8jRi3mA== X-Received: by 2002:a5d:6a90:0:b0:33d:c45:15ec with SMTP id s16-20020a5d6a90000000b0033d0c4515ecmr5104778wru.32.1708700047381; Fri, 23 Feb 2024 06:54:07 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:58e3:6b80:c446:11f4? ([2a01:e0a:982:cbb0:58e3:6b80:c446:11f4]) by smtp.gmail.com with ESMTPSA id fa15-20020a05600c518f00b0041294a1d7bcsm2314742wmb.36.2024.02.23.06.54.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 06:54:06 -0800 (PST) Message-ID: <3b6dc98a-a13d-4958-b8b4-003d27c84f89@linaro.org> Date: Fri, 23 Feb 2024 15:54:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Content-Language: en-US, fr To: Johan Hovold , Bjorn Andersson , Andrzej Hajda , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul Cc: Jonas Karlman , Laurent Pinchart , Jernej Skrabec , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Kuogee Hsieh , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org References: <20240217150228.5788-1-johan+linaro@kernel.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20240217150228.5788-1-johan+linaro@kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 17/02/2024 16:02, Johan Hovold wrote: > Starting with 6.8-rc1 the internal display sometimes fails to come up on > machines like the Lenovo ThinkPad X13s and the logs indicate that this > is due to a regression in the DRM subsystem [1]. > > This series fixes a race in the pmic_glink_altmode driver which was > exposed / triggered by the transparent DRM bridges rework that went into > 6.8-rc1 and that manifested itself as a bridge failing to attach and > sometimes triggering a NULL-pointer dereference. > > The intermittent hard resets that have also been reported since 6.8-rc1 > unfortunately still remains and suggests that we are dealing with two > separate regressions. There is some indication that also the hard resets > (e.g. due to register accesses to unclocked hardware) are also due to > changes in the DRM subsystem as it happens around the time that the eDP > panel and display controller would be initialised during boot (the > runtime PM rework?). This remains to be verified, however. > > Included is also a fix for a related OF node reference leak in the > aux-hpd driver found through inspection when reworking the driver. > > The use-after-free bug is triggered by a probe deferral and highlighted > some further bugs in the involved drivers, which were registering child > devices before deferring probe. This behaviour is not correct and can > both trigger probe deferral loops and potentially also further issues > with the DRM bridge implementation. > > This series can either go through the Qualcomm SoC tree (pmic_glink) or > the DRM tree. The PHY patches do not depend on the rest of the series > and could possibly be merged separately through the PHY tree. > > Whichever gets this to mainline the fastest. > > Johan > > > [1] https://lore.kernel.org/lkml/ZctVmLK4zTwcpW3A@hovoldconsulting.com/ > > > Johan Hovold (5): > drm/bridge: aux-hpd: fix OF node leaks > drm/bridge: aux-hpd: separate allocation and registration > soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free > phy: qcom-qmp-combo: fix drm bridge registration > phy: qcom-qmp-combo: fix type-c switch registration > > Rob Clark (1): > soc: qcom: pmic_glink: Fix boot when QRTR=m > > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 70 ++++++++++++++++++----- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 16 +++--- > drivers/soc/qcom/pmic_glink.c | 21 +++---- > drivers/soc/qcom/pmic_glink_altmode.c | 16 +++++- > include/drm/bridge/aux-bridge.h | 15 +++++ > 5 files changed, 102 insertions(+), 36 deletions(-) > For the serie: Acked-by: Neil Armstrong After an offline discussion, Dmitry, it's ok to push the remaining patches to drm-misc-fixes. Thanks, Neil -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy