Re: [PATCH v2 10/10] ARM: dts: suniv: add device tree for PopStick v1.1

Krzysztof Kozlowski
2022-10-12T13:11:33Z

On 12/10/2022 01:56, Icenowy Zheng wrote:
> PopStick is a minimal Allwinner F1C200s dongle, with its USB controller
> wired to a USB Type-A port, a SD slot and a SPI NAND flash on board, and
> an on-board CH340 USB-UART converted connected to F1C200s's UART0.

(...)

> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led {
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_GREEN>;
> + gpios = <&pio 4 6 GPIO_ACTIVE_HIGH>; /* PE6 */
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + reg_vcc3v3: vcc3v3 {

Generic node names, so at least generic "regulator" prefix or suffix.

> + compatible = "regulator-fixed";
> + regulator-name = "vcc3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +};
> +
> +&mmc0 {
> + cd-gpios = <&pio 4 3 GPIO_ACTIVE_LOW>; /* PE3 */
> + bus-width = <4>;
> + disable-wp;
> + status = "okay";

Keep status as last property.

> + vmmc-supply = <&reg_vcc3v3>;
> +};
> +
> +&spi0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi0_pc_pins>;
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "spi-nand";
> + reg = <0>;

compatible and reg are by convention the first properties.

> + spi-max-frequency = <40000000>;
> +

Best regards,
Krzysztof