linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RFC 2/2] arm: dts: marvell: armada-38x: add description for usb phys
Date: Tue, 16 Jul 2024 08:16:00 +0000	[thread overview]
Message-ID: <4468f388-b9e0-4407-9be3-260d2204e9d9@solid-run.com> (raw)
In-Reply-To: <e35e0edf-f99e-4af7-8abc-c8f96b73ddd5@lunn.ch>

Am 15.07.24 um 20:12 schrieb Andrew Lunn:
> On Mon, Jul 15, 2024 at 07:47:30PM +0200, Josua Mayer wrote:
>> Armada 38x has 3x USB-2.0 utmi phys. They are almost identical to the 2x
>> utmi phys on armada 8k.
>>
>> Add descriptions for all 3 phy ports.
>>
>> Also add a syscon node covering just the usb configuration registers.
>> Armada 8K have a syscon node covering configuration registers for
>> various functions including pinmux, woith dirvers using syscon framework
> woith -> with
>
>> for register access.
>>
>> Armada 388 has various drivers directly claiming some of those
>> configuration registers. Hence a similar syscon node would compete for
>> resources with these drivers.
> Do these drivers make exclusive use of these registers? Or are
> multiple drivers using the same registers and you need something to
> mediate in order to have atomic access?

On Armada 38x these drivers exclusively use their own registers.

I suspect armada  8k was trying to avoid declaring lots of tiny ranges,
by using a syscon node.

The syscon registers accessed by cp110-utmi driver are exclusively
for usb and not accessed elsewhere.

>
> In the old days, a register space could be mapped into multiple
> drivers, so long as all the drivers agreed to it. There are probably
> orion5x, kirkwood era mvebu drivers doing this.
>  
> 	Andrew
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2024-07-16  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 17:47 [PATCH RFC 0/2] phy: mvebu-cp110-utmi: add support for armada-380 utmi phys Josua Mayer
2024-07-15 17:47 ` [PATCH RFC 1/2] " Josua Mayer
2024-07-15 18:05   ` Andrew Lunn
2024-07-16  8:30     ` Josua Mayer
2024-07-15 17:47 ` [PATCH RFC 2/2] arm: dts: marvell: armada-38x: add description for usb phys Josua Mayer
2024-07-15 18:12   ` Andrew Lunn
2024-07-16  8:16     ` Josua Mayer [this message]
2024-07-16 12:55   ` Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4468f388-b9e0-4407-9be3-260d2204e9d9@solid-run.com \
    --to=josua@solid-run.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).