Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

[Rob Herring]

On Sun, 01 Oct 2023 15:05:43 +0200, Duje Mihanović wrote:
> Convert the binding for the Marvell PXA1928 USB and HSIC PHYs from TXT
> to DT schema.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
>  .../bindings/phy/marvell,pxa1928-hsic-phy.yaml     | 37 +++++++++++++++++
>  .../bindings/phy/marvell,pxa1928-usb-phy.yaml      | 46 ++++++++++++++++++++++
>  .../devicetree/bindings/phy/pxa1928-usb-phy.txt    | 18 ---------
>  3 files changed, 83 insertions(+), 18 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.example.dts:21.34-35 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231001-pxa1928-usb-yaml-v1-1-9309a8c0c03f@skole.hr

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

[Rob Herring]

On Sun, Oct 01, 2023 at 03:05:43PM +0200, Duje Mihanović wrote:
> Convert the binding for the Marvell PXA1928 USB and HSIC PHYs from TXT
> to DT schema.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
>  .../bindings/phy/marvell,pxa1928-hsic-phy.yaml     | 37 +++++++++++++++++
>  .../bindings/phy/marvell,pxa1928-usb-phy.yaml      | 46 ++++++++++++++++++++++
>  .../devicetree/bindings/phy/pxa1928-usb-phy.txt    | 18 ---------
>  3 files changed, 83 insertions(+), 18 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml
> new file mode 100644
> index 000000000000..a477afd11329
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,pxa1928-hsic-phy.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/marvell,pxa1928-hsic-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1928 HSIC PHY
> +
> +maintainers:
> +  - devicetree@vger.kernel.org

No, should be someone with hardware or familar with it. I added this, 
but no longer have h/w or documentation. IMO, it should probably be 
removed.

The schemas are the same, so they could just be 1 document.

> +
> +properties:
> +  $nodename:
> +    pattern: '^phy@[a-f0-9]+$'
> +
> +  compatible:
> +    const: "marvell,pxa1928-hsic-phy"

Don't need quotes.

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  '#phy-cells':
> +    const: 0
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#phy-cells'
> +
> +additionalProperties: false
> diff --git a/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml
> new file mode 100644
> index 000000000000..4ae9201767ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/marvell,pxa1928-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1928 USB PHY
> +
> +maintainers:
> +  - devicetree@vger.kernel.org
> +
> +properties:
> +  $nodename:
> +    pattern: '^phy@[a-f0-9]+$'
> +
> +  compatible:
> +    const: "marvell,pxa1928-usb-phy"
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  '#phy-cells':
> +    const: 0
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#phy-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    phy@7000 {
> +      compatible = "marvell,pxa1928-usb-phy";
> +      reg = <0x7000 0xe0>;
> +      clocks = <&apmu_clocks PXA1928_CLK_USB>;
> +      #phy-cells = <0>;
> +    };
> diff --git a/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt b/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt
> deleted file mode 100644
> index da94426aa694..000000000000
> --- a/Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Marvell PXA1928 USB and HSIC PHYs
> -
> -Required properties:
> -- compatible: "marvell,pxa1928-usb-phy" or "marvell,pxa1928-hsic-phy"
> -- reg: base address and length of the registers
> -- clocks - A single clock. From common clock binding.
> -- #phys-cells: should be 0. From common phy binding.
> -- resets: reference to the reset controller
> -
> -Example:
> -
> -	usbphy: phy@7000 {
> -		compatible = "marvell,pxa1928-usb-phy";
> -		reg = <0x7000 0xe0>;
> -		clocks = <&apmu_clocks PXA1928_CLK_USB>;
> -		#phy-cells = <0>;
> -	};
> -
> 
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20231001-pxa1928-usb-yaml-809564082241
> 
> Best regards,
> -- 
> Duje Mihanović <duje.mihanovic@skole.hr>
> 
> 

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

[Duje Mihanović]

On Monday, October 2, 2023 4:36:19 PM CEST Rob Herring wrote:
> On Sun, Oct 01, 2023 at 03:05:43PM +0200, Duje Mihanović wrote:
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> 
> No, should be someone with hardware or familar with it. I added this,
> but no longer have h/w or documentation. IMO, it should probably be
> removed.

My samsung,coreprimevelte's PXA1908 uses this PHY, is it fine if I add myself 
there instead of the devicetree list?

Regards,
Duje






-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]

On Mon, Oct 02, 2023 at 04:55:08PM +0200, Duje Mihanović wrote:
> On Monday, October 2, 2023 4:36:19 PM CEST Rob Herring wrote:
> > On Sun, Oct 01, 2023 at 03:05:43PM +0200, Duje Mihanović wrote:
> > > +maintainers:
> > > +  - devicetree@vger.kernel.org
> > 
> > No, should be someone with hardware or familar with it. I added this,
> > but no longer have h/w or documentation. IMO, it should probably be
> > removed.
> 
> My samsung,coreprimevelte's PXA1908 uses this PHY, is it fine if I add myself 
> there instead of the devicetree list?

I would say, please do add yourself!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy