From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: Johan Hovold <johan@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add missing clock for X Elite
Date: Thu, 4 Sep 2025 08:51:49 +0200 [thread overview]
Message-ID: <49a1ed5b-2afd-46b5-b5b1-74dd82dae95b@linaro.org> (raw)
In-Reply-To: <04437373-c5a2-43e4-b591-921ce450f3d8@linaro.org>
On 04/09/2025 08:50, Krzysztof Kozlowski wrote:
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,x1e80100-dp-phy
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 3
>
> That's an ABI break, so you need to explain it and mention the impact.
> Reason that there is one more clock, but everything was working fine, is
> not usually enough.
Heh, I already asked for that at v1 and nothing improved.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-04 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 12:37 [PATCH v2 0/3] phy: qcom: edp: Add missing refclk clock to x1e80100 Abel Vesa
2025-09-03 12:37 ` [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add missing clock for X Elite Abel Vesa
2025-09-03 13:37 ` Konrad Dybcio
2025-09-03 23:51 ` Rob Herring
2025-09-04 8:11 ` Konrad Dybcio
2025-09-04 8:37 ` Abel Vesa
2025-09-04 6:50 ` Krzysztof Kozlowski
2025-09-04 6:51 ` Krzysztof Kozlowski [this message]
2025-09-04 8:35 ` Abel Vesa
2025-09-03 12:37 ` [PATCH v2 2/3] phy: qcom: edp: Make the number of clocks flexible Abel Vesa
2025-09-03 13:38 ` Konrad Dybcio
2025-09-03 12:37 ` [PATCH v2 3/3] arm64: dts: qcom: Add missing TCSR refclk to the DP PHYs Abel Vesa
2025-09-04 8:40 ` Konrad Dybcio
2025-09-04 8:52 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a1ed5b-2afd-46b5-b5b1-74dd82dae95b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox