Re: [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema

From: Bryan O'Donoghue <bod@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema
Date: Fri, 27 Mar 2026 22:29:29 +0000	[thread overview]
Message-ID: <556a6736-472d-4551-b5df-15e809e7e20e@kernel.org> (raw)
In-Reply-To: <2houacfdkozzk35ky5xtwe3utkvyx4lroyrhvibb5lg6lad2g6@56akvtqigaep>

On 27/03/2026 20:51, Dmitry Baryshkov wrote:
>> That's just not true. If you read the camx source code you can see
>> split/combo mode 2+1 1+1 data/clock mode requires special programming of the
>> PHY to support.
> This needs to be identified from the data-lanes / clock-lanes topology.
> And once you do that, there would be (probably) no difference in the
> hardware definition.
> 
> 
> In other words, I'd also ask to drop this mode from the DT. This
> infromation can and should be deduced from other, already-defined
> properties.

It still needs to be communicated to the PHY from the controller, 
however that is not a problem I am trying to solve now.

If I can't get consensus for PHY_QCOM_CSI2_MODE_SPLIT_DPHY then so be it.

I'll aim for DPHY only and we can come back to this topic when someone 
actually tries to enable it.

---
bod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy