From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock
Date: Fri, 9 Sep 2022 18:03:14 +0300 [thread overview]
Message-ID: <59242592-4e3d-b7c2-e0bb-b39df780c26b@linaro.org> (raw)
In-Reply-To: <d72fc00c-85ba-8b48-1fcf-42fe9e8daeee@linaro.org>
On 09/09/2022 16:30, Krzysztof Kozlowski wrote:
> On 09/09/2022 15:20, Dmitry Baryshkov wrote:
>> Add pxo clock to the 8960 bindings (used by the HDMI PLL)
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../bindings/phy/qcom,hdmi-phy-other.yaml | 23 ++++++++++++++++---
>> 1 file changed, 20 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
>> index fdb277edebeb..2c21e120ff8d 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
>> @@ -53,7 +53,6 @@ allOf:
>> contains:
>> enum:
>> - qcom,hdmi-phy-8660
>> - - qcom,hdmi-phy-8960
>> then:
>> properties:
>> clocks:
>> @@ -63,6 +62,24 @@ allOf:
>> - const: slave_iface
>> vddio-supply: false
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,hdmi-phy-8960
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 1
>> + maxItems: 2
>> + clock-names:
>> + minItems: 1
>> + items:
>> + - const: slave_iface
>> + - const: pxo
>
> Why pxo is optional? Commit msg does not say much here.
It's optional as it is not present in current DT files. The driver will
fallback to 'pxo_board' if the clock is not present.
> It seems you also miss the DTS change adding the clock.
Oh, I'll add it to v2.
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-09 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:20 [PATCH 0/6] drm/msm/hdmi: update hdmi_pll_8960 driver Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock Dmitry Baryshkov
2022-09-09 13:30 ` Krzysztof Kozlowski
2022-09-09 15:03 ` Dmitry Baryshkov [this message]
2022-09-09 16:44 ` Krzysztof Kozlowski
2022-09-09 20:29 ` Dmitry Baryshkov
2022-09-10 7:53 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 2/6] dt-bindings: phy: qcom,hdmi-phy-other: mark it as clock provider Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 3/6] drm/msm/hdmi: switch hdmi_pll_8960 to use parent_data Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 4/6] drm/msm/hdmi: make hdmi_phy_8960 OF clk provider Dmitry Baryshkov
2022-09-09 13:20 ` [PATCH 5/6] ARM: dts: qcom: apq8064: add #clock-cells to the HDMI PHY node Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
2022-09-09 13:20 ` [PATCH 6/6] ARM: dts: qcom: apq8064: use hdmi_phy for the MMCC's hdmipll clock Dmitry Baryshkov
2022-09-09 13:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59242592-4e3d-b7c2-e0bb-b39df780c26b@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox