From: Philipp Zabel <p.zabel@pengutronix.de>
To: Johan Hovold <johan+linaro@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH 2/2] phy: qcom-qmp: fix reset-controller leak on probe errors
Date: Mon, 25 Apr 2022 11:45:29 +0200 [thread overview]
Message-ID: <59b135206b456fd8f8df30a4e474e385a922bf77.camel@pengutronix.de> (raw)
In-Reply-To: <20220422130941.2044-3-johan+linaro@kernel.org>
Hi Johan,
On Fr, 2022-04-22 at 15:09 +0200, Johan Hovold wrote:
> Make sure to release the lane reset controller in case of a late probe
> error (e.g. probe deferral).
Right. grepping for "of_reset_control_get", there seem to be are a few
other drivers that might share the same issue...
> Note that due to the reset controller being defined in devicetree in
> (questionable) "lane" child nodes, devm_reset_control_get_exclusive()
> cannot be used (and we shouldn't add devres helpers for the legacy reset
> controller API).
Do you mean of_reset_control_get()? Maybe you could switch to
of_reset_control_get_exclusive() while at it?
That one might warrant a devres helper if other drivers were to adopt
the same pattern.
The patch itself looks fine to me,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-04-25 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:09 [PATCH 0/2] phy: qcom-qmp: fix leaks on probe errors Johan Hovold
2022-04-22 13:09 ` [PATCH 1/2] phy: qcom-qmp: fix struct clk leak " Johan Hovold
2022-04-26 23:36 ` Bjorn Andersson
2022-04-22 13:09 ` [PATCH 2/2] phy: qcom-qmp: fix reset-controller " Johan Hovold
2022-04-25 9:45 ` Philipp Zabel [this message]
2022-04-27 6:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b135206b456fd8f8df30a4e474e385a922bf77.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).