From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dongliang Mu <dzm91@hust.edu.cn>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: Dongliang Mu <mudongliangabcd@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qualcomm: call clk_disable_unprepare in the error handling
Date: Tue, 20 Sep 2022 15:30:28 +0200 [thread overview]
Message-ID: <5a10b8b7-3881-2f31-5a79-ddef9798184d@linaro.org> (raw)
In-Reply-To: <20220914051334.69282-1-dzm91@hust.edu.cn>
On 14/09/2022 07:13, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
>
> Smatch reports the following error:
>
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->cal_clk' from clk_prepare_enable() not released on lines:
> 58.
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->cal_sleep_clk' from clk_prepare_enable() not released on
> lines: 58.
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->phy_clk' from clk_prepare_enable() not released on lines:
> 58.
>
> Fix this by calling proper clk_disable_unprepare calls.
>
> Fixes: 0b56e9a7e835 ("phy: Group vendor specific phy drivers")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
> index 716a77748ed8..20f6dd37c7c1 100644
> --- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
> +++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
> @@ -54,8 +54,10 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy)
>
> /* Configure pins for HSIC functionality */
> pins_default = pinctrl_lookup_state(uphy->pctl, PINCTRL_STATE_DEFAULT);
> - if (IS_ERR(pins_default))
> - return PTR_ERR(pins_default);
> + if (IS_ERR(pins_default)) {
> + ret = PTR_ERR(pins_default);
> + goto err_ulpi;
> + }
>
> ret = pinctrl_select_state(uphy->pctl, pins_default);
> if (ret)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-20 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 5:13 [PATCH] phy: qualcomm: call clk_disable_unprepare in the error handling Dongliang Mu
2022-09-20 13:30 ` Neil Armstrong [this message]
2022-09-24 7:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a10b8b7-3881-2f31-5a79-ddef9798184d@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dzm91@hust.edu.cn \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mudongliangabcd@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox