From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings
Date: Wed, 24 Sep 2025 19:14:41 -0700 [thread overview]
Message-ID: <5a6b3a3e-c6f6-ba39-9edf-eab3e1815862@oss.qualcomm.com> (raw)
In-Reply-To: <un3pulyn7tv3qihdnqmktsctped32am2eglxzfpwyz3u3tqspf@fnieck3i67j2>
On 9/24/2025 6:30 PM, Dmitry Baryshkov wrote:
> On Wed, Sep 24, 2025 at 05:52:25PM -0700, Wesley Cheng wrote:
>> For SuperSpeed USB to work properly, there is a set of HW settings that
>> need to be programmed into the USB blocks within the QMP PHY. Ensure that
>> these settings follow the latest settings mentioned in the HW programming
>> guide. The QMP USB PHY on Glymur is a USB43 based PHY that will have some
>> new ways to define certain registers, such as the replacement of TXA/RXA
>> and TXB/RXB register sets. This was replaced with the LALB register set.
>>
>> There are also some PHY init updates to modify the PCS MISC register space.
>> Without these, the QMP PHY PLL locking fails.
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> ---
>> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 311 ++++++++-
>> .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h | 12 +
>> .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h | 17 +
>> .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h | 12 +
>> .../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h | 639 ++++++++++++++++++
>> .../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h | 33 +
>> .../phy-qcom-qmp-usb43-qserdes-com-v8.h | 224 ++++++
>> drivers/phy/qualcomm/phy-qcom-qmp.h | 4 +
>
> I think yo've squashed too many changes here. V5 and V6 headers should
> be a part of the previous patch.
>
Hmm, not sure what went wrong there, but I will fix it shortly and
submit as v3.
>> 8 files changed, 1251 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h
>> create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h
>>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-25 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 0:52 [PATCH v2 00/10] Introduce Glymur USB support Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 01/10] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 02/10] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible Wesley Cheng
2025-09-25 1:12 ` Dmitry Baryshkov
2025-09-25 2:12 ` Wesley Cheng
2025-09-25 2:58 ` Dmitry Baryshkov
2025-09-25 0:52 ` [PATCH v2 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 04/10] dt-bindings: usb: qcom,snps-dwc3: " Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 05/10] dt-bindings: phy: qcom,snps-eusb2-repeater: Add SMB2370 compatible Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 06/10] phy: qualcomm: Update the QMP clamp register for V6 Wesley Cheng
2025-09-25 1:29 ` Dmitry Baryshkov
2025-09-25 0:52 ` [PATCH v2 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Wesley Cheng
2025-09-25 1:30 ` Dmitry Baryshkov
2025-09-25 2:14 ` Wesley Cheng [this message]
2025-09-25 0:52 ` [PATCH v2 08/10] phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY Wesley Cheng
2025-09-25 1:31 ` Dmitry Baryshkov
2025-09-25 0:52 ` [PATCH v2 09/10] phy: qualcomm: m31-eusb2: Make clkref an optional resource Wesley Cheng
2025-09-25 0:52 ` [PATCH v2 10/10] phy: qualcomm: eusb2-repeater: Add SMB2370 eUSB2 repeater support Wesley Cheng
2025-09-25 1:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a6b3a3e-c6f6-ba39-9edf-eab3e1815862@oss.qualcomm.com \
--to=wesley.cheng@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox