From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97115C433F5 for ; Mon, 18 Apr 2022 15:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o4AbiZpor+oEeiYrUE+e4t8ZdLJreHnP6G3RmIzx9a4=; b=zYe9nRz9DGQnyS UCZF+7YqpGXtENREsszZoL+7A8Nym3J9ZglXvWzZTs6/tZvTdjTq6V63zj+w1Jwfx3Qq6jm8porBh rNh0HnRr2P9d263Q4Pk0cZCJM44LbpC/0sZQjqr7ZylXUBy0he7e9/8/Cll5a8mOXfVcGep09xj8B eLRT2pb8TqtYcnb0kP7bo8AfOhN3RNJ/7V+23RwYXwPb9cK1ySzql4EU0FTi3NtnKhtAJUjccS6Dk WBXRuRL47eJAIsv9uPu+ei6qXCaiSsh6nl3YY3zmwtynexKahi9rUbsxh6kjiqlza9DkYHG+b1VmF dW0o5wnMFM/69paoiiDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngTkb-00HZ9C-1u; Mon, 18 Apr 2022 15:57:17 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngTkO-00HZ4H-Gz for linux-phy@lists.infradead.org; Mon, 18 Apr 2022 15:57:07 +0000 Received: by mail-ed1-x52c.google.com with SMTP id b24so17893383edu.10 for ; Mon, 18 Apr 2022 08:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FjnArbiHeKmHxIQGkXFyLcDATsoCoWvdzs6hnVzyW6g=; b=EaxvZM4sPR/maCfoqX/GP+glDd5U/u7Yf8Vqg32ThP1rPQmS6FMeleFG4TqkU2F3p2 otvkn17tJ6H7Wtl9xR2NdEGg3yPRgmHAY1jS2PIOMMAucDh8ZDBsyDYSZhJ6t5xHEsNY 6B1Asd78N4dE0oC2XPc/PGtGqUjJH/iNDhDZKlfHnduhngAiKEXdvCvNyYXUxhBP/1DF IDxIzLS3vHW1irS5b69DNB/uCQBL1MbGe5l9ke/xKZmcd+Z6xleU5swAtLnNR7y8l3F2 IOfJLDRw5GK7rMzdycYDkMwtwun3yhWApXofTrKF9C9rRoN2CjCB40SXRGxOcpcDi54K YRMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FjnArbiHeKmHxIQGkXFyLcDATsoCoWvdzs6hnVzyW6g=; b=WXggpGI3Vu3LTm0YazBpOcO2wmJW5+tHgxR4Ju+CkGZbv7sbdfsG0A32y+qOE/aLlt t62xz6zY/OB/nHnhJJAiHUwjitomdeep9u9uneza2Z8aMpGSw/FzXrN9H44fXmv6IuOA CH9JPpCIQCCtloE8xbiWmIvTFtcJhB5B/S3thZVTvvFNAzWNXtO+e5hqCTWuLjIZ2FuB ua+gjOL6Q6q9V8mB+oekctIAWhS/W8CNGe4Lv2Uh9jSGS9kR+QzARf1rsiXw5c9mPIQ9 e3u7Q7ISs4SPnmj/b5DY5dZCVPpwVq4Cf5IR5/XaOSgsF8zPPBBlMqE2wxOY2AHBhTxz DowQ== X-Gm-Message-State: AOAM531qbID9YMIlx9Aq64lINkdyCKn8DCFtR10ow2hryEuO/a+P872X NpEhATQNi7A4NdxeByt2cFzAxg== X-Google-Smtp-Source: ABdhPJz5Nk0LJAe1slK1roTE+oxG1zDFX+FnoXU6Ow5CzumX7mijMS7IuiMHrwNK7ouJ9w2wLzkUnA== X-Received: by 2002:a05:6402:4253:b0:423:e4e0:fdd8 with SMTP id g19-20020a056402425300b00423e4e0fdd8mr6255768edb.193.1650297423228; Mon, 18 Apr 2022 08:57:03 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id l3-20020aa7cac3000000b00422c961c8c9sm5068097edt.78.2022.04.18.08.57.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 08:57:02 -0700 (PDT) Message-ID: <605aa014-19ac-2679-799f-c2410b3fcc3a@linaro.org> Date: Mon, 18 Apr 2022 17:57:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT 3/6] phy: rockchip: Support pcie v3 Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20220416135458.104048-1-linux@fw-web.de> <20220416135458.104048-4-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220416135458.104048-4-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_085704_575948_94A5D22D X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 16/04/2022 15:54, Frank Wunderlich wrote: > From: Frank Wunderlich > > RK3568 supports PCIe v3 using not Combphy like PCIe v2 on rk3566. > It use a dedicated pcie-phy. Add support for this. > > Signed-off-by: Frank Wunderlich > --- > driver was taken from linux 5.10 based on in > https://github.com/JeffyCN/mirrors > which now has disappeared > --- > drivers/phy/rockchip/Kconfig | 9 + > drivers/phy/rockchip/Makefile | 1 + > .../phy/rockchip/phy-rockchip-snps-pcie3.c | 278 ++++++++++++++++++ > include/dt-bindings/phy/phy-snps-pcie3.h | 21 ++ This goes to separate patch or to the bindings one. File naming is also not correct. Who is the vendor here? "rockchip," or "snps,"? The values look specific to this Rockchip implementation, so the file should be also mentioned in the bindings (e.g. in property using it). Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy