From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 035CDC48BC3 for ; Sat, 17 Feb 2024 10:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EYS6MZ15kYTeDd5yBm8Z0rgt4BWYLJjgdOYjwIN5WvI=; b=rK3cT9CJpDs0+r eIy50fnIg+s8lVMIUsaLGcQSfCXozZqstfzEXu0gUQhuC6SRLukOq18QPRVOWqLOKtVfvFy25GkqA mO6yZpmu4ATiL+khfGkwf0b8C7k8JvY4CB/sRizJIe/sBgW9+7/Oo7lDNGVD26pcO6X9hSYEWp8YV bkXrAnW+HEzjB9M8ywuf5QR4KKJaqTV3d9pwUPnfnWFCLYxowLhsGicBiUw5ojejVCloeppFddxVk YmT4tt8rQ7XdeLs6AgnGL8CgL5coG85M8m7u3nig2Zvtf+oXzzxHAg+l9eH4clGCgIRcUNLycv/XS ldIu9HVAYS+X+cMFYhrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbHiU-00000005KJ4-2BpR; Sat, 17 Feb 2024 10:14:42 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbHiR-00000005KHv-0U7U for linux-phy@lists.infradead.org; Sat, 17 Feb 2024 10:14:40 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-563cb3ba9daso2439940a12.3 for ; Sat, 17 Feb 2024 02:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708164877; x=1708769677; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TmX3c956Tt9oKUJJoVHfcBlcjeQLXpG1CQfmSUgQxYI=; b=NmS1BrTbdJjqtZIxGSxFJkGihk3tbgswc0IiuUDgEMzpXzKtzY9JzLsmnCxvrSwJgP 3XjqDkG2lhZ0I0Ha2QG0xr+xy6D5SoWbxsR1fXAs6RwYzvjqy41Y4Nk9rdEOxUnUUlvB uOzFpplzEbDuAExLwV6f+tyMIx2SbJ6S/a8pNteglrMzpTD114HHLF57XtQ1fV5u9+68 bDvv5ESk3schs5lifHvVngr80/Hwk9Nxs3unvjNGx3+iQYxIj5WPaY/ih6ttkI8GGkfk 702Znc9/Xd60DtE8pLrZqhCHnDF+qZG8BfjaabcWeHjeCJYpTU06AhUof0d8kl3FHDv+ ZnvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708164877; x=1708769677; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TmX3c956Tt9oKUJJoVHfcBlcjeQLXpG1CQfmSUgQxYI=; b=A5++GEjgCkG/2wLWSwjy9pk2Pn36FT5xBTJeyR/iNaoGBpcgU+2U7cNhatvMg+OjMN ppPf2GxdG5aS544jNdU70ZAX3GrOg9zzXTeM2fnqnVn5kdRzCWMfqbBaBy2Pqy7caxuc gat4Pxr+Y9eIvOOQFwUUvraEScmpL4ATAmybVCpmE30BIt01GxO54btAYT9Rh3OtyPOm iLCofXK4Uq4YzilHZlpqgZmZ48Yig3sIJ8bFHbJLGFmTVpMZ+ZIOhtcDZRFs7JGtgXYN MKg0X4ArUKWRRkmKmLv9sm71iZf8DdpOclfe3Rk8iD71uOaexTa6o6fA9UDTz5hlGYQA xSpg== X-Gm-Message-State: AOJu0Yzlh/n67Quo0ZvKt+LGurHUFI1lyQsfLboPG2xWGmJGO4G8FOe3 4ZRqH6xTNnmAhOYwsMhiK40w8pRMsr5pTXa1k22Y7LUfYYckaEOHzl4zv9aAwN4= X-Google-Smtp-Source: AGHT+IGgN5iuJwUgNnlb59aZEIB6wFEx4gj/jgjcfdo0uE/3UyBiDlOaJ8FFaZgGUQsX4ZMBCrSNWQ== X-Received: by 2002:a17:906:d8db:b0:a3e:3d13:5b76 with SMTP id re27-20020a170906d8db00b00a3e3d135b76mr277257ejb.73.1708164877117; Sat, 17 Feb 2024 02:14:37 -0800 (PST) Received: from [192.168.0.22] ([78.10.207.130]) by smtp.gmail.com with ESMTPSA id tl23-20020a170907c31700b00a3da5bf34absm846758ejc.207.2024.02.17.02.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 02:14:36 -0800 (PST) Message-ID: <63b3eff6-49eb-46f3-a6d9-878eddf6de53@linaro.org> Date: Sat, 17 Feb 2024 11:14:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/4] dt-binding: phy: hisi-inno-usb2: convert to YAML Content-Language: en-US To: forbidden405@outlook.com, Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Pengcheng Li , Shawn Guo Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang References: <20240216-inno-phy-v1-0-1ab912f0533f@outlook.com> <20240216-inno-phy-v1-1-1ab912f0533f@outlook.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240216-inno-phy-v1-1-1ab912f0533f@outlook.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240217_021439_237796_3778D0C1 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 16/02/2024 16:21, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > Also rename to hisilicon,inno-usb2-phy.yaml and add this name to > compatible lists. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > > Signed-off-by: Yang Xiwen > --- > .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 115 +++++++++++++++++++++ > .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 71 ------------- > 2 files changed, 115 insertions(+), 71 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml > new file mode 100644 > index 000000000000..73256eee10f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/hisilicon,inno-usb2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HiSilicon HiSTB SoCs INNO USB2 PHY device > + > +maintainers: > + - Yang Xiwen > + > +properties: > + compatible: > + minItems: 1 No, why? Compatibles must be fixed/constrained. > + items: > + - enum: > + - hisilicon,hi3798cv200-usb2-phy > + - hisilicon,hi3798mv100-usb2-phy This wasn't here before. Not explained in commit msg. > + - const: hisilicon,inno-usb2-phy > + > + reg: > + maxItems: 1 > + description: | Do not need '|' unless you need to preserve formatting. > + Should be the address space for PHY configuration register in peripheral > + controller, e.g. PERI_USB0 for USB 2.0 PHY01 on Hi3798CV200 SoC. > + Or direct MMIO address space. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + clocks: > + maxItems: 1 > + description: reference clock > + > + resets: > + maxItems: 1 > + > +patternProperties: > + 'phy@[0-9a-f]+': > + type: object > + additionalProperties: false > + description: individual ports provided by INNO PHY > + > + properties: > + reg: > + maxItems: 1 > + > + '#phy-cells': > + const: 0 > + > + resets: > + maxItems: 1 > + > + required: [reg, '#phy-cells', resets] One item per line. Look at other bindings or example-schema. > + > +required: > + - compatible > + - clocks > + - reg > + - '#address-cells' > + - '#size-cells' > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + peripheral-controller@8a20000 { > + compatible = "hisilicon,hi3798cv200-perictrl", "syscon", "simple-mfd"; > + reg = <0x8a20000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x8a20000 0x1000>; Drop the node, not related to this binding. If this binding is supposed to be part of other device in case of MFD devices or some tightly coupled ones, then could be included in the example there. > + > + usb2-phy@120 { > + compatible = "hisilicon,hi3798cv200-usb2-phy"; > + reg = <0x120 0x4>; > + clocks = <&crg HISTB_USB2_PHY1_REF_CLK>; > + resets = <&crg 0xbc 4>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy@0 { > + reg = <0>; > + #phy-cells = <0>; > + resets = <&crg 0xbc 8>; > + }; > + > + phy@1 { > + reg = <1>; > + #phy-cells = <0>; > + resets = <&crg 0xbc 9>; > + }; > + }; > + > + usb2-phy@124 { > + compatible = "hisilicon,hi3798cv200-usb2-phy"; You can keep only one example, because they are basically the same. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy