From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2441EC0015E for ; Tue, 25 Jul 2023 18:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LHlFy6NGqd2z0TTZCRYdCbxn25kI5bmE+QAyQBWW+AQ=; b=a21Q+143XylNqd iOTklanGWSI5hJEwhFgWSAllo/YP3ZXXKWXcPrD5K00oYsiE4UHzXWt7fj49gSGoTyLIjBGv8SltB 6YFkt5vlx7qBmNzPIcoEuw61HH2hVWsbH10Q23vzUvT7ofN1NWYhtdaVfWR64MD3/6wb0oY4Yljk+ BZyXE1seMCCkwVEb+d/ex+dc3FZiDXeIxZhhWjSNFop8w5Vt21+bwUAT9JdACBcZloaUBA4k+mO/5 TLh3JMWTCnmnYa90q69XTqJXhHR+mMDRBEGYFt5WFaDMskP+9t/bFB3VrYoFZ2dc1MEAhaFoAesg7 sbhKbxwLCupxRjg120VQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOMRA-008EVX-2n; Tue, 25 Jul 2023 18:07:08 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOMR8-008EUY-1F; Tue, 25 Jul 2023 18:07:07 +0000 Received: from [185.230.175.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOMR0-00067u-HF; Tue, 25 Jul 2023 20:06:58 +0200 From: Heiko Stuebner To: Sebastian Reichel Cc: linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Qu Wenruo , Rob Herring , Krzysztof =?utf-8?B?V2lsY3p5xYRza2k=?= , Simon Xue , linux-kernel@vger.kernel.org, Lorenzo Pieralisi , devicetree@vger.kernel.org, Jingoo Han , Gustavo Pimentel , linux-pci@vger.kernel.org, John Clark , Krzysztof Kozlowski , Bjorn Helgaas , Kishon Vijay Abraham I , Serge Semin , kernel@collabora.com, Vinod Koul , Shawn Lin , Conor Dooley Subject: Re: (subset) [PATCH v2 0/2] RK3588 PCIe3 support Date: Tue, 25 Jul 2023 20:06:56 +0200 Message-ID: <6404573.MHq7AAxBmi@phil> In-Reply-To: <20230724192223.5jnu5wgrzmmjz5z5@mercury.elektranox.org> References: <20230717173512.65169-1-sebastian.reichel@collabora.com> <169022594803.2911118.12432442062352790360.b4-ty@sntech.de> <20230724192223.5jnu5wgrzmmjz5z5@mercury.elektranox.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230725_110706_422372_4C801C64 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Am Montag, 24. Juli 2023, 21:22:23 CEST schrieb Sebastian Reichel: > Hi Heiko, > > On Mon, Jul 24, 2023 at 09:12:35PM +0200, Heiko Stuebner wrote: > > On Mon, 17 Jul 2023 19:35:10 +0200, Sebastian Reichel wrote: > > > This adds PCIe v3 support for RK3588. The series depends on the PCIe > > > v2 series [0], since the the same binding is used. It has been tested > > > on Rockchip EVB1 and Radxa Rock 5B. > > > > > > Note, that the PCIe3 PHY driver is currently missing bifurcation > > > support for RK3588. Thus after this series only PCIe3x4 is usable > > > (in aggregated x4 mode) without adding support for the PHY's > > > "rockchip,pcie30-phymode" DT property, which allows configuring > > > how the lanes are distributed. Aggregated 3x4 mode seems to be the > > > most common configuration. Both EVB1 and Rock 5B use it, so I > > > cannot test anything else anyways. > > > > > > [...] > > > > Applied, thanks! > > > > [2/2] arm64: dts: rockchip: rk3588: add PCIe3 support > > commit: 0acf4fa7f187cd7e3dad93f1ee14e9509687621e > > Applying this without the PCIe 2 series being applied introduces > warnings for the RK3588 dtbs_check, as mentioned in the second > setence of the text you quoted :) > > (FWIW RK356x already has the same warnings, though) darn, I didn't do a full binding check, only a "compiles" check after applying. We're at rc3 now, so I would hope that the pcie2 binding changes get applied soon'ish so I can then also pick up the dts change from there. Heiko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy