From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13FC0C54E64 for ; Mon, 25 Mar 2024 14:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=11LaKTgWSrn+96Rwv6LMAEzUBeU7NF3Br8n+WaPkHOs=; b=elvlkrCjZo036Z gA7lmm2Tegp+jgwAt5N5t+8O2SSBpbB+9pDVVupzB3vAD8YO81wym1FEeL0pTNW2mxggVf/PSXwsF CXyxVpggV/0QxEDy3lWD1ycIRDbKK7RiIFVXAi1qdcQV/SxNkfkKDr+28h4uQmuAxGQk1oMuy/2SS PsZ/an1LcoRCNvVvgD+xyRK3ztB4KYH9mnZmpPjid/FLhQeaGQA9H7oYL69/9NywLQLQIPlugUiXc 4pRuivcGUxKexMow5M9FksWbyw0oQne+PeCqtLcWW8zItS8ZfPHAAxRSBDjvikvMMtpSwTKj9LB47 pqRRNGHA3xARyBACrBVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolAz-00000000BVF-1d3C; Mon, 25 Mar 2024 14:19:49 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rolAu-00000000BSR-2Zfl; Mon, 25 Mar 2024 14:19:46 +0000 Received: from i53875aaf.versanet.de ([83.135.90.175] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rolAt-0008Lb-6m; Mon, 25 Mar 2024 15:19:43 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Sebastian Reichel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Wang , Kever Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com, Zhang Yubing Subject: Re: [PATCH v3 02/10] phy: rockchip: add usbdp combo phy driver Date: Mon, 25 Mar 2024 15:19:42 +0100 Message-ID: <6661610.4vTCxPXJkl@diego> In-Reply-To: <3274787.oiGErgHkdL@diego> References: <20240216170514.75200-1-sebastian.reichel@collabora.com> <20240216170514.75200-3-sebastian.reichel@collabora.com> <3274787.oiGErgHkdL@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_071944_806994_B03B191B X-CRM114-Status: GOOD ( 21.21 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Sebastian, Am Montag, 25. M=E4rz 2024, 15:17:26 CET schrieb Heiko St=FCbner: > Am Freitag, 16. Februar 2024, 18:01:17 CET schrieb Sebastian Reichel: > > This adds a new USBDP combo PHY with Samsung IP block driver. > > = > > The driver get lane mux and mapping info in 2 ways, supporting > > DisplayPort alternate mode or parsing from DT. When parsing from DT, > > the property "rockchip,dp-lane-mux" provide the DP mux and mapping > > info. This is needed when the PHY is not used with TypeC Alt-Mode. > > For example if the USB3 interface of the PHY is connected to a USB > > Type A connector and the DP interface is connected to a DisplayPort > > connector. > > = > > When do DP link training, need to set lane number, link rate, swing, > > and pre-emphasis via PHY configure interface. > > = > > Co-developed-by: Heiko Stuebner > > Signed-off-by: Heiko Stuebner > > Co-developed-by: Zhang Yubing > > Signed-off-by: Zhang Yubing > > Co-developed-by: Frank Wang > > Signed-off-by: Frank Wang > > Signed-off-by: Sebastian Reichel > = > after 6.9-rc1 this needs a respin with > = > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 1f3b7955c9f3..38dc96cfe403 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -1420,7 +1420,7 @@ static const struct regmap_config rk_udphy_pma_regm= ap_cfg =3D { > .max_register =3D 0x20dc, > }; > = > -static struct phy *rk_udphy_phy_xlate(struct device *dev, struct of_phan= dle_args *args) > +static struct phy *rk_udphy_phy_xlate(struct device *dev, const struct o= f_phandle_args *args) > { > struct rk_udphy *udphy =3D dev_get_drvdata(dev); > = > = > = > to honor the change from > commit 00ca8a15dafa ("phy: constify of_phandle_args in xlate") and this "nicely" overlapped with you sending that v4, with said change already included :-) . -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy