Re: [PATCH v3 3/6] drm/sun4i: Enable LVDS output on sun20i D1s/T113

From: Parthiban <parthiban@linumiz.com>
To: "Kuba Szczodrzyński" <kuba@szczodrzynski.pl>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: parthiban@linumiz.com, David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	paulk@sys-base.io
Subject: Re: [PATCH v3 3/6] drm/sun4i: Enable LVDS output on sun20i D1s/T113
Date: Thu, 22 Jan 2026 11:22:00 +0100	[thread overview]
Message-ID: <6825d5bf-9d99-4872-a61f-1b145bfd2efa@linumiz.com> (raw)
In-Reply-To: <20251116134835.447357-1-kuba@szczodrzynski.pl>

Dear Kuba,

On 11/16/25 2:48 PM, Kuba Szczodrzyński wrote:
> +static void sun20i_tcon_setup_lvds_dphy(struct sun4i_tcon *tcon,
> +					const struct drm_encoder *encoder)
> +{
> +	union phy_configure_opts opts = { };
> +
> +	if (!tcon->quirks->has_combo_dphy || !tcon->dphy)
> +		return;
> +
> +	if (phy_init(tcon->dphy))
> +		return;
> +
> +	if (phy_set_mode(tcon->dphy, PHY_MODE_LVDS))

From Documentation/driver-api/phy/phy.rst, set_mode shall be after power_on. But re-order
will fail to work for our case. Not sure if this is fine.

Thanks,
Parthiban

> +		return;
> +
> +	if (phy_configure(tcon->dphy, &opts))
> +		return;
> +
> +	if (phy_power_on(tcon->dphy))
> +		return;

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy