Re: [PATCH v6 0/4] phy: ti-pipe3: Fix clock resource handling issues

[Hongling Zeng <zhongling0719@126.com>]

     Sorry for the noise，Gentle ping.

   This series fixes clock/resource leak issues in TI PIPE3 PHY driver.
   Could you please review?

   Thanks,
   Hongling

在 2026年06月19日 11:02, Hongling Zeng 写道:
> This patch series fixes multiple clock resource handling issues in the
> ti-pipe3 PHY driver.
>
> Patch 1 fixes a critical issue where ti_pipe3_init() was ignoring the
> return value of ti_pipe3_enable_clocks(), which could lead to unclocked
> hardware access and unbalanced clock disables.
>
> Patch 2 fixes a clock resource leak when probe fails after enabling
> the SATA refclk. The error path now properly disables the clock and
> cleans up runtime PM resources.
>
> Patch 3 fixes EPROBE_DEFER handling to prevent masking probe deferral
> errors. It uses devm_clk_get_optional() for SATA refclk to properly
> handle optional clocks while still propagating -EPROBE_DEFER and other
> error codes.
>
> Patch 4 fixes a clock leak in the init error path when regmap_update_bits()
> fails in PCIe mode, adding proper clock cleanup consistent with other
> error paths.
>
> These fixes ensure proper resource cleanup on probe and init failures,
> and prevent permanent driver initialization failures due to incorrect
> error handling.
>
> Change in v6:
> - Fix all clock leak paths comprehensively
>
> Changes in v5:
> - Add patch to fix ignored clock enable return value in ti_pipe3_init()
> - Improve error handling consistency across all paths
>
> Changes in v4:
> - Use devm_clk_get_optional() for SATA refclk
> - Drop manual -ENOENT handling
>
> Hongling Zeng (4):
>    phy: ti-pipe3: Fix ignored clock enable return value in init
>    phy: ti: pipe3: Fix clock resource leak on probe errors
>    phy: ti-pipe3: Fix EPROBE_DEFER handling for clock resources
>    phy: ti-pipe3: Fix clock leak in init error path
>
>   drivers/phy/ti/phy-ti-pipe3.c | 58 ++++++++++++++++++++++++++++--------
>   1 file changed, 46 insertions(+), 12 deletions(-)
>
> --
> 2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy