Re: [PATCH v2 1/5] dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch

Chaoyi Chen
2025-07-18T10:57:08Z

Hi Krzysztof,

On 2025/7/18 16:10, Krzysztof Kozlowski wrote:
> On Fri, Jul 18, 2025 at 02:26:15PM +0800, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>>
>> The RK3399 has two USB/DP combo PHY. With the help of external Type-C
>> controller, the PHY can switch altmode between USB and DP.
>>
>> Their connection diagram is shown below:
>>
>> external Type-C Chip0 ---> USB/DP PHY0 ---+
>> | <----> CDN-DP controller
>> external Type-C Chip1 ---> USB/DP PHY1 ---+
> It looks like your "external" controller is not described. Look at your
> port property - "Connection to USB Type-C connector". Lack of proper
> hardware description leads you to claim that the PHY is the mode switch.
> I have doubts on that.
>
> You already received the comments that you need to come with rationale
> why making PHY a USB switch is correct. I don't see the arguments for
> that.

Sorry, I didn't get your point before. Now let me clear it up.

The RK3399 USB/DP commbo PHY support  change it's pin mapping, this
means that we can implement the function of typec switch by changing the
pin mapping through software configuration. In addition, DP lane can be
configured for PHYs via software. Therefore, both mode-switch and
orientation-switch are actually performed by the PHY itself, rather than
by an external Type-C controller chip. The external chip is only used to
report PD events.

Besides RK3399, RK3576/RK3588 also integrate these capabilities in their
USB/DP PHY, with both mode-switch and orientation-switch handled by the
PHY[0] .

Thanks for pointing this out. I'll add more detail in v3.

[0]: