From: Jon Hunter <jonathanh@nvidia.com>
To: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
JC Kuo <jckuo@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Wayne Chang <waynec@nvidia.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/3] phy: tegra: xusb: Use dev_err_probe()
Date: Wed, 23 Sep 2026 07:36:54 +0100 [thread overview]
Message-ID: <78798ac4-cfe0-4c0d-a79e-3f49611b7ae6@nvidia.com> (raw)
In-Reply-To: <20260921-tegra-phy-v1-2-83466bf9a7cd@nvidia.com>
On 21/09/2026 13:14, Jon Hunter wrote:
> Use the function dev_err_probe() instead of open coding the same logic.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/phy/tegra/xusb.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index d0d0b252a205..f16c81520a60 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1257,13 +1257,8 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
>
> err = tegra_xusb_setup_ports(padctl);
> if (err) {
> - const char *level = KERN_ERR;
> -
> - if (err == -EPROBE_DEFER)
> - level = KERN_DEBUG;
> -
> - dev_printk(level, &pdev->dev,
> - dev_fmt("failed to setup XUSB ports: %d\n"), err);
> + dev_err_probe(&pdev->dev, err, "failed to setup XUSB ports\n",
> + err);
Looks like I left this extra unneeded 'err' argument. I will fix this in
the next version.
Jon
--
nvpublic
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-09-23 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 12:14 [PATCH 0/3] phy: tegra: xusb: Add Tegra238 support Jon Hunter
2026-09-21 12:14 ` [PATCH 1/3] dt-bindings: phy: tegra194: Add compatible for Tegra238 Jon Hunter
2026-09-25 13:31 ` Krzysztof Kozlowski
2026-09-21 12:14 ` [PATCH 2/3] phy: tegra: xusb: Use dev_err_probe() Jon Hunter
2026-09-23 6:36 ` Jon Hunter [this message]
2026-09-21 12:14 ` [PATCH 3/3] phy: tegra: Add support for Tegra238 XUSB pad controller Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78798ac4-cfe0-4c0d-a79e-3f49611b7ae6@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jckuo@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thierry.reding@kernel.org \
--cc=vkoul@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox