From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C215C48BD1 for ; Fri, 11 Jun 2021 13:02:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62A43613CC for ; Fri, 11 Jun 2021 13:02:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62A43613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=z6bn7Mo0mj1TC6Syb9MHoYf/bHrIT9CWVehXYEqq2P4=; b=bwBTxnk0HrMaxLGWLXekudfZhc tQ69qHbCwuCZFrjlKOca7Nt3yEoQRmGCMGlRfTKq6YZSyj+h6dhQi5F0I8HHxXDiz2v2Bcd7psZo5 qEG7nZky+6r7nwmLtBfKXBjHlQ/FlQx/MUtC2L33z5NXtFYzmjiyByV8aoyVEKctwzePsXlZkbuFA UuWzLqVZ/B3KqZyOeIa7aWPTLW6RcgS7WLDln+pnfTAJFG+81O+d042jmgCGOkef1fryVLKDrEiAb +NI1k70OOylLYQAFE/CB3N6c7NyS4jW4GF6JOW9SxxvbTB+qCTCS4V/kyW1GVySYW0PtqC/6PzDYr wGh9hrQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrgnd-005LCJ-UT; Fri, 11 Jun 2021 13:02:13 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrgna-005LBV-TP for linux-phy@lists.infradead.org; Fri, 11 Jun 2021 13:02:13 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15BD1xxm043638; Fri, 11 Jun 2021 08:01:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623416519; bh=bMMWvzfrFHl4j9c+dznuq5O3XnvQE4Ox9cPFZYk/Sj4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jOzQ0IAB7U4Oxb4Ul/KKGQJuHkNxJDi8ysJpzq35QmUHfcdr2C/n9iSf4B52G3oMU lgSznlT7SZKzdeJmOgTkMV12AR1KnDYPlVuM1Smlor1lFr1IT5xxkPK4312qBseFoF OeG/i+ULj6x942viY0FRPcWyf5qYDebzuoolgVLo= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15BD1xsY094056 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Jun 2021 08:01:59 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 11 Jun 2021 08:01:59 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Fri, 11 Jun 2021 08:01:59 -0500 Received: from [10.250.212.96] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15BD1sNC022485; Fri, 11 Jun 2021 08:01:55 -0500 Subject: Re: [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps To: Aswath Govindraju , Vinod Koul CC: , Marc Kleine-Budde , Wolfgang Grandegger , Vignesh Raghavendra , Lokesh Vutla , Rob Herring , , , References: <20210510051006.11393-1-a-govindraju@ti.com> <20210510051006.11393-2-a-govindraju@ti.com> <615d3a2a-0dc2-0e87-fdac-e170542d33da@ti.com> <0150622f-8543-ac4a-fe18-f22d7862d163@ti.com> From: Kishon Vijay Abraham I Message-ID: <7913b08e-a71c-d29d-d921-c25a87c0616a@ti.com> Date: Fri, 11 Jun 2021 18:31:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0150622f-8543-ac4a-fe18-f22d7862d163@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_060211_067760_7DD7DE42 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi, On 11/06/21 6:12 pm, Aswath Govindraju wrote: > Hi Vinod, > > On 31/05/21 2:04 pm, Aswath Govindraju wrote: >> Hi Vinod, >> >> On 31/05/21 12:48 pm, Vinod Koul wrote: >>> On 10-05-21, 10:40, Aswath Govindraju wrote: >>>> In some subsystems (eg. CAN, SPI), the max link rate supported can be less >>>> than 1 Mbps and if the unit for max_link_rate is Mbps then it can't be >>>> used. Therefore, leave the decision of units to be used, to the producer >>>> and consumer. >>>> >>>> Signed-off-by: Aswath Govindraju >>>> Acked-by: Marc Kleine-Budde >>>> --- >>>> include/linux/phy/phy.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >>>> index 0ed434d02196..f3286f4cd306 100644 >>>> --- a/include/linux/phy/phy.h >>>> +++ b/include/linux/phy/phy.h >>>> @@ -125,7 +125,7 @@ struct phy_ops { >>>> /** >>>> * struct phy_attrs - represents phy attributes >>>> * @bus_width: Data path width implemented by PHY >>>> - * @max_link_rate: Maximum link rate supported by PHY (in Mbps) >>>> + * @max_link_rate: Maximum link rate supported by PHY (units to be decided by producer and consumer) >>> >>> So there are a few users of max_link_rate. It would be better that we >>> document all previous users of max_link_rate that unit is in Mbps and >>> then modify it here >>> >> >> I was able to see that the max_link_rate attribute was used at, >> >> drivers/phy/cadence/phy-cadence-torrent.c:2514: >> gphy->attrs.max_link_rate = cdns_phy->max_bit_rate; >> >> and in the bindings there is indication that the units to be used is Mbps. >> >> Can you please point me if there is any other place that I might have >> missed to look at or that might need documentation update? >> The only user seems to be Torrent and max_bit_rate is documented well in Torrent. Acked-by: Kishon Vijay Abraham I Thanks Kishon -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy